From: Arnd Bergmann <arnd@arndb.de>
To: Anson Huang <anson.huang@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Peng Fan <peng.fan@nxp.com>,
linux-clk <linux-clk@vger.kernel.org>,
Andy Duan <fugang.duan@nxp.com>, Abel Vesa <abel.vesa@nxp.com>,
Stefan Agner <stefan.agner@toradex.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
YueHaibing <yuehaibing@huawei.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module
Date: Mon, 29 Jun 2020 15:20:13 +0200 [thread overview]
Message-ID: <CAK8P3a0CcijnVxJws_kMiaOBbc4Uox40W4=-dX+BG6OeMYtFpw@mail.gmail.com> (raw)
In-Reply-To: <DB3PR0402MB39160335642AFBAC4B38C511F56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Mon, Jun 29, 2020 at 2:53 PM Anson Huang <anson.huang@nxp.com> wrote:
> > Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as
> > module
> >
> > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <Anson.Huang@nxp.com>
> > wrote:
> >
> > > --- a/drivers/clk/imx/Makefile
> > > +++ b/drivers/clk/imx/Makefile
> > > @@ -21,9 +21,9 @@ obj-$(CONFIG_MXC_CLK) += \
> > > clk-sscg-pll.o \
> > > clk-pll14xx.o
> > >
> > > -obj-$(CONFIG_MXC_CLK_SCU) += \
> > > - clk-scu.o \
> > > - clk-lpcg-scu.o
> > > +mxc-clk-scu-objs += clk-lpcg-scu.o
> > > +mxc-clk-scu-objs += clk-scu.o
> > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o
> >
> > It looks like the two modules are tightly connected, one is useless without the
> > other. How about linking them into a combined module and dropping the
> > export statement?
> >
>
> From HW perspective, the SCU clock driver and LPCG SCU clock driver are different,
> SCU clock driver is for those clocks controlled by system controller (M4 which runs a firmware),
> while LPCG SCU clock is for those clock gates inside module, which means AP core can
> control it directly via register access, no need to via SCU API.
Sorry, I misread the patch in multiple ways. First of all, you already put
clk-scu.o and clk-lpcg-scu.o files into a combined loadable module, and
I had only looked at clk-scu.c.
What I actually meant here was to link clk-scu.o together with clk-imx8qxp.o
(and possibly future chip-specific files) into a loadable module and drop
the export.
> So, I think it is NOT that tightly connected, it is because they are both for i.MX8 SoCs with SCU
> inside, so they are put together in the Makefile.
>
> If the export statement is acceptable, I think it is better to just keep it, make sense?
There is nothing wrong with the export as such, this was just an
idea to simplify the logic.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 13:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 5:53 [PATCH V3 00/10] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-29 5:53 ` [PATCH V3 01/10] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-29 5:53 ` [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build Anson Huang
2020-06-29 11:33 ` Arnd Bergmann
2020-06-29 11:40 ` Anson Huang
2020-06-29 11:58 ` Arnd Bergmann
2020-07-01 5:14 ` Anson Huang
2020-07-01 8:37 ` Arnd Bergmann
2020-07-01 9:27 ` Anson Huang
2020-07-01 9:53 ` Arnd Bergmann
2020-07-01 10:02 ` Anson Huang
2020-07-01 10:13 ` Arnd Bergmann
2020-07-01 10:20 ` Anson Huang
2020-06-29 5:53 ` [PATCH V3 03/10] ARM: imx: Select MXC_CLK for each SoC Anson Huang
2020-06-29 7:27 ` Aisheng Dong
2020-06-29 8:21 ` Anson Huang
2020-06-29 5:53 ` [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-29 11:37 ` Arnd Bergmann
2020-06-29 12:53 ` Anson Huang
2020-06-29 13:20 ` Arnd Bergmann [this message]
2020-06-29 14:52 ` Anson Huang
2020-06-29 15:08 ` Arnd Bergmann
2020-06-29 15:19 ` Anson Huang
2020-06-30 3:55 ` Dong Aisheng
2020-07-01 7:19 ` Anson Huang
2020-07-01 8:46 ` Arnd Bergmann
2020-07-01 9:28 ` Anson Huang
2020-07-01 9:40 ` Anson Huang
2020-07-01 9:54 ` Arnd Bergmann
2020-06-30 3:36 ` Dong Aisheng
2020-06-29 5:53 ` [PATCH V3 05/10] clk: imx: Support building i.MX common " Anson Huang
2020-06-29 5:53 ` [PATCH V3 06/10] clk: imx8mm: Support module build Anson Huang
2020-06-29 5:53 ` [PATCH V3 07/10] clk: imx8mn: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 08/10] clk: imx8mp: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 09/10] clk: imx8mq: " Anson Huang
2020-06-29 5:54 ` [PATCH V3 10/10] clk: imx8qxp: " Anson Huang
2020-06-29 11:40 ` Arnd Bergmann
2020-06-29 11:43 ` Anson Huang
2020-06-29 11:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0CcijnVxJws_kMiaOBbc4Uox40W4=-dX+BG6OeMYtFpw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).