From: Nava kishore Manne <navam@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: Michal Simek <michals@xilinx.com>,
Derek Kiernan <dkiernan@xilinx.com>,
Dragan Cvetic <draganc@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Rajan Vaja <RAJANV@xilinx.com>, Jolly Shah <JOLLYS@xilinx.com>,
Tejas Patel <tejasp@xlnx.xilinx.com>,
Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>,
git <git@xilinx.com>
Subject: RE: [PATCH 4/5] misc: doc: Add binding doc for the zynqmp afi config driver
Date: Thu, 29 Apr 2021 05:39:43 +0000 [thread overview]
Message-ID: <MWHPR02MB2623209FE0193119B7054FF2C25F9@MWHPR02MB2623.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20210420141504.GA3250182@robh.at.kernel.org>
Hi Rob,
Thanks for the review.
Please find my response inline.
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, April 20, 2021 7:45 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: Michal Simek <michals@xilinx.com>; Derek Kiernan
> <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.com>;
> arnd@arndb.de; gregkh@linuxfoundation.org; Rajan Vaja
> <RAJANV@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>; Tejas Patel
> <tejasp@xlnx.xilinx.com>; Amit Sunil Dhamne <amitsuni@xilinx.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; chinnikishore369@gmail.com; git <git@xilinx.com>
> Subject: Re: [PATCH 4/5] misc: doc: Add binding doc for the zynqmp afi config
> driver
>
> On Tue, Apr 20, 2021 at 01:41:52PM +0530, Nava kishore Manne wrote:
> > This patch adds the binding document for the zynqmp afi config driver.
>
> Bindings are for h/w blocks, not drivers.
>
This Binding are for h/w blocks (PS-PL bus width configurations)
For more info please refer the below links.
https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf (Page No: 54)
https://www.xilinx.com/support/documentation/ip_documentation/zynq_ultra_ps_e/v3_2/pg201-zynq-ultrascale-plus-processing-system.pdf (Page No: 42).
Please let me know if you need more info..
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > ---
> > .../bindings/misc/xlnx,zynqmp-afi-fpga.yaml | 136 ++++++++++++++++++
> > 1 file changed, 136 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,zynqmp-afi-fpga.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/misc/xlnx,zynqmp-afi-fpga.yaml
> > b/Documentation/devicetree/bindings/misc/xlnx,zynqmp-afi-fpga.yaml
> > new file mode 100644
> > index 000000000000..3ae22096b22a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/xlnx,zynqmp-afi-
> fpga.yaml
> > @@ -0,0 +1,136 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/misc/xlnx,zynqmp-afi-fpga.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xilinx ZynqMP AFI interface Manager.
> > +
> > +maintainers:
> > + - Nava kishore Manne <nava.manne@xilinx.com>
> > +
> > +description: |
> > + The Zynq UltraScale+ MPSoC Processing System core provides access
> > +from PL
> > + masters to PS internal peripherals, and memory through AXI FIFO
> > +interface(AFI)
> > + interfaces.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - xlnx,zynqmp-afi-fpga
> > +
> > + config-afi:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description: |
> > + Pairs of <regid value >
> > + The possible values of regid and values are
> > + regid - Regids of the register to be written possible values
>
> If we wanted sequences of register accesses in DT, we'd have a generic
> mechanism to do so.
>
I will try to find a better way, will get back you on this
Regards,
Navakishore.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-29 5:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 8:11 [PATCH 0/5]misc: Add afi config drivers support Nava kishore Manne
2021-04-20 8:11 ` [PATCH 1/5] misc: doc: Add binding doc for the afi config driver Nava kishore Manne
2021-04-20 8:11 ` [PATCH 2/5] misc: zynq: Add " Nava kishore Manne
2021-04-20 8:46 ` Greg KH
2021-04-20 13:36 ` Nava kishore Manne
2021-04-20 15:27 ` Greg KH
2021-04-29 6:23 ` Nava kishore Manne
2021-04-20 18:17 ` Randy Dunlap
2021-04-20 8:11 ` [PATCH 3/5] firmware: xilinx: Add afi ioctl support Nava kishore Manne
2021-04-20 8:11 ` [PATCH 4/5] misc: doc: Add binding doc for the zynqmp afi config driver Nava kishore Manne
2021-04-20 13:58 ` Rob Herring
2021-04-29 4:56 ` Nava kishore Manne
2021-04-20 14:15 ` Rob Herring
2021-04-29 5:39 ` Nava kishore Manne [this message]
2021-04-20 8:11 ` [PATCH 5/5] misc: zynqmp: Add " Nava kishore Manne
2021-04-20 8:47 ` Greg KH
2021-04-20 13:45 ` Nava kishore Manne
2021-04-20 8:51 ` Greg KH
2021-04-20 13:47 ` Nava kishore Manne
2021-04-20 15:28 ` Greg KH
2021-04-29 6:01 ` Nava kishore Manne
2021-04-20 18:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR02MB2623209FE0193119B7054FF2C25F9@MWHPR02MB2623.namprd02.prod.outlook.com \
--to=navam@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=amitsuni@xlnx.xilinx.com \
--cc=arnd@arndb.de \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dkiernan@xilinx.com \
--cc=draganc@xilinx.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=robh@kernel.org \
--cc=tejasp@xlnx.xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).