From: Nava kishore Manne <navam@xilinx.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Michal Simek <michals@xilinx.com>,
Derek Kiernan <dkiernan@xilinx.com>,
Dragan Cvetic <draganc@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>, Rajan Vaja <RAJANV@xilinx.com>,
Jolly Shah <JOLLYS@xilinx.com>,
Tejas Patel <tejasp@xlnx.xilinx.com>,
Amit Sunil Dhamne <amitsuni@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>,
git <git@xilinx.com>
Subject: RE: [PATCH 5/5] misc: zynqmp: Add afi config driver
Date: Tue, 20 Apr 2021 13:45:08 +0000 [thread overview]
Message-ID: <MWHPR02MB2623C9BAFBA0CB47449E8724C2489@MWHPR02MB2623.namprd02.prod.outlook.com> (raw)
In-Reply-To: <YH6VPt6qfxdFhFEB@kroah.com>
Hi Greg,
Please find my response inline.
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, April 20, 2021 2:18 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: robh+dt@kernel.org; Michal Simek <michals@xilinx.com>; Derek Kiernan
> <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.com>;
> arnd@arndb.de; Rajan Vaja <RAJANV@xilinx.com>; Jolly Shah
> <JOLLYS@xilinx.com>; Tejas Patel <tejasp@xlnx.xilinx.com>; Amit Sunil
> Dhamne <amitsuni@xilinx.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> chinnikishore369@gmail.com; git <git@xilinx.com>
> Subject: Re: [PATCH 5/5] misc: zynqmp: Add afi config driver
>
> On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote:
> > This patch adds zynqmp afi config driver.This is useful for the
> > configuration of the PS-PL interface on Zynq US+ MPSoC platform.
>
> Again, please spell out what those terms mean, as I have no idea :(
>
Will fix in v2
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > ---
> > drivers/misc/Kconfig | 11 ++++++
> > drivers/misc/Makefile | 1 +
> > drivers/misc/zynqmp-afi.c | 83
> > +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 95 insertions(+)
> > create mode 100644 drivers/misc/zynqmp-afi.c
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index
> > 877b43b3377d..d1ea1eeb3ac1 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -456,6 +456,17 @@ config ZYNQ_AFI
> > between PS and PL, the AXI port data path should be configured
> > with the proper Bus-width values
> >
> > +config ZYNQMP_AFI
> > + tristate "Xilinx ZYNQMP AFI support"
> > + help
> > + ZynqMP AFI driver support for writing to the AFI registers for
> > + configuring PS_PL Bus-width. Xilinx Zynq US+ MPSoC connect the
> > + PS to the programmable logic (PL) through the AXI port. This AXI
> > + port helps to establish the data path between the PS and PL.
> > + In-order to establish the proper communication path between
> > + PS and PL, the AXI port data path should be configured with
> > + the proper Bus-width values
>
> Please use tabs properly, you mix them above, checkpatch should have
> caught that.
>
Yes, Ideally check patch should report this issue but it's failed to report.
Will fix this issue in v2.
Regards,
Navakishore.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-20 13:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 8:11 [PATCH 0/5]misc: Add afi config drivers support Nava kishore Manne
2021-04-20 8:11 ` [PATCH 1/5] misc: doc: Add binding doc for the afi config driver Nava kishore Manne
2021-04-20 8:11 ` [PATCH 2/5] misc: zynq: Add " Nava kishore Manne
2021-04-20 8:46 ` Greg KH
2021-04-20 13:36 ` Nava kishore Manne
2021-04-20 15:27 ` Greg KH
2021-04-29 6:23 ` Nava kishore Manne
2021-04-20 18:17 ` Randy Dunlap
2021-04-20 8:11 ` [PATCH 3/5] firmware: xilinx: Add afi ioctl support Nava kishore Manne
2021-04-20 8:11 ` [PATCH 4/5] misc: doc: Add binding doc for the zynqmp afi config driver Nava kishore Manne
2021-04-20 13:58 ` Rob Herring
2021-04-29 4:56 ` Nava kishore Manne
2021-04-20 14:15 ` Rob Herring
2021-04-29 5:39 ` Nava kishore Manne
2021-04-20 8:11 ` [PATCH 5/5] misc: zynqmp: Add " Nava kishore Manne
2021-04-20 8:47 ` Greg KH
2021-04-20 13:45 ` Nava kishore Manne [this message]
2021-04-20 8:51 ` Greg KH
2021-04-20 13:47 ` Nava kishore Manne
2021-04-20 15:28 ` Greg KH
2021-04-29 6:01 ` Nava kishore Manne
2021-04-20 18:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR02MB2623C9BAFBA0CB47449E8724C2489@MWHPR02MB2623.namprd02.prod.outlook.com \
--to=navam@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=amitsuni@xilinx.com \
--cc=arnd@arndb.de \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dkiernan@xilinx.com \
--cc=draganc@xilinx.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=tejasp@xlnx.xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).