linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
       [not found] <YDvLYzsGu+l1pQ2y@localhost.localdomain>
@ 2021-02-28 16:59 ` Alexey Dobriyan
  2021-03-01 10:19   ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2021-02-28 16:59 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, linux-kernel, linux-arm-kernel, linux

From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 9 Feb 2021 14:37:40 +0300
Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types

Generate arch/arm/include/generated/asm/mach-types.h without include
guard.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
 arch/arm/tools/gen-mach-types | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
index cbe1c33bb871..c28cd4b50f76 100644
--- a/arch/arm/tools/gen-mach-types
+++ b/arch/arm/tools/gen-mach-types
@@ -23,12 +23,11 @@ NF == 3 {
 
 
 END	{
+	  printf("#pragma once\n");
 	  printf("/*\n");
 	  printf(" * This was automagically generated from %s!\n", FILENAME);
 	  printf(" * Do NOT edit\n");
-	  printf(" */\n\n");
-	  printf("#ifndef __ASM_ARM_MACH_TYPE_H\n");
-	  printf("#define __ASM_ARM_MACH_TYPE_H\n\n");
+	  printf(" */\n");
 	  printf("#ifndef __ASSEMBLY__\n");
 	  printf("/* The type of machine we're running on */\n");
 	  printf("extern unsigned int __machine_arch_type;\n");
@@ -68,6 +67,5 @@ END	{
 
 	  printf("\n#ifndef machine_arch_type\n");
 	  printf("#define machine_arch_type\t__machine_arch_type\n");
-	  printf("#endif\n\n");
 	  printf("#endif\n");
 	}
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
  2021-02-28 16:59 ` [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types Alexey Dobriyan
@ 2021-03-01 10:19   ` Russell King - ARM Linux admin
  2021-03-02 15:15     ` Alexey Dobriyan
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2021-03-01 10:19 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: akpm, torvalds, linux-kernel, linux-arm-kernel

On Sun, Feb 28, 2021 at 07:59:16PM +0300, Alexey Dobriyan wrote:
> From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Tue, 9 Feb 2021 14:37:40 +0300
> Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
> 
> Generate arch/arm/include/generated/asm/mach-types.h without include
> guard.

The fundamental question of "why" is missing from this commit message.
Are we making this change to all kernel headers?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
  2021-03-01 10:19   ` Russell King - ARM Linux admin
@ 2021-03-02 15:15     ` Alexey Dobriyan
  0 siblings, 0 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2021-03-02 15:15 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: torvalds, linux-kernel, akpm, linux-arm-kernel

On Mon, Mar 01, 2021 at 10:19:50AM +0000, Russell King - ARM Linux admin wrote:
> On Sun, Feb 28, 2021 at 07:59:16PM +0300, Alexey Dobriyan wrote:
> > From 72842f89ae91a4d02ea29604f87c373052bd3f64 Mon Sep 17 00:00:00 2001
> > From: Alexey Dobriyan <adobriyan@gmail.com>
> > Date: Tue, 9 Feb 2021 14:37:40 +0300
> > Subject: [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types
> > 
> > Generate arch/arm/include/generated/asm/mach-types.h without include
> > guard.
> 
> The fundamental question of "why" is missing from this commit message.
> Are we making this change to all kernel headers?

Apparently, no. Linus doesn't like it.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-03 19:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <YDvLYzsGu+l1pQ2y@localhost.localdomain>
2021-02-28 16:59 ` [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types Alexey Dobriyan
2021-03-01 10:19   ` Russell King - ARM Linux admin
2021-03-02 15:15     ` Alexey Dobriyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).