From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>
Cc: bbrezillon@kernel.org, dri-devel@lists.freedesktop.org,
Chen-Yu Tsai <wens@csie.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jagan Teki <jagan@openedev.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/8] drm/sun4i: dsi: Fix front vs back porch calculation
Date: Tue, 12 Feb 2019 16:41:22 +0100 [thread overview]
Message-ID: <ff43713a1f2e491608296b48ae8c867949c70fbd.camel@bootlin.com> (raw)
In-Reply-To: <90c2375b8a853cae0dcc135cedb47edbc26168d8.1549896081.git-series.maxime.ripard@bootlin.com>
Hi,
On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote:
> Since I always confuse the back and front porches, a few miscalculation
> slipped through. Fix them.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Food for thoughts: everything indicates that backporch does not count
sync length for the DSI registers (while it does for TCON). So all
these changes look good!
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> ---
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> index 506f2e8cf454..2518a0d7567c 100644
> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> @@ -477,7 +477,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
> */
> #define HBP_PACKET_OVERHEAD 6
> hbp = max((unsigned int)HBP_PACKET_OVERHEAD,
> - (mode->hsync_start - mode->hdisplay) * Bpp - HBP_PACKET_OVERHEAD);
> + (mode->htotal - mode->hsync_end) * Bpp - HBP_PACKET_OVERHEAD);
>
> /*
> * The frontporch is set using a blanking packet (4 bytes +
> @@ -485,7 +485,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
> */
> #define HFP_PACKET_OVERHEAD 6
> hfp = max((unsigned int)HFP_PACKET_OVERHEAD,
> - (mode->htotal - mode->hsync_end) * Bpp - HFP_PACKET_OVERHEAD);
> + (mode->hsync_start - mode->hdisplay) * Bpp - HFP_PACKET_OVERHEAD);
>
> /*
> * hblk seems to be the line + porches length.
> @@ -531,8 +531,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
> regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG,
> SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end -
> mode->vsync_start) |
> - SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start -
> - mode->vdisplay));
> + SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal -
> + mode->vsync_end));
>
> regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG,
> SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) |
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-12 15:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 14:41 [PATCH v3 0/8] drm/sun4i: dsi: Add burst mode support Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 1/8] drm/sun4i: dsi: Restrict DSI tcon clock divider Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 2/8] drm/sun4i: dsi: Change the start delay calculation Maxime Ripard
2019-02-12 15:28 ` Paul Kocialkowski
2019-02-12 15:45 ` Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 3/8] drm/sun4i: dsi: Enforce boundaries on the start delay Maxime Ripard
2019-02-12 15:30 ` Paul Kocialkowski
2019-02-14 9:21 ` Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 4/8] drm/sun4i: dsi: Fix front vs back porch calculation Maxime Ripard
2019-02-12 15:41 ` Paul Kocialkowski [this message]
2019-02-11 14:41 ` [PATCH v3 5/8] drm/sun4i: dsi: Fix DRQ calculation Maxime Ripard
2019-02-13 14:33 ` Paul Kocialkowski
2019-02-14 9:23 ` Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 6/8] drm/sun4i: dsi: Rework a bit the hblk calculation Maxime Ripard
2019-02-13 14:41 ` Paul Kocialkowski
2019-02-11 14:41 ` [PATCH v3 7/8] drm/sun4i: dsi: Add burst support Maxime Ripard
2019-02-13 14:36 ` Paul Kocialkowski
2019-02-14 9:15 ` Maxime Ripard
2019-02-11 14:41 ` [PATCH v3 8/8] drm/panel: Add Ronbo RB070D30 panel Maxime Ripard
2019-02-11 15:13 ` Sam Ravnborg
2019-02-13 14:26 ` Paul Kocialkowski
2019-02-14 11:07 ` Re[2]: " Konstantin Sudakov
2019-02-12 10:32 ` [PATCH v3 0/8] drm/sun4i: dsi: Add burst mode support Jagan Teki
2019-02-15 14:12 ` Maxime Ripard
[not found] ` <CAMty3ZAA90-fHPADJSE3ht9CiYWA3yBoyEy7wVv9=6C5JiaTVw@mail.gmail.com>
2019-02-15 17:07 ` Jagan Teki
2019-02-18 8:26 ` Paul Kocialkowski
2019-02-18 10:31 ` Jagan Teki
2019-02-20 16:35 ` Maxime Ripard
2019-02-26 6:48 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff43713a1f2e491608296b48ae8c867949c70fbd.camel@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@openedev.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=seanpaul@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).