* [PATCH] mmc: sdhci: msm: Boost controller core clock
@ 2015-06-26 11:16 Ivan T. Ivanov
2015-06-26 11:34 ` Georgi Djakov
2015-07-02 0:18 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Ivan T. Ivanov @ 2015-06-26 11:16 UTC (permalink / raw)
To: Ulf Hansson
Cc: Georgi Djakov, Stephen Boyd, Peter Griffin, linux-mmc,
linux-kernel, linux-arm-msm
Ensure SDCC is working with maximum clock otherwise card
detection could be extremely slow, up to 7 seconds.
Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
drivers/mmc/host/sdhci-msm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 4a09f76..b2556bc 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
goto pclk_disable;
}
+ /* Vote for maximum clock rate for maximum performance */
+ ret = clk_set_rate(msm_host->clk, INT_MAX);
+ if (ret)
+ dev_warn(&pdev->dev, "core clock boost falied\n");
+
ret = clk_prepare_enable(msm_host->clk);
if (ret)
goto pclk_disable;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci: msm: Boost controller core clock
2015-06-26 11:16 [PATCH] mmc: sdhci: msm: Boost controller core clock Ivan T. Ivanov
@ 2015-06-26 11:34 ` Georgi Djakov
2015-06-26 11:59 ` Ivan T. Ivanov
2015-07-02 0:18 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Georgi Djakov @ 2015-06-26 11:34 UTC (permalink / raw)
To: Ivan T. Ivanov, Ulf Hansson
Cc: Stephen Boyd, Peter Griffin, linux-mmc, linux-kernel, linux-arm-msm
On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> Ensure SDCC is working with maximum clock otherwise card
> detection could be extremely slow, up to 7 seconds.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> drivers/mmc/host/sdhci-msm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 4a09f76..b2556bc 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> goto pclk_disable;
> }
>
> + /* Vote for maximum clock rate for maximum performance */
> + ret = clk_set_rate(msm_host->clk, INT_MAX);
> + if (ret)
> + dev_warn(&pdev->dev, "core clock boost falied\n");
failed?
Otherwise looks good to me.
> +
> ret = clk_prepare_enable(msm_host->clk);
> if (ret)
> goto pclk_disable;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci: msm: Boost controller core clock
2015-06-26 11:34 ` Georgi Djakov
@ 2015-06-26 11:59 ` Ivan T. Ivanov
0 siblings, 0 replies; 4+ messages in thread
From: Ivan T. Ivanov @ 2015-06-26 11:59 UTC (permalink / raw)
To: Georgi Djakov
Cc: Ulf Hansson, Stephen Boyd, Peter Griffin, linux-mmc,
linux-kernel, linux-arm-msm
On Fri, 2015-06-26 at 14:34 +0300, Georgi Djakov wrote:
> On 06/26/2015 02:16 PM, Ivan T. Ivanov wrote:
> > Ensure SDCC is working with maximum clock otherwise card
> > detection could be extremely slow, up to 7 seconds.
> >
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> > drivers/mmc/host/sdhci-msm.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> > index 4a09f76..b2556bc 100644
> > --- a/drivers/mmc/host/sdhci-msm.c
> > +++ b/drivers/mmc/host/sdhci-msm.c
> > @@ -489,6 +489,11 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> > goto pclk_disable;
> > }
> >
> > + /* Vote for maximum clock rate for maximum performance */
> > + ret = clk_set_rate(msm_host->clk, INT_MAX);
> > + if (ret)
> > + dev_warn(&pdev->dev, "core clock boost falied\n");
>
> failed?
>
> Otherwise looks good to me.
>
Oops, will fix.
Thanks,
Ivan
> > +
> > ret = clk_prepare_enable(msm_host->clk);
> > if (ret)
> > goto pclk_disable;
> > --
> > 1.9.1
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci: msm: Boost controller core clock
2015-06-26 11:16 [PATCH] mmc: sdhci: msm: Boost controller core clock Ivan T. Ivanov
2015-06-26 11:34 ` Georgi Djakov
@ 2015-07-02 0:18 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2015-07-02 0:18 UTC (permalink / raw)
To: Ivan T. Ivanov, Ulf Hansson
Cc: Georgi Djakov, Peter Griffin, linux-mmc, linux-kernel, linux-arm-msm
On 06/26/2015 04:16 AM, Ivan T. Ivanov wrote:
> Ensure SDCC is working with maximum clock otherwise card
> detection could be extremely slow, up to 7 seconds.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
With the typo fixed.
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-02 0:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26 11:16 [PATCH] mmc: sdhci: msm: Boost controller core clock Ivan T. Ivanov
2015-06-26 11:34 ` Georgi Djakov
2015-06-26 11:59 ` Ivan T. Ivanov
2015-07-02 0:18 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).