[PATCH] clk: qcom: clk-smd-rpm: Fix invalid RPM_SMD_PCNOC_A_CLK entry

[PATCH] clk: qcom: clk-smd-rpm: Fix invalid RPM_SMD_PCNOC_A_CLK entry

[Bryan O'Donoghue]

MSM8936 and MSM8939 both share the same RPMCC clock tree, I've been testing
on MSM8939 and I've found that RPM_SMD_PCNOC_A_CLK is currently invalid.

RPM_SMD_PCNOC_A_CLK should point to msm8916_pcnoc_a_clk not to
msm8916_pcnoc_clk.

Fixes: a0384ecfe2aa8 ("clk: qcom: smd-rpm: De-duplicate identical entries")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/clk/qcom/clk-smd-rpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
index 800b2fef1887f..b2c142f3a649e 100644
--- a/drivers/clk/qcom/clk-smd-rpm.c
+++ b/drivers/clk/qcom/clk-smd-rpm.c
@@ -467,7 +467,7 @@ DEFINE_CLK_SMD_RPM(msm8936, sysmmnoc_clk, sysmmnoc_a_clk, QCOM_SMD_RPM_BUS_CLK,
 
 static struct clk_smd_rpm *msm8936_clks[] = {
 	[RPM_SMD_PCNOC_CLK]		= &msm8916_pcnoc_clk,
-	[RPM_SMD_PCNOC_A_CLK]		= &msm8916_pcnoc_clk,
+	[RPM_SMD_PCNOC_A_CLK]		= &msm8916_pcnoc_a_clk,
 	[RPM_SMD_SNOC_CLK]		= &msm8916_snoc_clk,
 	[RPM_SMD_SNOC_A_CLK]		= &msm8916_snoc_a_clk,
 	[RPM_SMD_BIMC_CLK]		= &msm8916_bimc_clk,
-- 
2.30.1

Re: [PATCH] clk: qcom: clk-smd-rpm: Fix invalid RPM_SMD_PCNOC_A_CLK entry

[Stephen Boyd]

Quoting Bryan O'Donoghue (2021-08-02 08:36:57)
> MSM8936 and MSM8939 both share the same RPMCC clock tree, I've been testing
> on MSM8939 and I've found that RPM_SMD_PCNOC_A_CLK is currently invalid.
> 
> RPM_SMD_PCNOC_A_CLK should point to msm8916_pcnoc_a_clk not to
> msm8916_pcnoc_clk.
> 
> Fixes: a0384ecfe2aa8 ("clk: qcom: smd-rpm: De-duplicate identical entries")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---

This is superseded by
https://lore.kernel.org/r/20210727092613.23056-1-shawn.guo@linaro.org

>  drivers/clk/qcom/clk-smd-rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 800b2fef1887f..b2c142f3a649e 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -467,7 +467,7 @@ DEFINE_CLK_SMD_RPM(msm8936, sysmmnoc_clk, sysmmnoc_a_clk, QCOM_SMD_RPM_BUS_CLK,
>  
>  static struct clk_smd_rpm *msm8936_clks[] = {
>         [RPM_SMD_PCNOC_CLK]             = &msm8916_pcnoc_clk,
> -       [RPM_SMD_PCNOC_A_CLK]           = &msm8916_pcnoc_clk,
> +       [RPM_SMD_PCNOC_A_CLK]           = &msm8916_pcnoc_a_clk,
>         [RPM_SMD_SNOC_CLK]              = &msm8916_snoc_clk,
>         [RPM_SMD_SNOC_A_CLK]            = &msm8916_snoc_a_clk,
>         [RPM_SMD_BIMC_CLK]              = &msm8916_bimc_clk,
> -- 
> 2.30.1
>