From: Sibi Sankar <sibis@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: bjorn.andersson@linaro.org, swboyd@chromium.org,
ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org,
ohad@wizery.com, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, rishabhb@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v3 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings
Date: Mon, 19 Jul 2021 22:00:23 +0530 [thread overview]
Message-ID: <1c29a746a450e75345a8d1e433fa51ee@codeaurora.org> (raw)
In-Reply-To: <20210714193457.GA3135088@robh.at.kernel.org>
On 2021-07-15 01:04, Rob Herring wrote:
> On Fri, Jun 25, 2021 at 12:21:56AM +0530, Sibi Sankar wrote:
>> Add Qualcomm Mailbox Protocol (QMP) binding to replace the power
>> domains
>> exposed by the AOSS QMP node.
>
> Not a compatible change. Explain why that's okay for all
> platforms/users.
It's not meant for all platforms.
Rather we just replace the load-state
power-domain with the new qmp
property and it only affects the
compatibles covered below.
>
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>
>> v3:
>> * Misc. documentation fixes:
>> - Reduce power-domain maxItems due to load_state pd removal
>> - Combine compatibles where possible with the load_state pd removal
>> - Fixup the qcom,qmp ref to phandle type
>>
>> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 62
>> +++++++++++-----------
>> 1 file changed, 30 insertions(+), 32 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index 9ea05e608bc1..ad85617b43fa 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -75,11 +75,11 @@ properties:
>>
>> power-domains:
>> minItems: 1
>> - maxItems: 3
>> + maxItems: 2
>>
>> power-domain-names:
>> minItems: 1
>> - maxItems: 3
>> + maxItems: 2
>>
>> firmware-name:
>> $ref: /schemas/types.yaml#/definitions/string
>> @@ -89,6 +89,10 @@ properties:
>> maxItems: 1
>> description: Reference to the reserved-memory for the Hexagon
>> core
>>
>> + qcom,qmp:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: Reference to the AOSS side-channel message RAM.
>> +
>> qcom,smem-states:
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> description: States used by the AP to signal the Hexagon core
>> @@ -359,13 +363,11 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - description: MX power domain
>> - description: MSS power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: cx
>> - const: mx
>> - const: mss
>> @@ -381,43 +383,20 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - power-domain-names:
>> - items:
>> - - const: load_state
>> - - const: cx
>>
>> - if:
>> properties:
>> compatible:
>> contains:
>> enum:
>> + - qcom,sdx55-mpss-pas
>> - qcom,sm8150-mpss-pas
>> - qcom,sm8350-mpss-pas
>> then:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - - description: CX power domain
>> - - description: MSS power domain
>> - power-domain-names:
>> - items:
>> - - const: load_state
>> - - const: cx
>> - - const: mss
>> -
>> - - if:
>> - properties:
>> - compatible:
>> - contains:
>> - enum:
>> - - qcom,sdx55-mpss-pas
>> - then:
>> - properties:
>> - power-domains:
>> - items:
>> - description: CX power domain
>> - description: MSS power domain
>> power-domain-names:
>> @@ -439,12 +418,10 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: LCX power domain
>> - description: LMX power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: lcx
>> - const: lmx
>>
>> @@ -458,12 +435,10 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - description: MXC power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: cx
>> - const: mxc
>>
>> @@ -499,6 +474,29 @@ allOf:
>> - const: mss_restart
>> - const: pdc_reset
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7180-mpss-pas
>> + - qcom,sm8150-adsp-pas
>> + - qcom,sm8150-cdsp-pas
>> + - qcom,sm8150-mpss-pas
>> + - qcom,sm8150-slpi-pas
>> + - qcom,sm8250-adsp-pas
>> + - qcom,sm8250-cdsp-pas
>> + - qcom,sm8250-slpi-pas
>> + - qcom,sm8350-adsp-pas
>> + - qcom,sm8350-cdsp-pas
>> + - qcom,sm8350-mpss-pas
>> + - qcom,sm8350-slpi-pas
>> + then:
>> + properties:
>> + qcom,qmp:
>> + items:
>> + - description: Reference to the AOSS side-channel message
>> RAM.
>> +
>> examples:
>> - |
>> #include <dt-bindings/clock/qcom,rpmcc.h>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-07-19 16:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 18:51 [PATCH v3 00/13] Use qmp_send to update co-processor load state Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 01/13] dt-bindings: soc: qcom: aoss: Drop power-domain bindings Sibi Sankar
2021-06-25 21:31 ` Matthias Kaehlcke
2021-06-24 18:51 ` [PATCH v3 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings Sibi Sankar
2021-06-25 21:19 ` Matthias Kaehlcke
2021-06-30 19:51 ` Sibi Sankar
2021-07-14 19:34 ` Rob Herring
2021-07-19 16:30 ` Sibi Sankar [this message]
2021-07-19 19:44 ` Bjorn Andersson
2021-06-24 18:51 ` [PATCH v3 03/13] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 04/13] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-06-25 21:11 ` Matthias Kaehlcke
2021-06-30 19:31 ` Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 05/13] arm64: dts: qcom: sc7180: Use QMP binding to control " Sibi Sankar
2021-06-25 21:35 ` Matthias Kaehlcke
2021-06-30 19:52 ` Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 06/13] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 07/13] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 08/13] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 09/13] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 10/13] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-06-25 22:01 ` Matthias Kaehlcke
2021-06-30 19:56 ` Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 12/13] dt-bindings: msm/dp: Remove aoss-qmp header Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 13/13] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
2021-06-25 22:16 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c29a746a450e75345a8d1e433fa51ee@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).