From: Sibi Sankar <sibis@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
swboyd@chromium.org, ulf.hansson@linaro.org, rjw@rjwysocki.net,
agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, rishabhb@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support
Date: Thu, 01 Jul 2021 01:26:25 +0530 [thread overview]
Message-ID: <97e360aff212cc75021279f727a70454@codeaurora.org> (raw)
In-Reply-To: <YNZSN2wXomiZHsz4@google.com>
On 2021-06-26 03:31, Matthias Kaehlcke wrote:
> On Fri, Jun 25, 2021 at 12:22:05AM +0530, Sibi Sankar wrote:
>> The load state resources are expected to follow the life cycle of the
>> remote processor it tracks. However, modeling load state resources as
>> power-domains result in them getting turned off during system suspend
>> and thereby falling out of sync with the remote processors that are
>> still
>> on. Fix this by replacing load state resource control through the
>> generic
>> qmp message send interface instead.
>
> nit: the above sounds as if this patch does all of that, when it only
> removes power domain support. Instead you could start with saying what
> the patch actually does (remove power domain support), followed by why
> PD support isn't needed anymore (now done by sending QMP messages
> directly).
>
sure, will fix this up in the next
re-spin.
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/soc/qcom/qcom_aoss.c | 109
>> ++-----------------------------------------
>> 1 file changed, 3 insertions(+), 106 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/qcom_aoss.c
>> b/drivers/soc/qcom/qcom_aoss.c
>> index 998ee7605eb2..f0c3726e8c46 100644
>> --- a/drivers/soc/qcom/qcom_aoss.c
>> +++ b/drivers/soc/qcom/qcom_aoss.c
>>
>> ...
>>
>> @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device
>> *pdev)
>> if (ret)
>> goto err_close_qmp;
>>
>> - ret = qmp_pd_add(qmp);
>> - if (ret)
>> - goto err_remove_qdss_clk;
>> -
>> ret = qmp_cooling_devices_register(qmp);
>> - if (ret)
>> + if (ret) {
>> dev_err(&pdev->dev, "failed to register aoss cooling devices\n");
>> + goto err_remove_qdss_clk;
>
> This isn't really related with the PD removal, right? I wonder if it
> was
> intentional to have _probe() succeed even when the cooling device
> registration failed, since the cooling devices aren't essential.
>
Thanks for catching ^^
> If it is still desirable to fail the change should be done in a
> separate
> patch, unless it is actually related with removing PD support.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-06-30 19:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 18:51 [PATCH v3 00/13] Use qmp_send to update co-processor load state Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 01/13] dt-bindings: soc: qcom: aoss: Drop power-domain bindings Sibi Sankar
2021-06-25 21:31 ` Matthias Kaehlcke
2021-06-24 18:51 ` [PATCH v3 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings Sibi Sankar
2021-06-25 21:19 ` Matthias Kaehlcke
2021-06-30 19:51 ` Sibi Sankar
2021-07-14 19:34 ` Rob Herring
2021-07-19 16:30 ` Sibi Sankar
2021-07-19 19:44 ` Bjorn Andersson
2021-06-24 18:51 ` [PATCH v3 03/13] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 04/13] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-06-25 21:11 ` Matthias Kaehlcke
2021-06-30 19:31 ` Sibi Sankar
2021-06-24 18:51 ` [PATCH v3 05/13] arm64: dts: qcom: sc7180: Use QMP binding to control " Sibi Sankar
2021-06-25 21:35 ` Matthias Kaehlcke
2021-06-30 19:52 ` Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 06/13] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 07/13] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 08/13] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 09/13] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 10/13] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 11/13] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-06-25 22:01 ` Matthias Kaehlcke
2021-06-30 19:56 ` Sibi Sankar [this message]
2021-06-24 18:52 ` [PATCH v3 12/13] dt-bindings: msm/dp: Remove aoss-qmp header Sibi Sankar
2021-06-24 18:52 ` [PATCH v3 13/13] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
2021-06-25 22:16 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e360aff212cc75021279f727a70454@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).