From: Rob Herring <robh@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v4 4/5] soc: qcom: Add device tree binding for GLINK RPM
Date: Mon, 8 May 2017 12:06:06 -0500 [thread overview]
Message-ID: <20170508170606.uchxrihfodk6yts5@rob-hp-laptop> (raw)
In-Reply-To: <20170504200539.27027-4-bjorn.andersson@linaro.org>
On Thu, May 04, 2017 at 01:05:38PM -0700, Bjorn Andersson wrote:
> Add device tree binding documentation for the Qualcomm GLINK RPM, used
> for communication with the Resource Power Management subsystem in
> various Qualcomm SoCs.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v3:
> - Transition doorbell to mailbox framework
>
> Changes since v2:
> - Replace qcom,ipc syscon with a "doorbell"
>
> Changes since v1:
> - None
>
> .../devicetree/bindings/soc/qcom/qcom,glink.txt | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
> new file mode 100644
> index 000000000000..e32198df0e9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
> @@ -0,0 +1,73 @@
> +Qualcomm RPM GLINK binding
> +
> +This binding describes the Qualcomm RPM GLINK, a fifo based mechanism for
> +communication with the Resource Power Management system on various Qualcomm
> +platforms.
> +
> +- compatible:
> + Usage: required
> + Value type: <stringlist>
> + Definition: must be "qcom,glink-rpm"
> +
> +- interrupts:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: should specify the IRQ used by the remote processor to
> + signal this processor about communication related events
> +
> +- qcom,rpm-msg-ram:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: handle to RPM message memory resource
> +
> +- mboxes:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: reference to the "rpm_hlos" mailbox in APCS, as described
> + in mailbox/mailbox.txt
> +
> += GLINK DEVICES
> +Each subnode of the GLINK node represent function tied to a virtual
> +communication channel. The name of the nodes are not important. The properties
> +of these nodes are defined by the individual bindings for the specific function
> +- but must contain the following property:
> +
> +- qcom,glink-channels:
> + Usage: required
> + Value type: <stringlist>
> + Definition: a list of channels tied to this function, used for matching
> + the function to a set of virtual channels
> +
> += EXAMPLE
> +The following example represents the GLINK RPM node on a MSM8996 device, with
> +the function for the "rpm_request" channel defined, which is used for
> +regualtors and root clocks.
> +
> + apcs_glb: apcs-glb@9820000 {
mailbox@... Or does this block do other things?
Otherwise,
Acked-by: Rob Herring <robh@kernel.org>
> + compatible = "qcom,msm8996-apcs-hmss-global";
> + reg = <0x9820000 0x1000>;
> +
> + #mbox-cells = <1>;
> + };
> +
> + rpm_msg_ram: memory@68000 {
> + compatible = "qcom,rpm-msg-ram";
> + reg = <0x68000 0x6000>;
> + };
> +
> + rpm-glink {
> + compatible = "qcom,glink-rpm";
> +
> + interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> +
> + qcom,rpm-msg-ram = <&rpm_msg_ram>;
> +
> + mboxes = <&apcs_glb 0>;
> +
> + rpm-requests {
> + compatible = "qcom,rpm-msm8996";
> + qcom,glink-channels = "rpm_requests";
> +
> + ...
> + };
> + };
> --
> 2.12.0
>
next prev parent reply other threads:[~2017-05-08 17:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 20:05 [PATCH v4 1/5] mailbox: Make startup and shutdown ops optional Bjorn Andersson
2017-05-04 20:05 ` [PATCH v4 2/5] dt-bindings: mailbox: Introduce Qualcomm APCS global binding Bjorn Andersson
2017-05-04 20:05 ` [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver Bjorn Andersson
2017-05-05 10:26 ` Jassi Brar
2017-05-05 18:37 ` Bjorn Andersson
2017-05-05 19:22 ` Jassi Brar
[not found] ` <CABb+yY03imq8911rF9dHJjG_a_aosksA=tgk7Rog5AZSezHDyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-05 19:53 ` Jeffrey Hugo
2017-05-05 20:22 ` Jassi Brar
2017-05-05 20:39 ` Jeffrey Hugo
[not found] ` <CABb+yY1K3Hyn7CzQCA6tHu-KrPigARc3cYgBdT8PNX7vjhPK0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-06 1:19 ` Bjorn Andersson
2017-05-06 4:48 ` Jassi Brar
2017-05-08 5:54 ` Bjorn Andersson
2017-05-08 6:47 ` Jassi Brar
2017-05-08 19:11 ` Bjorn Andersson
2017-05-09 16:41 ` Jassi Brar
[not found] ` <CABb+yY2uC6vNFTq1KtZwrrw8x4BEfc2cMjF5DwrLbGpYWBNBzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-09 19:11 ` Bjorn Andersson
2017-05-10 2:33 ` Jassi Brar
2017-05-10 19:00 ` Bjorn Andersson
2017-05-11 2:07 ` Jassi Brar
2017-05-12 22:48 ` Bjorn Andersson
2017-05-16 11:25 ` Jassi Brar
2017-05-04 20:05 ` [PATCH v4 4/5] soc: qcom: Add device tree binding for GLINK RPM Bjorn Andersson
2017-05-08 17:06 ` Rob Herring [this message]
2017-05-08 17:53 ` Bjorn Andersson
2017-05-04 20:05 ` [PATCH v4 5/5] rpmsg: Introduce Qualcomm RPM glink driver Bjorn Andersson
[not found] ` <20170504200539.27027-1-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-05 9:35 ` [PATCH v4 1/5] mailbox: Make startup and shutdown ops optional Sudeep Holla
2017-05-05 10:33 ` Jassi Brar
2017-05-05 18:21 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508170606.uchxrihfodk6yts5@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).