From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Manu Gautam <mgautam@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
MSM <linux-arm-msm@vger.kernel.org>,
PCI <linux-pci@vger.kernel.org>,
iommu <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v1 3/3] arm64: dts: qcom: msm8998: Add PCIe PHY and RC nodes
Date: Thu, 11 Apr 2019 12:09:37 +0300 [thread overview]
Message-ID: <8ada0472-0692-2f03-b52f-c1702bb0c33d@mm-sol.com> (raw)
Message-ID: <20190411090937.DH9c1B_ktUY80EPZWMObEkw_qx6zFYQFgU2BdGp2EOc@z> (raw)
In-Reply-To: <8ee2ca1b-2a0d-0c98-f770-a47b5b529295@free.fr>
Hi Marc,
On 4/11/19 11:44 AM, Marc Gonzalez wrote:
> On 10/04/2019 17:32, Stanimir Varbanov wrote:
>
>> Few comments inline.
>
> I'll send v3.
>
> Changes:
> - Move all X-names props *after* corresponding X(s) prop
> - Drop comments
>
>
>>> + iommu-map = <0x100 &anoc1_smmu 0x1480 1>;
>>
>> iommu-map-mask? It is optional but I had to ask :)
>
> The only RID in the system is 0x100.
>
> # lspci
> 00:00.0 PCI bridge: Qualcomm Device 0105
> 01:00.0 Ethernet controller: Qualcomm Atheros AR8151 v2.0 Gigabit Ethernet (rev c0)
>
> Since we just want to map 0x100, we don't need an iommu-map-mask.
Do you see warnings during boot about missing property?
>
>
>>> + /* PCIe Fundamental Reset */
>>
>> this comment is useless :) please drop it
>
> IMO, "perst" is a poor name. Can you guess what it stands for?
The name is got from PCIE base specification. See 6.6.1.
Conventional Reset from "PCI EXPRESS BASE SPECIFICATION, REV. 3.0"
--
regards,
Stan
next prev parent reply other threads:[~2019-04-11 9:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 16:59 [PATCH v1 0/3] PCIe and AR8151 on APQ8098/MSM8998 Marc Gonzalez
[not found] ` <5eedbe6d-f440-1a77-8a7e-81a920e3a0e7-GANU6spQydw@public.gmane.org>
2019-03-28 17:01 ` [PATCH v1 1/3] PCI: qcom: Setup PCIE20_PARF_BDF_TRANSLATE_N Marc Gonzalez
[not found] ` <958ae127-3aa2-6824-c875-e3012644ed3d-GANU6spQydw@public.gmane.org>
2019-04-02 8:08 ` Stanimir Varbanov via iommu
[not found] ` <58b4db00-a0fa-5058-99ee-c11c8e2fa529-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2019-04-02 10:44 ` Marc Gonzalez
2019-03-28 17:05 ` [PATCH v1 2/3] arm64: dts: qcom: msm8998: Add PCIe SMMU node Marc Gonzalez
[not found] ` <82ab78ee-4a38-4eee-f064-272b6f964f17-GANU6spQydw@public.gmane.org>
2019-03-29 10:51 ` Marc Gonzalez
[not found] ` <e7c8137a-2408-a71a-f722-199a86a75d13-GANU6spQydw@public.gmane.org>
2019-03-29 18:29 ` Robin Murphy
[not found] ` <5aa56120-b686-194b-36d6-8177b5749a19-5wv7dgnIgG8@public.gmane.org>
2019-03-29 19:42 ` Jeffrey Hugo
2019-03-30 14:18 ` Vivek Gautam
[not found] ` <CAFp+6iHOwW5jJmdVWo-E7154xk2jpR4ZLRoXEJdPwu8_ZJg14Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-02 13:54 ` Robin Murphy
[not found] ` <e6d2200d-f6b9-3c27-f166-537742b32bfe-5wv7dgnIgG8@public.gmane.org>
2019-04-03 9:26 ` Vivek Gautam
2019-03-28 17:06 ` [PATCH v1 3/3] arm64: dts: qcom: msm8998: Add PCIe PHY and RC nodes Marc Gonzalez
[not found] ` <186f7ca2-84e2-a37e-79e6-f1fec8e25374-GANU6spQydw@public.gmane.org>
2019-04-04 10:01 ` Marc Gonzalez
2019-04-10 15:32 ` Stanimir Varbanov via iommu
2019-04-10 15:32 ` Stanimir Varbanov
[not found] ` <3f32cfb9-6528-9f5e-85db-cee89fdcfc5d-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2019-04-11 8:44 ` Marc Gonzalez
2019-04-11 8:44 ` Marc Gonzalez
[not found] ` <8ee2ca1b-2a0d-0c98-f770-a47b5b529295-GANU6spQydw@public.gmane.org>
2019-04-11 9:09 ` Stanimir Varbanov via iommu [this message]
2019-04-11 9:09 ` Stanimir Varbanov
[not found] ` <8ada0472-0692-2f03-b52f-c1702bb0c33d-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2019-04-11 9:38 ` Marc Gonzalez
2019-04-11 9:38 ` Marc Gonzalez
2019-06-11 15:55 ` [PATCH v1 0/3] PCIe and AR8151 on APQ8098/MSM8998 Lorenzo Pieralisi
2019-06-11 16:30 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ada0472-0692-2f03-b52f-c1702bb0c33d@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jhugo@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.w.gonzalez@free.fr \
--cc=mgautam@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).