From: Saiyam Doshi <saiyamdoshi.in@gmail.com>
To: agross@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure
Date: Tue, 17 Sep 2019 00:28:58 +0530 [thread overview]
Message-ID: <20190916185857.GA14093@SD> (raw)
The debug message after platform_get_irq() failure is redundant
because platform_get_irq() already prints an error. Thus remove it.
The semantic patch that makes this report is available
in scripts/coccinelle/api/platform_get_irq.cocci.
Found using - http://coccinelle.lip6.fr/
Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
---
drivers/i2c/busses/i2c-qup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 5519c19bfd9c..23c4893512b2 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -1767,7 +1767,6 @@ static int qup_i2c_probe(struct platform_device *pdev)
qup->irq = platform_get_irq(pdev, 0);
if (qup->irq < 0) {
- dev_err(qup->dev, "No IRQ defined\n");
return qup->irq;
}
--
2.20.1
next reply other threads:[~2019-09-16 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 18:58 Saiyam Doshi [this message]
2019-09-17 15:28 ` [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure Markus Elfring
2019-09-17 16:25 ` Saiyam Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916185857.GA14093@SD \
--to=saiyamdoshi.in@gmail.com \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).