From: Markus Elfring <Markus.Elfring@web.de>
To: Saiyam Doshi <saiyamdoshi.in@gmail.com>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure
Date: Tue, 17 Sep 2019 17:28:47 +0200 [thread overview]
Message-ID: <f25a406d-9032-5db9-7136-6ff99c02f888@web.de> (raw)
In-Reply-To: <20190916185857.GA14093@SD>
> The semantic patch that makes this report is available
> in scripts/coccinelle/api/platform_get_irq.cocci.
>
> Found using - http://coccinelle.lip6.fr/
Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
be more helpful than the other description variant?
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -1767,7 +1767,6 @@ static int qup_i2c_probe(struct platform_device *pdev)
>
> qup->irq = platform_get_irq(pdev, 0);
> if (qup->irq < 0) {
> - dev_err(qup->dev, "No IRQ defined\n");
> return qup->irq;
> }
How do you think about to omit the curly brackets here after only a single
statement would be used in the if branch?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=ad062195731bea1624ce7160e79e0fcdaa25c1b5#n175
Regards,
Markus
next prev parent reply other threads:[~2019-09-17 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 18:58 [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get_irq*() failure Saiyam Doshi
2019-09-17 15:28 ` Markus Elfring [this message]
2019-09-17 16:25 ` Saiyam Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25a406d-9032-5db9-7136-6ff99c02f888@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saiyamdoshi.in@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).