* [PATCH] spi: spidev: fix missing octal defines
@ 2020-06-19 7:43 Vinod Koul
2020-06-19 10:23 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-06-19 7:43 UTC (permalink / raw)
To: Mark Brown
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Geert Uytterhoeven,
linux-spi, linux-kernel, mani
Commit 896fa735084e ("spi: spidev_test: Add support for Octal mode data
transfers") adds support for octal mode but failed to update userspace
header with octal defines causing build error for the spidev tool
spidev_test.c: In function ‘transfer’:
spidev_test.c:131:13: error: ‘SPI_TX_OCTAL’ undeclared (first use in this function); did you mean ‘SPI_TX_DUAL’?
if (mode & SPI_TX_OCTAL)
...
Update the header with octal values.
Fixes: 896fa735084e ("spi: spidev_test: Add support for Octal mode data transfers")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
include/uapi/linux/spi/spidev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/spi/spidev.h b/include/uapi/linux/spi/spidev.h
index ee0f2460bff6..f0c95f5cc719 100644
--- a/include/uapi/linux/spi/spidev.h
+++ b/include/uapi/linux/spi/spidev.h
@@ -48,6 +48,8 @@
#define SPI_TX_QUAD 0x200
#define SPI_RX_DUAL 0x400
#define SPI_RX_QUAD 0x800
+#define SPI_TX_OCTAL 0x2000
+#define SPI_RX_OCTAL 0x4000
/*---------------------------------------------------------------------------*/
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: spidev: fix missing octal defines
2020-06-19 7:43 [PATCH] spi: spidev: fix missing octal defines Vinod Koul
@ 2020-06-19 10:23 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-06-19 10:23 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Geert Uytterhoeven, linux-spi,
linux-kernel, mani
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Fri, Jun 19, 2020 at 01:13:45PM +0530, Vinod Koul wrote:
> Commit 896fa735084e ("spi: spidev_test: Add support for Octal mode data
> transfers") adds support for octal mode but failed to update userspace
> header with octal defines causing build error for the spidev tool
This was already fixed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-19 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 7:43 [PATCH] spi: spidev: fix missing octal defines Vinod Koul
2020-06-19 10:23 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).