From: Marijn Suijten <marijn.suijten@somainline.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral
Date: Sat, 5 Nov 2022 00:44:35 +0100 [thread overview]
Message-ID: <20221104234435.xwjpwfxs73puvfca@SoMainline.org> (raw)
In-Reply-To: <20221101161801.1058969-2-luca@z3ntu.xyz>
On 2022-11-01 17:18:00, Luca Weiss wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> The PMI8950 features integrated peripherals like ADC, GPIO controller,
> MPPs and others.
>
> [luca@z3ntu.xyz: remove pm8950, style changes for 2022 standards, add wled]
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes since v2:
> * Pick up patch, and adjust as mentioned above sign-offs
>
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 97 +++++++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pmi8950.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> new file mode 100644
> index 000000000000..32d27e2187e3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2019, AngeloGioacchino Del Regno <kholk11@gmail.com>
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pmic@2 {
> + compatible = "qcom,pmi8950", "qcom,spmi-pmic";
> + reg = <0x2 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmi8950_vadc: adc@3100 {
> + compatible = "qcom,spmi-vadc";
> + reg = <0x3100>;
> + interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> +
> + adc-chan@0 {
> + reg = <VADC_USBIN>;
> + qcom,pre-scaling = <1 4>;
> + label = "usbin";
I've previously sent a patch with labels in the node name instead [1],
what's the preferred way nowadays?
[1]: https://lore.kernel.org/linux-arm-msm/20220926190148.283805-4-marijn.suijten@somainline.org/
> + };
> +
> + adc-chan@1 {
> + reg = <VADC_DCIN>;
> + qcom,pre-scaling = <1 4>;
> + label = "dcin";
> + };
> +
> + adc-chan@2 {
> + reg = <VADC_VCHG_SNS>;
> + qcom,pre-scaling = <1 1>;
> + label = "vchg_sns";
Shall we use hyphens in labels (especially if using them as node names).
> + };
> +
> + adc-chan@9 {
> + reg = <VADC_REF_625MV>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_625mv";
> + };
> +
> + adc-chan@a {
> + reg = <VADC_REF_1250MV>;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_1250v";
mv* :)
> + };
> +
> + adc-chan@d {
> + reg = <VADC_SPARE2>;
> + qcom,pre-scaling = <1 1>;
> + label = "chg_temp";
> + };
> + };
> +
> + pmi8950_mpps: mpps@a000 {
> + compatible = "qcom,pmi8950-mpp", "qcom,spmi-mpp";
> + reg = <0xa000>;
> + gpio-controller;
> + gpio-ranges = <&pmi8950_mpps 0 0 4>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
> + pmi8950_gpio: gpio@c000 {
It seems more common to name this label plural pmi8950_gpioS?
> + compatible = "qcom,pmi8950-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + gpio-ranges = <&pmi8950_gpio 0 0 2>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> + pmic@3 {
> + compatible = "qcom,pmi8950", "qcom,spmi-pmic";
> + reg = <0x3 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmi8950_wled: leds@d800 {
> + compatible = "qcom,pmi8950-wled";
> + reg = <0xd800>, <0xd900>;
> + interrupts = <0x3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "short";
> + label = "backlight";
Same question here about using the node name instead, and dropping the
label altogether.
- Marijn
> +
> + status = "disabled";
> + };
> + };
> +};
> --
> 2.38.1
>
next prev parent reply other threads:[~2022-11-04 23:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:17 [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Luca Weiss
2022-11-01 16:18 ` [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral Luca Weiss
2022-11-04 23:44 ` Marijn Suijten [this message]
2022-11-06 19:37 ` Marijn Suijten
2022-12-02 9:36 ` Marijn Suijten
2022-12-04 16:19 ` Luca Weiss
2022-12-08 10:12 ` Marijn Suijten
2022-12-08 10:23 ` Krzysztof Kozlowski
2022-12-08 11:20 ` Marijn Suijten
2022-12-09 16:54 ` Luca Weiss
2022-12-09 20:38 ` Marijn Suijten
2022-12-10 10:58 ` Krzysztof Kozlowski
2022-12-10 16:31 ` Marijn Suijten
2022-12-11 20:11 ` Krzysztof Kozlowski
2022-12-14 20:39 ` Marijn Suijten
2022-11-02 13:55 ` [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Daniel Thompson
2022-11-02 17:29 ` Rob Herring
2022-11-07 9:19 ` Lee Jones
2022-12-06 18:19 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104234435.xwjpwfxs73puvfca@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kholk11@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).