From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral
Date: Thu, 8 Dec 2022 12:20:55 +0100 [thread overview]
Message-ID: <20221208112055.m7sqg3ysxzskqjp4@SoMainline.org> (raw)
In-Reply-To: <36eb03e8-aace-f7ce-edc8-53715021c0ea@linaro.org>
On 2022-12-08 11:23:17, Krzysztof Kozlowski wrote:
> On 08/12/2022 11:12, Marijn Suijten wrote:
> > On 2022-12-04 17:19:05, Luca Weiss wrote:
> >> On Freitag, 2. Dezember 2022 10:36:58 CET Marijn Suijten wrote:
> >> [..]
> >>
> >> So the way this patch does it is good or does it need changes?
> >
> > Except the typo(s?) pointed out in my first reply, this is good to go.
> >
> > If we stick with generic adc-chan node names that should be documented
> > in the bindings IMO, as it is currently only captured implicitly in the
> > examples. Krzysztof, what is your thought on this?
>
> If I understand correctly, the outcome of other discussion [1] was to
> use labels and generic node names.
The outcome was to use labels in the driver and disregard node names as
the new fwnode API clobbers those names by including the @xx register
bit.
(I'll follow up with Jonathan whether or not to remove the current
fallback to node names, as [1] ended up discussing many different issues
and nits)
> In such case the patch was correct
> (except other comments).
As a consequence it _doesn't matter_ how nodes are named, and we _can_
use generic node names. My question for you is whether we should, and
if we should lock that in via dt-bindings to guide everyone towards
using labels (which i did _not_ do in the recently-landed PM8950 and
PM6125, but will send followup for).
> [1]
> https://lore.kernel.org/linux-arm-msm/20221112162719.0ac87998@jic23-huawei/
- Marijn
next prev parent reply other threads:[~2022-12-08 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:17 [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Luca Weiss
2022-11-01 16:18 ` [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral Luca Weiss
2022-11-04 23:44 ` Marijn Suijten
2022-11-06 19:37 ` Marijn Suijten
2022-12-02 9:36 ` Marijn Suijten
2022-12-04 16:19 ` Luca Weiss
2022-12-08 10:12 ` Marijn Suijten
2022-12-08 10:23 ` Krzysztof Kozlowski
2022-12-08 11:20 ` Marijn Suijten [this message]
2022-12-09 16:54 ` Luca Weiss
2022-12-09 20:38 ` Marijn Suijten
2022-12-10 10:58 ` Krzysztof Kozlowski
2022-12-10 16:31 ` Marijn Suijten
2022-12-11 20:11 ` Krzysztof Kozlowski
2022-12-14 20:39 ` Marijn Suijten
2022-11-02 13:55 ` [PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible Daniel Thompson
2022-11-02 17:29 ` Rob Herring
2022-11-07 9:19 ` Lee Jones
2022-12-06 18:19 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208112055.m7sqg3ysxzskqjp4@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kholk11@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).