* [PATCH] interconnect: qcom: use icc_sync state for sm8[12]50
@ 2020-10-27 10:27 Dmitry Baryshkov
2020-10-27 11:24 ` Georgi Djakov
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2020-10-27 10:27 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Georgi Djakov, Jonathan Marek
Cc: linux-arm-msm, linux-pm
In addition to the rest of Qcom interconnect drivers use icc_sync_state
for SM8150/SM8250 interconnect drivers to notify the interconnect
framework when all consumers are probed and there is no need to keep the
bandwidth set to maximum anymore.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sm8150.c | 1 +
drivers/interconnect/qcom/sm8250.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c
index 9218efed04a0..30fb6567fe19 100644
--- a/drivers/interconnect/qcom/sm8150.c
+++ b/drivers/interconnect/qcom/sm8150.c
@@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = {
.driver = {
.name = "qnoc-sm8150",
.of_match_table = qnoc_of_match,
+ .sync_state = icc_sync_state,
},
};
module_platform_driver(qnoc_driver);
diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c
index 9b58946f7898..49c5ee2e70f0 100644
--- a/drivers/interconnect/qcom/sm8250.c
+++ b/drivers/interconnect/qcom/sm8250.c
@@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = {
.driver = {
.name = "qnoc-sm8250",
.of_match_table = qnoc_of_match,
+ .sync_state = icc_sync_state,
},
};
module_platform_driver(qnoc_driver);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] interconnect: qcom: use icc_sync state for sm8[12]50
2020-10-27 10:27 [PATCH] interconnect: qcom: use icc_sync state for sm8[12]50 Dmitry Baryshkov
@ 2020-10-27 11:24 ` Georgi Djakov
2020-10-27 11:44 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Georgi Djakov @ 2020-10-27 11:24 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Jonathan Marek
Cc: Andy Gross, linux-arm-msm, linux-pm
Hi Dmitry,
Thanks for the patch!
On 10/27/20 12:27, Dmitry Baryshkov wrote:
> In addition to the rest of Qcom interconnect drivers use icc_sync_state
> for SM8150/SM8250 interconnect drivers to notify the interconnect
> framework when all consumers are probed and there is no need to keep the
> bandwidth set to maximum anymore.
Should we add Fixes: tag?
Thanks,
Georgi
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/interconnect/qcom/sm8150.c | 1 +
> drivers/interconnect/qcom/sm8250.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c
> index 9218efed04a0..30fb6567fe19 100644
> --- a/drivers/interconnect/qcom/sm8150.c
> +++ b/drivers/interconnect/qcom/sm8150.c
> @@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = {
> .driver = {
> .name = "qnoc-sm8150",
> .of_match_table = qnoc_of_match,
> + .sync_state = icc_sync_state,
> },
> };
> module_platform_driver(qnoc_driver);
> diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c
> index 9b58946f7898..49c5ee2e70f0 100644
> --- a/drivers/interconnect/qcom/sm8250.c
> +++ b/drivers/interconnect/qcom/sm8250.c
> @@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = {
> .driver = {
> .name = "qnoc-sm8250",
> .of_match_table = qnoc_of_match,
> + .sync_state = icc_sync_state,
> },
> };
> module_platform_driver(qnoc_driver);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] interconnect: qcom: use icc_sync state for sm8[12]50
2020-10-27 11:24 ` Georgi Djakov
@ 2020-10-27 11:44 ` Dmitry Baryshkov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2020-10-27 11:44 UTC (permalink / raw)
To: Georgi Djakov, Bjorn Andersson, Jonathan Marek
Cc: Andy Gross, linux-arm-msm, linux-pm
On 27/10/2020 14:24, Georgi Djakov wrote:
> Hi Dmitry,
>
> Thanks for the patch!
>
> On 10/27/20 12:27, Dmitry Baryshkov wrote:
>> In addition to the rest of Qcom interconnect drivers use icc_sync_state
>> for SM8150/SM8250 interconnect drivers to notify the interconnect
>> framework when all consumers are probed and there is no need to keep the
>> bandwidth set to maximum anymore.
>
> Should we add Fixes: tag?
Good question. I'd point Fixes: to sync_state commit. I'd add that to
v2, also moving bcm registration.
>
> Thanks,
> Georgi
>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> drivers/interconnect/qcom/sm8150.c | 1 +
>> drivers/interconnect/qcom/sm8250.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c
>> index 9218efed04a0..30fb6567fe19 100644
>> --- a/drivers/interconnect/qcom/sm8150.c
>> +++ b/drivers/interconnect/qcom/sm8150.c
>> @@ -627,6 +627,7 @@ static struct platform_driver qnoc_driver = {
>> .driver = {
>> .name = "qnoc-sm8150",
>> .of_match_table = qnoc_of_match,
>> + .sync_state = icc_sync_state,
>> },
>> };
>> module_platform_driver(qnoc_driver);
>> diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c
>> index 9b58946f7898..49c5ee2e70f0 100644
>> --- a/drivers/interconnect/qcom/sm8250.c
>> +++ b/drivers/interconnect/qcom/sm8250.c
>> @@ -643,6 +643,7 @@ static struct platform_driver qnoc_driver = {
>> .driver = {
>> .name = "qnoc-sm8250",
>> .of_match_table = qnoc_of_match,
>> + .sync_state = icc_sync_state,
>> },
>> };
>> module_platform_driver(qnoc_driver);
>>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 10:27 [PATCH] interconnect: qcom: use icc_sync state for sm8[12]50 Dmitry Baryshkov
2020-10-27 11:24 ` Georgi Djakov
2020-10-27 11:44 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).