From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, agross@kernel.org,
niklas.cassel@linaro.org, marc.w.gonzalez@free.fr,
sibis@codeaurora.org, daniel.lezcano@linaro.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Li Yang <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Subject: [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property
Date: Tue, 21 May 2019 15:05:12 +0530 [thread overview]
Message-ID: <9dc4ce06143de48039e841c337fafa7cb9c8d7d2.1558430617.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1558430617.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1558430617.git.amit.kucheria@linaro.org>
The "enable-method" property for cpu nodes needs to be "psci" for CPU
idle management to be setup correctly.
Add a note to the binding documentation to this effect to make it
obvious.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
---
.../devicetree/bindings/arm/idle-states.txt | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/idle-states.txt b/Documentation/devicetree/bindings/arm/idle-states.txt
index 45730ba60af5..3bdbe675b9e6 100644
--- a/Documentation/devicetree/bindings/arm/idle-states.txt
+++ b/Documentation/devicetree/bindings/arm/idle-states.txt
@@ -241,9 +241,13 @@ processor idle states, defined as device tree nodes, are listed.
- "psci"
# On ARM 32-bit systems this property is optional
-The nodes describing the idle states (state) can only be defined within the
-idle-states node, any other configuration is considered invalid and therefore
-must be ignored.
+This assumes that the "enable-method" property is set to "psci" in the cpu
+node[6] that is responsible for setting up CPU idle management in the OS
+implementation.
+
+The nodes describing the idle states (state) can only be defined
+within the idle-states node, any other configuration is considered invalid
+and therefore must be ignored.
===========================================
4 - state node
@@ -697,3 +701,6 @@ cpus {
[5] Devicetree Specification
https://www.devicetree.org/specifications/
+
+[6] ARM Linux Kernel documentation - Booting AArch64 Linux
+ Documentation/arm64/booting.txt
--
2.17.1
next prev parent reply other threads:[~2019-05-21 9:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:35 [PATCH v2 0/9] qcom: Add cpuidle to some platforms Amit Kucheria
2019-05-21 9:35 ` [PATCH v2 1/9] arm64: dts: fsl: ls1028a: Fix entry-method property to reflect documentation Amit Kucheria
2019-05-21 9:35 ` Amit Kucheria [this message]
2019-05-21 10:34 ` [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property Marc Gonzalez
2019-06-13 23:13 ` Rob Herring
2019-05-21 9:35 ` [PATCH v2 3/9] arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node Amit Kucheria
2019-05-22 3:30 ` Bjorn Andersson
2019-05-21 9:35 ` [PATCH v2 4/9] arm64: dts: qcom: msm8916: Use more generic idle state names Amit Kucheria
2019-05-22 3:30 ` Bjorn Andersson
2019-05-21 9:35 ` [PATCH v2 5/9] arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states Amit Kucheria
2019-05-22 3:31 ` Bjorn Andersson
2019-05-21 9:35 ` [PATCH v2 6/9] arm64: dts: qcom: msm8996: " Amit Kucheria
2019-05-21 10:13 ` Daniel Lezcano
2019-05-22 3:49 ` Bjorn Andersson
2019-05-23 21:24 ` Niklas Cassel
2019-05-21 9:35 ` [PATCH v2 7/9] arm64: dts: qcom: msm8998: " Amit Kucheria
2019-05-21 12:03 ` Marc Gonzalez
2019-05-21 16:10 ` Marc Gonzalez
2019-05-22 9:17 ` Marc Gonzalez
2019-05-22 9:35 ` Marc Zyngier
2019-05-22 15:39 ` Marc Gonzalez
2019-05-22 14:48 ` Marc Gonzalez
2019-09-30 22:20 ` Jeffrey Hugo
2019-09-30 22:44 ` Amit Kucheria
2019-10-01 14:21 ` Jeffrey Hugo
2019-10-02 9:19 ` Niklas Cassel
2019-10-02 9:27 ` Niklas Cassel
2019-10-02 18:18 ` Jeffrey Hugo
2019-10-04 1:36 ` Amit Kucheria
2019-10-04 3:14 ` Jeffrey Hugo
2019-05-21 9:35 ` [PATCH v2 8/9] arm64: dts: qcom: sdm845: " Amit Kucheria
2019-05-22 3:59 ` Bjorn Andersson
2019-05-21 9:35 ` [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus Amit Kucheria
2019-05-21 10:14 ` Daniel Lezcano
2019-05-22 3:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc4ce06143de48039e841c337fafa7cb9c8d7d2.1558430617.git.amit.kucheria@linaro.org \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=niklas.cassel@linaro.org \
--cc=shawnguo@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).