linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Niklas Cassel <niklas.cassel@linaro.org>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>,
	Sibi Sankar <sibis@codeaurora.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Li Yang <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Date: Tue, 1 Oct 2019 08:21:54 -0600	[thread overview]
Message-ID: <CAOCk7NpA5OmgmH0PZpcrj1KmhdrTKvOb+3eUL6=Mo8HRUnKjdA@mail.gmail.com> (raw)
In-Reply-To: <CAHLCerOS1Hi3XdDZzTKFKnrsATj5cMKtjPEuJknWu-aPtwzP9g@mail.gmail.com>

On Mon, Sep 30, 2019 at 4:44 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
>
> Can you try removing just the *SLEEP_1 states from the cpu-idle-states
> property? I want to understand if this is triggered just by the deeper
> C-state.

Still seeing the issue with just the SLEEP_0 states.  For reference,
Bjorn suggested adding kpti=no to the command line, which also
appeared to have no effect on the issue.

>
> On Tue, Oct 1, 2019 at 3:50 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
> >
> > Amit, the merged version of the below change causes a boot failure
> > (nasty hang, sometimes with RCU stalls) on the msm8998 laptops.  Oddly
> > enough, it seems to be resolved if I remove the cpu-idle-states
> > property from one of the cpu nodes.
> >
> > I see no issues with the msm8998 MTP.
> >
> > Do you have any suggestions on how we might debug this?
> >
> > On Tue, May 21, 2019 at 3:38 AM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> > >
> > > Add device bindings for cpuidle states for cpu devices.
> > >
> > > Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > > ---
> > >  arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++
> > >  1 file changed, 50 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > > index 3fd0769fe648..54810980fcf9 100644
> > > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > > @@ -78,6 +78,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x0>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>;
> > >                         efficiency = <1024>;
> > >                         next-level-cache = <&L2_0>;
> > >                         L2_0: l2-cache {
> > > @@ -97,6 +98,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x1>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>;
> > >                         efficiency = <1024>;
> > >                         next-level-cache = <&L2_0>;
> > >                         L1_I_1: l1-icache {
> > > @@ -112,6 +114,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x2>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>;
> > >                         efficiency = <1024>;
> > >                         next-level-cache = <&L2_0>;
> > >                         L1_I_2: l1-icache {
> > > @@ -127,6 +130,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x3>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>;
> > >                         efficiency = <1024>;
> > >                         next-level-cache = <&L2_0>;
> > >                         L1_I_3: l1-icache {
> > > @@ -142,6 +146,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x100>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>;
> > >                         efficiency = <1536>;
> > >                         next-level-cache = <&L2_1>;
> > >                         L2_1: l2-cache {
> > > @@ -161,6 +166,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x101>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>;
> > >                         efficiency = <1536>;
> > >                         next-level-cache = <&L2_1>;
> > >                         L1_I_101: l1-icache {
> > > @@ -176,6 +182,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x102>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>;
> > >                         efficiency = <1536>;
> > >                         next-level-cache = <&L2_1>;
> > >                         L1_I_102: l1-icache {
> > > @@ -191,6 +198,7 @@
> > >                         compatible = "arm,armv8";
> > >                         reg = <0x0 0x103>;
> > >                         enable-method = "psci";
> > > +                       cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>;
> > >                         efficiency = <1536>;
> > >                         next-level-cache = <&L2_1>;
> > >                         L1_I_103: l1-icache {
> > > @@ -238,6 +246,48 @@
> > >                                 };
> > >                         };
> > >                 };
> > > +
> > > +               idle-states {
> > > +                       entry-method = "psci";
> > > +
> > > +                       LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 {
> > > +                               compatible = "arm,idle-state";
> > > +                               idle-state-name = "little-retention";
> > > +                               arm,psci-suspend-param = <0x00000002>;
> > > +                               entry-latency-us = <43>;
> > > +                               exit-latency-us = <86>;
> > > +                               min-residency-us = <200>;
> > > +                       };
> > > +
> > > +                       LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 {
> > > +                               compatible = "arm,idle-state";
> > > +                               idle-state-name = "little-power-collapse";
> > > +                               arm,psci-suspend-param = <0x00000003>;
> > > +                               entry-latency-us = <100>;
> > > +                               exit-latency-us = <612>;
> > > +                               min-residency-us = <1000>;
> > > +                               local-timer-stop;
> > > +                       };
> > > +
> > > +                       BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
> > > +                               compatible = "arm,idle-state";
> > > +                               idle-state-name = "big-retention";
> > > +                               arm,psci-suspend-param = <0x00000002>;
> > > +                               entry-latency-us = <41>;
> > > +                               exit-latency-us = <82>;
> > > +                               min-residency-us = <200>;
> > > +                       };
> > > +
> > > +                       BIG_CPU_SLEEP_1: cpu-sleep-1-1 {
> > > +                               compatible = "arm,idle-state";
> > > +                               idle-state-name = "big-power-collapse";
> > > +                               arm,psci-suspend-param = <0x00000003>;
> > > +                               entry-latency-us = <100>;
> > > +                               exit-latency-us = <525>;
> > > +                               min-residency-us = <1000>;
> > > +                               local-timer-stop;
> > > +                       };
> > > +               };
> > >         };
> > >
> > >         firmware {
> > > --
> > > 2.17.1
> > >

  reply	other threads:[~2019-10-01 14:22 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  9:35 [PATCH v2 0/9] qcom: Add cpuidle to some platforms Amit Kucheria
2019-05-21  9:35 ` [PATCH v2 1/9] arm64: dts: fsl: ls1028a: Fix entry-method property to reflect documentation Amit Kucheria
2019-05-21  9:35 ` [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property Amit Kucheria
2019-05-21 10:34   ` Marc Gonzalez
2019-06-13 23:13   ` Rob Herring
2019-05-21  9:35 ` [PATCH v2 3/9] arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node Amit Kucheria
2019-05-22  3:30   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 4/9] arm64: dts: qcom: msm8916: Use more generic idle state names Amit Kucheria
2019-05-22  3:30   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 5/9] arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states Amit Kucheria
2019-05-22  3:31   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 6/9] arm64: dts: qcom: msm8996: " Amit Kucheria
2019-05-21 10:13   ` Daniel Lezcano
2019-05-22  3:49   ` Bjorn Andersson
2019-05-23 21:24   ` Niklas Cassel
2019-05-21  9:35 ` [PATCH v2 7/9] arm64: dts: qcom: msm8998: " Amit Kucheria
2019-05-21 12:03   ` Marc Gonzalez
2019-05-21 16:10     ` Marc Gonzalez
2019-05-22  9:17     ` Marc Gonzalez
2019-05-22  9:35       ` Marc Zyngier
2019-05-22 15:39         ` Marc Gonzalez
2019-05-22 14:48       ` Marc Gonzalez
2019-09-30 22:20   ` Jeffrey Hugo
2019-09-30 22:44     ` Amit Kucheria
2019-10-01 14:21       ` Jeffrey Hugo [this message]
2019-10-02  9:19     ` Niklas Cassel
2019-10-02  9:27       ` Niklas Cassel
2019-10-02 18:18         ` Jeffrey Hugo
2019-10-04  1:36           ` Amit Kucheria
2019-10-04  3:14             ` Jeffrey Hugo
2019-05-21  9:35 ` [PATCH v2 8/9] arm64: dts: qcom: sdm845: " Amit Kucheria
2019-05-22  3:59   ` Bjorn Andersson
2019-05-21  9:35 ` [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus Amit Kucheria
2019-05-21 10:14   ` Daniel Lezcano
2019-05-22  3:50   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOCk7NpA5OmgmH0PZpcrj1KmhdrTKvOb+3eUL6=Mo8HRUnKjdA@mail.gmail.com' \
    --to=jeffrey.l.hugo@gmail.com \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=niklas.cassel@linaro.org \
    --cc=shawnguo@kernel.org \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).