From: Amit Kucheria <amit.kucheria@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Andy Gross <andy.gross@linaro.org>,
Andy Gross <agross@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH 07/15] dt: thermal: tsens: Document interrupt support in tsens driver
Date: Mon, 19 Aug 2019 12:40:13 +0530 [thread overview]
Message-ID: <CAHLCerN6uOijzj4skWSRhNr+dSPZ6ysXV5AQjuY9tpa7ndbMUw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+bymJXY-ffeuCc-15Vkmh88AsUAj5znBN+b-3YWP-Kqg@mail.gmail.com>
On Sun, Aug 18, 2019 at 12:55 AM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Aug 16, 2019 at 5:02 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> >
> > On Sat, Aug 17, 2019 at 3:06 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Fri, Jul 26, 2019 at 03:48:42AM +0530, Amit Kucheria wrote:
> > > > Define two new required properties to define interrupts and
> > > > interrupt-names for tsens.
> > > >
> > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > > > ---
> > > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > index 673cc1831ee9..3d3dd5dc6d36 100644
> > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > > > @@ -22,6 +22,8 @@ Required properties:
> > > >
> > > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
> > > > - #qcom,sensors: Number of sensors in tsens block
> > > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS)
> > > > +- interrupt-names: The name of the interrupt e.g. "tsens0", "tsens1"
> > >
> > > How many interrupts? A name with just indices isn't too useful.
> >
> > Depending on the version of the tsens IP, there can be 1 (upper/lower
> > threshold), 2 (upper/lower + critical threshold) or 3 (upper/lower +
> > critical + zero degree) interrupts. This patch series only introduces
> > support for a single interrupt (upper/lower).
>
> I would expect a different compatible for each possibility.
We're currently using the 'qcom,tsens-v1' and 'qcom,tsens-v2'
compatibles to broadly capture the feature (and register map)
differences.
By defining the following, I should be able to check at runtime (using
platform_get_irq_by_name() as suggested) if a particular interrupt
type is available on the platform, no? So do we really require three
different compatibles?
interrupt-names = "uplow", "crit", "cold"
[1] Respin of older SoC with a newer version of IP
> > I used the names tsens0, tsens1 to encapsulate the controller instance
> > since some SoCs have 1 controller, others have two. So we'll end up
> > with something like the following in DT:
>
> That's not really how *-names is supposed to work. The name is for
> identifying what is at each index. Or to put it another way, a driver
> should be able to use platform_get_irq_by_name(). So 'critical',
> 'zero' and something for the first one.
Fair point. I'll rework it to use "uplow", "crit" and "cold" or
something to the effect.
Is there another way I get the controller instance index in the name
in /proc/interrupts?
> > tsens0: thermal-sensor@c263000 {
> > compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
> > reg = <0 0x0c263000 0 0x1ff>, /* TM */
> > <0 0x0c222000 0 0x1ff>; /* SROT */
> > #qcom,sensors = <13>;
> > interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-names = "tsens0", "tsens0-critical";
> > #thermal-sensor-cells = <1>;
> > };
> >
> > tsens1: thermal-sensor@c265000 {
> > compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
> > reg = <0 0x0c265000 0 0x1ff>, /* TM */
> > <0 0x0c223000 0 0x1ff>; /* SROT */
> > #qcom,sensors = <8>;
> > interrupts = <GIC_SPI 507 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 509 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-names = "tsens1", "tsens1-critical";
> > #thermal-sensor-cells = <1>;
> > }
> >
> > Does that work?
> >
> > Regards,
> > Amit
> >
> > > > - Refer to Documentation/devicetree/bindings/nvmem/nvmem.txt to know how to specify
> > > > nvmem cells
> > > >
> > > > @@ -40,6 +42,9 @@ tsens0: thermal-sensor@c263000 {
> > > > reg = <0xc263000 0x1ff>, /* TM */
> > > > <0xc222000 0x1ff>; /* SROT */
> > > > #qcom,sensors = <13>;
> > > > + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>;
> > > > + interrupt-names = "tsens0";
> > > > +
> > > > #thermal-sensor-cells = <1>;
> > > > };
> > > >
> > > > --
> > > > 2.17.1
> > > >
next prev parent reply other threads:[~2019-08-19 7:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 22:18 [PATCH 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-07-25 22:18 ` [PATCH 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-08-17 4:01 ` Stephen Boyd
2019-08-19 11:55 ` Daniel Lezcano
2019-07-25 22:18 ` [PATCH 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-08-17 4:02 ` Stephen Boyd
2019-08-19 11:57 ` Daniel Lezcano
2019-07-25 22:18 ` [PATCH 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements Amit Kucheria
2019-08-17 4:03 ` Stephen Boyd
2019-08-19 13:19 ` Daniel Lezcano
2019-07-25 22:18 ` [PATCH 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-08-17 4:07 ` Stephen Boyd
2019-08-19 7:58 ` Amit Kucheria
2019-08-19 14:27 ` Stephen Boyd
2019-08-21 12:55 ` Amit Kucheria
2019-08-26 20:55 ` Stephen Boyd
2019-07-25 22:18 ` [PATCH 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-08-08 20:49 ` Brian Masney
2019-07-25 22:18 ` [PATCH 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-08-13 13:25 ` Daniel Lezcano
2019-07-25 22:18 ` [PATCH 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
2019-08-16 21:36 ` Rob Herring
2019-08-16 22:02 ` Amit Kucheria
2019-08-17 4:10 ` Stephen Boyd
2019-08-17 19:25 ` Rob Herring
2019-08-19 7:10 ` Amit Kucheria [this message]
2019-08-19 13:07 ` Rob Herring
2019-07-25 22:18 ` [PATCH 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-07-25 22:18 ` [PATCH 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-07-25 22:18 ` [PATCH 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-07-25 22:18 ` [PATCH 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-07-25 22:18 ` [PATCH 12/15] arm64: dts: msm8974: " Amit Kucheria
2019-07-29 9:03 ` Luca Weiss
2019-07-29 9:29 ` Amit Kucheria
2019-08-08 20:49 ` Brian Masney
2019-07-25 22:18 ` [PATCH 13/15] arm64: dts: msm8916: " Amit Kucheria
2019-07-25 22:18 ` [PATCH 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-08-17 4:16 ` Stephen Boyd
2019-08-19 20:51 ` Amit Kucheria
2019-07-25 22:18 ` [PATCH 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
2019-08-17 6:09 ` Stephen Boyd
2019-08-22 13:40 ` Amit Kucheria
2019-07-26 10:36 ` [PATCH 00/15] thermal: qcom: " Brian Masney
2019-07-26 11:10 ` Amit Kucheria
2019-07-26 11:29 ` Brian Masney
2019-07-27 7:28 ` Amit Kucheria
2019-07-29 9:07 ` Brian Masney
2019-07-29 9:32 ` Luca Weiss
2019-07-29 9:50 ` Amit Kucheria
2019-08-12 15:28 ` Niklas Cassel
2019-08-08 13:04 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerN6uOijzj4skWSRhNr+dSPZ6ysXV5AQjuY9tpa7ndbMUw@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).