From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V3 5/5] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280
Date: Tue, 20 Apr 2021 11:02:11 -0700 [thread overview]
Message-ID: <YH8XIyp/l4C0JPvc@google.com> (raw)
In-Reply-To: <1618398783-7834-6-git-send-email-skakit@codeaurora.org>
On Wed, Apr 14, 2021 at 04:43:03PM +0530, satya priya wrote:
> Subject: arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280
Please make sure to distinguish between the SoC (sc7280) and the
board (sc7280-idp), this patch primarily adds stuff to the board not
the SoC, this should be clear from the subject.
> Include pm7325, pm8350c, pmk8350 and pmr735a DT files.
How about something like 'The sc7280-idp has four PMICs, include their
.dtsi files'?
> Add channel nodes for pmk8350_vadc.
It's not super important, but I don't like it when things like this get
sneaked in with a commit message saying 'Include PMIC DT files for
sc7280'. I would suggest a separate patch. And please mention that
the channels are for the on die temperatures of the PMICs.
> Also, add the thermal_zones node in dtsi.
This is not the right patch to add it. This patch is about the sc7280-board
and doesn't do anything (directly) with thermal zones. However other
patches further down in the stack of in this series require the
'thermal-zones' to exist, hence the node should exist before these patches
reference it. A dedicated patch adding the node seems like the best option
to me.
next prev parent reply other threads:[~2021-04-20 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 11:12 [RESEND PATCH V3 0/5] Add PMIC DT files for sc7280 satya priya
2021-04-14 11:12 ` [RESEND PATCH V3 1/5] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-04-14 11:13 ` [RESEND PATCH V3 4/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 satya priya
2021-04-20 17:29 ` Matthias Kaehlcke
2021-04-28 5:58 ` skakit
2021-04-14 11:13 ` [RESEND PATCH V3 3/5] arm64: dts: qcom: pmr735a: Add temp-alarm support satya priya
2021-04-20 17:16 ` Matthias Kaehlcke
2021-04-14 11:13 ` [RESEND PATCH V3 2/5] arm64: dts: qcom: pm8350c: " satya priya
2021-04-14 11:13 ` [RESEND PATCH V3 5/5] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280 satya priya
2021-04-20 18:02 ` Matthias Kaehlcke [this message]
2021-04-28 6:04 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH8XIyp/l4C0JPvc@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).