Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous "input-enable"

From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous "input-enable"
Date: Tue, 11 Apr 2023 16:12:37 +0200	[thread overview]
Message-ID: <ZDVq1b0TjXH5LTYx@hovoldconsulting.com> (raw)
In-Reply-To: <20230407175807.124394-5-krzysztof.kozlowski@linaro.org>

On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers.  Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.

This description does not seem to match the pin configurations that you
are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl"
binding for which 'input-enable' is still accepted AFAICT.

Perhaps you can fix up the lpass bindings (and driver?) to match?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 4c75da1bac2d..5632c3b8e416 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2728,7 +2728,6 @@ data-pins {
>  					pins = "gpio7";
>  					function = "dmic1_data";
>  					drive-strength = <8>;
> -					input-enable;
>  				};
>  			};

Johan