From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] arm64: dts: qcom: sc8280xp: remove superfluous "input-enable"
Date: Tue, 11 Apr 2023 19:07:20 +0200 [thread overview]
Message-ID: <b7c9ac38-6f9b-8d05-39c6-fee9058209a9@linaro.org> (raw)
In-Reply-To: <ZDVq1b0TjXH5LTYx@hovoldconsulting.com>
On 11/04/2023 16:12, Johan Hovold wrote:
> On Fri, Apr 07, 2023 at 07:58:02PM +0200, Krzysztof Kozlowski wrote:
>> Pin configuration property "input-enable" was used with the intention to
>> disable the output, but this is done by default by Linux drivers. Since
>> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
>> input-enable") the property is not accepted anymore.
>
> This description does not seem to match the pin configurations that you
> are changing below which use the "qcom,sc8280xp-lpass-lpi-pinctrl"
> binding for which 'input-enable' is still accepted AFAICT.
>
> Perhaps you can fix up the lpass bindings (and driver?) to match?
Thanks for spotting this. This change is wrong.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-11 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 17:57 [PATCH 01/10] arm64: dts: qcom: msm8994: remove superfluous "input-enable" Krzysztof Kozlowski
2023-04-07 17:57 ` [PATCH 02/10] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 03/10] arm64: dts: qcom: msm8998: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 04/10] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 05/10] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2023-04-11 14:12 ` Johan Hovold
2023-04-11 17:07 ` Krzysztof Kozlowski [this message]
2023-04-07 17:58 ` [PATCH 06/10] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 07/10] arm64: dts: qcom: sm6125: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 08/10] arm64: dts: qcom: sm6350: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 09/10] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2023-04-07 17:58 ` [PATCH 10/10] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-04-07 18:51 ` (subset) [PATCH 01/10] arm64: dts: qcom: msm8994: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7c9ac38-6f9b-8d05-39c6-fee9058209a9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).