linux-audit.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: [GIT PULL] Audit fixes for v5.6 (#1)
Date: Wed, 26 Feb 2020 20:50:44 -0500	[thread overview]
Message-ID: <CAHC9VhSL2M4QBP-_z9U-MMNUAT9G_pnJxrPcNtQs03yi7epYxQ@mail.gmail.com> (raw)
Message-ID: <20200227015044.91B6M3gsnOXvHmPGPiVmuV65A7ahjtQPlxhGShnzz1k@z> (raw)

Hi Linus,

Two audit patches to fix problems found by syzbot, please merge for
the next v5.6-rcX release.

* Moving audit filter structure fields into a union caused some
problems in the code which populates that filter structure.  We keep
the union (that idea is a good one), but we are fixing the code so
that it doesn't needlessly set fields in the union and mess up the
error handling.

* The audit_receive_msg() function wasn't validating user input as
well as it should in all cases, we add the necessary checks.

Thanks,
-Paul

--
The following changes since commit cb5172d96d16df72db8b55146b0ec00bfd97f079:

 audit: Add __rcu annotation to RCU pointer (2019-12-09 15:19:03 -0500)

are available in the Git repository at:

 git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
   tags/audit-pr-20200226

for you to fetch changes up to 756125289285f6e55a03861bf4b6257aa3d19a93:

 audit: always check the netlink payload length in audit_receive_msg()
   (2020-02-24 16:38:57 -0500)

----------------------------------------------------------------
audit/stable-5.6 PR 20200226

----------------------------------------------------------------
Paul Moore (2):
     audit: fix error handling in audit_data_to_entry()
     audit: always check the netlink payload length in audit_receive_msg()

kernel/audit.c       | 40 +++++++++++++++--------------
kernel/auditfilter.c | 71 +++++++++++++++++++++++++++---------------------
2 files changed, 60 insertions(+), 51 deletions(-)

-- 
paul moore
www.paul-moore.com


--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


             reply	other threads:[~2020-02-27  1:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  1:50 Paul Moore [this message]
2020-02-27  1:50 ` [GIT PULL] Audit fixes for v5.6 (#1) Paul Moore
2020-02-27 19:40 ` pr-tracker-bot
2020-02-27 19:40   ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhSL2M4QBP-_z9U-MMNUAT9G_pnJxrPcNtQs03yi7epYxQ@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).