From: Jens Axboe <axboe@kernel.dk>
To: Bcache Linux <linux-bcache@vger.kernel.org>,
Markus Weippert <markus@gekmihesg.de>
Cc: "Thorsten Leemhuis" <regressions@leemhuis.info>,
"Zheng Wang" <zyytlz.wz@163.com>,
linux-kernel@vger.kernel.org,
"Stefan Förster" <cite@incertum.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
"Linux kernel regressions list" <regressions@lists.linux.dev>,
"Coly Li" <colyli@suse.de>
Subject: Re: [PATCH] bcache: revert replacing IS_ERR_OR_NULL with IS_ERR
Date: Mon, 27 Nov 2023 09:12:29 -0700 [thread overview]
Message-ID: <170110154924.44993.12405607589120929041.b4-ty@kernel.dk> (raw)
In-Reply-To: <c47d3540ece151a2fb30e1c7b5881cb8922db915.camel@gekmihesg.de>
On Fri, 24 Nov 2023 16:14:37 +0100, Markus Weippert wrote:
> Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in
> node allocations") replaced IS_ERR_OR_NULL by IS_ERR. This leads to a
> NULL pointer dereference.
>
> BUG: kernel NULL pointer dereference, address: 0000000000000080
> Call Trace:
> ? __die_body.cold+0x1a/0x1f
> ? page_fault_oops+0xd2/0x2b0
> ? exc_page_fault+0x70/0x170
> ? asm_exc_page_fault+0x22/0x30
> ? btree_node_free+0xf/0x160 [bcache]
> ? up_write+0x32/0x60
> btree_gc_coalesce+0x2aa/0x890 [bcache]
> ? bch_extent_bad+0x70/0x170 [bcache]
> btree_gc_recurse+0x130/0x390 [bcache]
> ? btree_gc_mark_node+0x72/0x230 [bcache]
> bch_btree_gc+0x5da/0x600 [bcache]
> ? cpuusage_read+0x10/0x10
> ? bch_btree_gc+0x600/0x600 [bcache]
> bch_gc_thread+0x135/0x180 [bcache]
>
> [...]
Applied, thanks!
[1/1] bcache: revert replacing IS_ERR_OR_NULL with IS_ERR
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-11-27 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZV9ZSyDLNDlzutgQ@pharmakeia.incertum.net>
2023-11-24 6:18 ` bcache: kernel NULL pointer dereference since 6.1.39 Thorsten Leemhuis
2023-11-24 13:29 ` Markus Weippert
2023-11-24 13:46 ` Coly Li
2023-11-24 13:55 ` Markus Weippert
2023-11-24 14:17 ` Coly Li
2023-11-24 15:14 ` [PATCH] bcache: revert replacing IS_ERR_OR_NULL with IS_ERR Markus Weippert
2023-11-24 16:29 ` Coly Li
2023-11-24 16:31 ` Jens Axboe
2023-11-24 16:34 ` Coly Li
2023-11-24 16:35 ` Jens Axboe
2023-11-24 16:42 ` Coly Li
2023-11-27 16:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170110154924.44993.12405607589120929041.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cite@incertum.net \
--cc=colyli@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@gekmihesg.de \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).