From: Coly Li <colyli@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Markus Weippert" <markus@gekmihesg.de>,
"Bcache Linux" <linux-bcache@vger.kernel.org>,
"Thorsten Leemhuis" <regressions@leemhuis.info>,
"Zheng Wang" <zyytlz.wz@163.com>,
linux-kernel@vger.kernel.org,
"Stefan Förster" <cite@incertum.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Linux kernel regressions list" <regressions@lists.linux.dev>
Subject: Re: [PATCH] bcache: revert replacing IS_ERR_OR_NULL with IS_ERR
Date: Sat, 25 Nov 2023 00:34:44 +0800 [thread overview]
Message-ID: <910112B4-168D-4ECC-B374-7E6668B778F9@suse.de> (raw)
In-Reply-To: <54706535-208b-43b5-814f-570ffa7b29bb@kernel.dk>
> 2023年11月25日 00:31,Jens Axboe <axboe@kernel.dk> 写道:
>
> On 11/24/23 9:29 AM, Coly Li wrote:
>>
>>
>>> 2023?11?24? 23:14?Markus Weippert <markus@gekmihesg.de> ???
>>>
>>> Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in
>>> node allocations") replaced IS_ERR_OR_NULL by IS_ERR. This leads to a
>>> NULL pointer dereference.
>>>
>>> BUG: kernel NULL pointer dereference, address: 0000000000000080
>>> Call Trace:
>>> ? __die_body.cold+0x1a/0x1f
>>> ? page_fault_oops+0xd2/0x2b0
>>> ? exc_page_fault+0x70/0x170
>>> ? asm_exc_page_fault+0x22/0x30
>>> ? btree_node_free+0xf/0x160 [bcache]
>>> ? up_write+0x32/0x60
>>> btree_gc_coalesce+0x2aa/0x890 [bcache]
>>> ? bch_extent_bad+0x70/0x170 [bcache]
>>> btree_gc_recurse+0x130/0x390 [bcache]
>>> ? btree_gc_mark_node+0x72/0x230 [bcache]
>>> bch_btree_gc+0x5da/0x600 [bcache]
>>> ? cpuusage_read+0x10/0x10
>>> ? bch_btree_gc+0x600/0x600 [bcache]
>>> bch_gc_thread+0x135/0x180 [bcache]
>>>
>>> The relevant code starts with:
>>>
>>> new_nodes[0] = NULL;
>>>
>>> for (i = 0; i < nodes; i++) {
>>> if (__bch_keylist_realloc(&keylist, bkey_u64s(&r[i].b->key)))
>>> goto out_nocoalesce;
>>> // ...
>>> out_nocoalesce:
>>> // ...
>>> for (i = 0; i < nodes; i++)
>>> if (!IS_ERR(new_nodes[i])) { // IS_ERR_OR_NULL before
>>> 028ddcac477b
>>> btree_node_free(new_nodes[i]); // new_nodes[0] is NULL
>>> rw_unlock(true, new_nodes[i]);
>>> }
>>>
>>> This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this.
>>>
>>> Fixes: 028ddcac477b ("bcache: Remove unnecessary NULL point check in
>>> node allocations")
>>> Link:
>>> https://lore.kernel.org/all/3DF4A87A-2AC1-4893-AE5F-E921478419A9@suse.de/
>>> Cc: stable@vger.kernel.org
>>> Cc: Zheng Wang <zyytlz.wz@163.com>
>>> Cc: Coly Li <colyli@suse.de>
>>> Signed-off-by: Markus Weippert <markus@gekmihesg.de>
>>
>> Added into my for-next. Thanks for patching up.
>
> We should probably get this into the current release, rather than punt
> it to 6.8.
Yes, copied. So far I don’t have other bcache patches for 6.7, I feel I might be redundant if I send you another for -rc4 series with this single patch.
Could you please directly take it into -rc4?
Thanks.
Coly Li
next prev parent reply other threads:[~2023-11-24 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZV9ZSyDLNDlzutgQ@pharmakeia.incertum.net>
2023-11-24 6:18 ` bcache: kernel NULL pointer dereference since 6.1.39 Thorsten Leemhuis
2023-11-24 13:29 ` Markus Weippert
2023-11-24 13:46 ` Coly Li
2023-11-24 13:55 ` Markus Weippert
2023-11-24 14:17 ` Coly Li
2023-11-24 15:14 ` [PATCH] bcache: revert replacing IS_ERR_OR_NULL with IS_ERR Markus Weippert
2023-11-24 16:29 ` Coly Li
2023-11-24 16:31 ` Jens Axboe
2023-11-24 16:34 ` Coly Li [this message]
2023-11-24 16:35 ` Jens Axboe
2023-11-24 16:42 ` Coly Li
2023-11-27 16:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910112B4-168D-4ECC-B374-7E6668B778F9@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=cite@incertum.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@gekmihesg.de \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).