From: Yu Kuai <yukuai1@huaweicloud.com>
To: Kent Overstreet <kent.overstreet@linux.dev>,
Damien Le Moal <dlemoal@kernel.org>
Cc: Yu Kuai <yukuai1@huaweicloud.com>,
hch@infradead.org, ming.lei@redhat.com, axboe@kernel.dk,
roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com,
joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com,
josef@toxicpanda.com, dsterba@suse.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, nico@fluxnic.net, xiang@kernel.org,
chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca,
agruenba@redhat.com, jack@suse.com, konishi.ryusuke@gmail.com,
dchinner@redhat.com, linux@weissschuh.net, min15.li@samsung.com,
willy@infradead.org, akpm@linux-foundation.org, hare@suse.de,
p.raghav@samsung.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-ext4@vger.kernel.org, gfs2@lists.linux.dev,
linux-nilfs@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH block/for-next v2 07/16] bcachefs: use new helper to get inode from block_device
Date: Mon, 27 Nov 2023 15:52:39 +0800 [thread overview]
Message-ID: <58ced33e-0a8c-7bd3-beb8-d75119cab60b@huaweicloud.com> (raw)
In-Reply-To: <20231127072409.y22jkynrchm4tkd2@moria.home.lan>
Hi,
在 2023/11/27 15:24, Kent Overstreet 写道:
> On Mon, Nov 27, 2023 at 04:09:47PM +0900, Damien Le Moal wrote:
>> On 11/27/23 15:21, Yu Kuai wrote:
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> Which is more efficiency, and also prepare to remove the field
>>> 'bd_inode' from block_device.
>>>
>>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>>> ---
>>> fs/bcachefs/util.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h
>>> index 2984b57b2958..fe7ccb3a3517 100644
>>> --- a/fs/bcachefs/util.h
>>> +++ b/fs/bcachefs/util.h
>>> @@ -518,7 +518,7 @@ int bch2_bio_alloc_pages(struct bio *, size_t, gfp_t);
>>>
>>> static inline sector_t bdev_sectors(struct block_device *bdev)
>>> {
>>> - return bdev->bd_inode->i_size >> 9;
>>> + return bdev_inode(bdev)->i_size >> 9;
>>
>> shouldn't this use i_size_read() ?
>>
>> I missed the history with this but why not use bdev_nr_sectors() and delete this
>> helper ?
>
> Actually, this helper seems to be dead code.
Yes, there is no caller of this helper, I'll remove this helper.
Thanks,
Kuai
> .
>
next prev parent reply other threads:[~2023-11-27 7:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 6:21 [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 01/16] block: add a new helper to get inode " Yu Kuai
2023-11-27 7:21 ` Christoph Hellwig
2023-11-27 13:07 ` Yu Kuai
2023-11-27 16:32 ` Christoph Hellwig
2023-11-28 1:35 ` Yu Kuai
2023-11-28 5:48 ` Christoph Hellwig
2023-11-27 6:21 ` [PATCH block/for-next v2 02/16] xen/blkback: use " Yu Kuai
2023-11-28 10:05 ` Roger Pau Monné
2023-11-27 6:21 ` [PATCH block/for-next v2 03/16] bcache: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 04/16] mtd: block2mtd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 05/16] s390/dasd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 06/16] scsicam: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 07/16] bcachefs: " Yu Kuai
2023-11-27 6:49 ` Kent Overstreet
2023-11-27 7:09 ` Damien Le Moal
2023-11-27 7:24 ` Kent Overstreet
2023-11-27 7:52 ` Yu Kuai [this message]
2023-11-27 6:21 ` [PATCH block/for-next v2 08/16] btrfs: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 09/16] cramfs: " Yu Kuai
2023-11-27 6:47 ` [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ced33e-0a8c-7bd3-beb8-d75119cab60b@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=agordeev@linux.ibm.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dchinner@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=hare@suse.de \
--cc=hca@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hoeppner@linux.ibm.com \
--cc=jack@suse.com \
--cc=jejb@linux.ibm.com \
--cc=joern@lazybastard.org \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.petersen@oracle.com \
--cc=min15.li@samsung.com \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=nico@fluxnic.net \
--cc=p.raghav@samsung.com \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=sth@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiang@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).