From: Yu Kuai <yukuai1@huaweicloud.com>
To: Christoph Hellwig <hch@infradead.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: ming.lei@redhat.com, axboe@kernel.dk, roger.pau@citrix.com,
colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, viro@zeniv.linux.org.uk, brauner@kernel.org,
nico@fluxnic.net, xiang@kernel.org, chao@kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com,
jack@suse.com, konishi.ryusuke@gmail.com, dchinner@redhat.com,
linux@weissschuh.net, min15.li@samsung.com, dlemoal@kernel.org,
willy@infradead.org, akpm@linux-foundation.org, hare@suse.de,
p.raghav@samsung.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-ext4@vger.kernel.org, gfs2@lists.linux.dev,
linux-nilfs@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device
Date: Tue, 28 Nov 2023 09:35:56 +0800 [thread overview]
Message-ID: <bc64da80-e9bd-84cb-f173-876623303131@huaweicloud.com> (raw)
In-Reply-To: <ZWTErvnMf7HiO1Wj@infradead.org>
Hi,
在 2023/11/28 0:32, Christoph Hellwig 写道:
> On Mon, Nov 27, 2023 at 09:07:22PM +0800, Yu Kuai wrote:
>> 1) Is't okay to add a new helper to pass in bdev for following apis?
>
>
> For some we already have them (e.g. bdev_nr_bytes to read the bdev)
> size, for some we need to add them. The big thing that seems to
> stick out is page cache API, and I think that is where we need to
> define maintainable APIs for file systems and others to use the
> block device page cache. Probably only in folio versions and not
> pages once if we're touching the code anyay
Thanks for the advice! In case I'm understanding correctly, do you mean
that all other fs/drivers that is using pages versions can safely switch
to folio versions now?
By the way, my orginal idea was trying to add a new field 'bd_flags'
in block_devcie, and then add a new bit so that bio_check_ro() will
only warn once for each partition. Now that this patchset will be quite
complex, I'll add a new bool field 'bd_ro_warned' to fix the above
problem first, and then add 'bd_flags' once this patchset is done.
Thanks,
Kuai
>
>> 2) For the file fs/buffer.c, there are some special usage like
>> following that I don't think it's good to add a helper:
>>
>> spin_lock(&bd_inode->i_mapping->private_lock);
>>
>> Is't okay to move following apis from fs/buffer.c directly to
>> block/bdev.c?
>>
>> __find_get_block
>> bdev_getblk
>
> I'm not sure moving is a good idea, but we might end up the
> some kind of low-level access from buffer.c, be that special
> helpers, a separate header or something else. Let's sort out
> the rest of the kernel first.
>
> .
>
next prev parent reply other threads:[~2023-11-28 1:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 6:21 [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' from block_device Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 01/16] block: add a new helper to get inode " Yu Kuai
2023-11-27 7:21 ` Christoph Hellwig
2023-11-27 13:07 ` Yu Kuai
2023-11-27 16:32 ` Christoph Hellwig
2023-11-28 1:35 ` Yu Kuai [this message]
2023-11-28 5:48 ` Christoph Hellwig
2023-11-27 6:21 ` [PATCH block/for-next v2 02/16] xen/blkback: use " Yu Kuai
2023-11-28 10:05 ` Roger Pau Monné
2023-11-27 6:21 ` [PATCH block/for-next v2 03/16] bcache: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 04/16] mtd: block2mtd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 05/16] s390/dasd: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 06/16] scsicam: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 07/16] bcachefs: " Yu Kuai
2023-11-27 6:49 ` Kent Overstreet
2023-11-27 7:09 ` Damien Le Moal
2023-11-27 7:24 ` Kent Overstreet
2023-11-27 7:52 ` Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 08/16] btrfs: " Yu Kuai
2023-11-27 6:21 ` [PATCH block/for-next v2 09/16] cramfs: " Yu Kuai
2023-11-27 6:47 ` [PATCH block/for-next v2 00/16] block: remove field 'bd_inode' " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc64da80-e9bd-84cb-f173-876623303131@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=agordeev@linux.ibm.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dchinner@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=hare@suse.de \
--cc=hca@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hoeppner@linux.ibm.com \
--cc=jack@suse.com \
--cc=jejb@linux.ibm.com \
--cc=joern@lazybastard.org \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@gmail.com \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.petersen@oracle.com \
--cc=min15.li@samsung.com \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=nico@fluxnic.net \
--cc=p.raghav@samsung.com \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=sth@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xiang@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).