From: Omar Sandoval <osandov@osandov.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Masato Suzuki <masato.suzuki@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
Matias Bjorling <matias.bjorling@wdc.com>,
Hannes Reinecke <hare@suse.de>, Mike Snitzer <snitzer@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH blktests v3 03/13] block/004: Adjust fio conditions for zoned block devices
Date: Fri, 25 Jan 2019 13:09:01 -0800 [thread overview]
Message-ID: <20190125210901.GB26739@vader> (raw)
In-Reply-To: <20190118094453.13773-4-shinichiro.kawasaki@wdc.com>
On Fri, Jan 18, 2019 at 06:44:43PM +0900, Shin'ichiro Kawasaki wrote:
> For a random write pattern to a zoned block device, fio requires --direct=1
> and --zonemode=zbd options as well as deadline I/O scheduler to be
> specified. Specify these options and set the I/O scheduler if the target
> device is a zoned block device. Before doing that, also make sure that the
> deadline scheduler is available and that fio supports the zbd zone mode.
> Set CAN_BE_ZONED flag to run this test case for zoned block devices.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
> tests/block/004 | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/tests/block/004 b/tests/block/004
> index 4c14c4b..7340d33 100755
> --- a/tests/block/004
> +++ b/tests/block/004
> @@ -8,6 +8,7 @@
>
> DESCRIPTION="run lots of flushes"
> TIMED=1
> +CAN_BE_ZONED=1
>
> requires() {
> _have_fio
> @@ -16,10 +17,25 @@ requires() {
> test_device() {
> echo "Running ${TEST_NAME}"
>
> + local directio=""
> + local zbdmode=""
> +
> + if _test_dev_is_zoned; then
> + if ! _have_fio_zbd_zonemode; then
> + echo "${SKIP_REASON}"
> + return 1
> + fi
This will be marked as a failure instead of skipped. This check can be
in device_requires instead:
device_requires() {
! _test_dev_is_zoned || _have_fio_zbd_zonemode
}
> + _test_dev_queue_set scheduler deadline
> +
> + directio="--direct=1"
> + zbdmode="--zonemode=zbd"
> + fi
> +
> FIO_PERF_FIELDS=("write iops")
> _fio_perf --bs=4k --rw=randwrite --norandommap --fsync=1 \
> --number_ios=256 --numjobs=64 --name=flushes \
> - --filename="$TEST_DEV"
> + ${directio} ${zbdmode} --filename="$TEST_DEV"
I'm surprised that shellcheck is smart enough to see that directio and
zbdmode are always one word so this doesn't need quotes :)
>
> echo "Test complete"
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-25 21:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:44 [PATCH blktests v3 00/13] Implement zoned block device support Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 01/13] config: Introduce RUN_ZONED_TESTS variable and CAN_BE_ZONED flag Shin'ichiro Kawasaki
2019-01-25 20:59 ` Omar Sandoval
2019-01-28 10:07 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 02/13] common: Introduce _have_fio_zbd_zonemode() helper function Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 03/13] block/004: Adjust fio conditions for zoned block devices Shin'ichiro Kawasaki
2019-01-25 21:09 ` Omar Sandoval [this message]
2019-01-28 10:13 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 04/13] block: Whitelist tests supporting " Shin'ichiro Kawasaki
2019-01-25 21:11 ` Omar Sandoval
2019-01-28 10:37 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 05/13] check: Introduce fallback_device() and cleanup_fallback_device() Shin'ichiro Kawasaki
2019-01-25 21:14 ` Omar Sandoval
2019-01-28 10:54 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 06/13] common: Introduce _dd() helper function Shin'ichiro Kawasaki
2019-01-25 21:17 ` Omar Sandoval
2019-01-28 12:18 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 07/13] src: Introduce zbdioctl program Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 08/13] tests: Introduce zbd test group Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 09/13] zbd/001: sysfs and ioctl consistency test Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 10/13] zbd/002: report zone test Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 11/13] zbd/003: Test sequential zones reset Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 12/13] zbd/004: Check write split accross sequential zones Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 13/13] zbd/005: Test write ordering Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125210901.GB26739@vader \
--to=osandov@osandov.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masato.suzuki@wdc.com \
--cc=matias.bjorling@wdc.com \
--cc=osandov@fb.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).