linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
	Masato Suzuki <masato.suzuki@wdc.com>,
	Jens Axboe <axboe@kernel.dk>,
	Matias Bjorling <matias.bjorling@wdc.com>,
	Hannes Reinecke <hare@suse.de>, Mike Snitzer <snitzer@redhat.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH blktests v3 04/13] block: Whitelist tests supporting zoned block devices
Date: Fri, 25 Jan 2019 13:11:01 -0800	[thread overview]
Message-ID: <20190125211101.GC26739@vader> (raw)
In-Reply-To: <20190118094453.13773-5-shinichiro.kawasaki@wdc.com>

On Fri, Jan 18, 2019 at 06:44:44PM +0900, Shin'ichiro Kawasaki wrote:
> Define CAN_BE_ZONED=1 in block/005, block/006, block/010, block/011,
> block/016, block/017, block/020, block/021 and block/023 as all these
> tests should execute without any problem against null_blk with zoned
> mode enabled or zoned block devices specified in TEST_DEVS.

Several of these tests do random I/O, did I miss a change that makes fio
use zonemode=zbd or something?

> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  tests/block/005 | 1 +
>  tests/block/006 | 1 +
>  tests/block/010 | 1 +
>  tests/block/011 | 1 +
>  tests/block/016 | 1 +
>  tests/block/017 | 1 +
>  tests/block/020 | 1 +
>  tests/block/021 | 1 +
>  tests/block/023 | 1 +
>  9 files changed, 9 insertions(+)
> 
> diff --git a/tests/block/005 b/tests/block/005
> index 65eba22..8ab6791 100755
> --- a/tests/block/005
> +++ b/tests/block/005
> @@ -8,6 +8,7 @@
>  
>  DESCRIPTION="switch schedulers while doing IO"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_fio
> diff --git a/tests/block/006 b/tests/block/006
> index 630d478..0b8a3c0 100755
> --- a/tests/block/006
> +++ b/tests/block/006
> @@ -12,6 +12,7 @@
>  
>  DESCRIPTION="run null-blk in blocking mode"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_module_param null_blk blocking && _have_fio
> diff --git a/tests/block/010 b/tests/block/010
> index 76b301f..b81208e 100644
> --- a/tests/block/010
> +++ b/tests/block/010
> @@ -12,6 +12,7 @@
>  
>  DESCRIPTION="run I/O on null_blk with shared and non-shared tags"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_module_param null_blk shared_tags && _have_fio
> diff --git a/tests/block/011 b/tests/block/011
> index 8e10900..c3432a6 100755
> --- a/tests/block/011
> +++ b/tests/block/011
> @@ -8,6 +8,7 @@
>  
>  DESCRIPTION="disable PCI device while doing I/O"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_fio && _have_program setpci
> diff --git a/tests/block/016 b/tests/block/016
> index 10ec4ba..c70b7d0 100755
> --- a/tests/block/016
> +++ b/tests/block/016
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="send a signal to a process waiting on a frozen queue"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/017 b/tests/block/017
> index cea29be..e4a9259 100755
> --- a/tests/block/017
> +++ b/tests/block/017
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="do I/O and check the inflight counter"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/020 b/tests/block/020
> index a377ea2..39dde66 100755
> --- a/tests/block/020
> +++ b/tests/block/020
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="run null-blk on different schedulers with only one hardware tag"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_fio
> diff --git a/tests/block/021 b/tests/block/021
> index 0ca5a17..a1bbf45 100755
> --- a/tests/block/021
> +++ b/tests/block/021
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="read/write nr_requests on null-blk with different schedulers"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/023 b/tests/block/023
> index b0739f7..0f20f4a 100755
> --- a/tests/block/023
> +++ b/tests/block/023
> @@ -10,6 +10,7 @@
>  
>  DESCRIPTION="do I/O on all null_blk queue modes"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> -- 
> 2.20.1
> 

  reply	other threads:[~2019-01-25 21:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  9:44 [PATCH blktests v3 00/13] Implement zoned block device support Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 01/13] config: Introduce RUN_ZONED_TESTS variable and CAN_BE_ZONED flag Shin'ichiro Kawasaki
2019-01-25 20:59   ` Omar Sandoval
2019-01-28 10:07     ` Shinichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 02/13] common: Introduce _have_fio_zbd_zonemode() helper function Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 03/13] block/004: Adjust fio conditions for zoned block devices Shin'ichiro Kawasaki
2019-01-25 21:09   ` Omar Sandoval
2019-01-28 10:13     ` Shinichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 04/13] block: Whitelist tests supporting " Shin'ichiro Kawasaki
2019-01-25 21:11   ` Omar Sandoval [this message]
2019-01-28 10:37     ` Shinichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 05/13] check: Introduce fallback_device() and cleanup_fallback_device() Shin'ichiro Kawasaki
2019-01-25 21:14   ` Omar Sandoval
2019-01-28 10:54     ` Shinichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 06/13] common: Introduce _dd() helper function Shin'ichiro Kawasaki
2019-01-25 21:17   ` Omar Sandoval
2019-01-28 12:18     ` Shinichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 07/13] src: Introduce zbdioctl program Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 08/13] tests: Introduce zbd test group Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 09/13] zbd/001: sysfs and ioctl consistency test Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 10/13] zbd/002: report zone test Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 11/13] zbd/003: Test sequential zones reset Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 12/13] zbd/004: Check write split accross sequential zones Shin'ichiro Kawasaki
2019-01-18  9:44 ` [PATCH blktests v3 13/13] zbd/005: Test write ordering Shin'ichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190125211101.GC26739@vader \
    --to=osandov@osandov.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=masato.suzuki@wdc.com \
    --cc=matias.bjorling@wdc.com \
    --cc=osandov@fb.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).