linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH blktests v2] block/020: dynamically change iodepth if test aio-nr lager than aio-max-nr
@ 2019-04-06 14:27 Xiao Liang
  2019-04-17 21:41 ` Omar Sandoval
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Liang @ 2019-04-06 14:27 UTC (permalink / raw)
  To: linux-block, osandov; +Cc: xiliang

When system has large count of cpus(eg. 96), the test failed as aio-nr over
aio-max-nr limitation.

This patch continues to use 1024 as default iodepth, but change it if
iodepth*$(nproc) > aio-max-nr.

Signed-off-by: Xiao Liang <xiliang@redhat.com>
---
 tests/block/020 | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/block/020 b/tests/block/020
index 39dde66..6583a3f 100755
--- a/tests/block/020
+++ b/tests/block/020
@@ -29,10 +29,16 @@ test() {
 	# shellcheck disable=SC2207
 	scheds=($(sed 's/[][]//g' /sys/block/nullb0/queue/scheduler))
 
+	aio_max_nr=$(cat /proc/sys/fs/aio-max-nr)
+	max_iodepth=$((aio_max_nr/$(nproc)))
+	iodepth=1024
+	if (( iodepth > max_iodepth )); then
+		iodepth=$max_iodepth
+	fi
 	for sched in "${scheds[@]}"; do
 		echo "Testing $sched" >> "$FULL"
 		echo "$sched" > /sys/block/nullb0/queue/scheduler
-		_fio_perf --bs=4k --ioengine=libaio --iodepth=1024 \
+		_fio_perf --bs=4k --ioengine=libaio --iodepth=$iodepth \
 			--numjobs="$(nproc)" --rw=randread --name=async \
 			--filename=/dev/nullb0 --size=1g --direct=1 \
 			--runtime=10
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH blktests v2] block/020: dynamically change iodepth if test aio-nr lager than aio-max-nr
  2019-04-06 14:27 [PATCH blktests v2] block/020: dynamically change iodepth if test aio-nr lager than aio-max-nr Xiao Liang
@ 2019-04-17 21:41 ` Omar Sandoval
  0 siblings, 0 replies; 2+ messages in thread
From: Omar Sandoval @ 2019-04-17 21:41 UTC (permalink / raw)
  To: Xiao Liang; +Cc: linux-block, osandov

On Sat, Apr 06, 2019 at 10:27:22PM +0800, Xiao Liang wrote:
> When system has large count of cpus(eg. 96), the test failed as aio-nr over
> aio-max-nr limitation.
> 
> This patch continues to use 1024 as default iodepth, but change it if
> iodepth*$(nproc) > aio-max-nr.

Thank you, applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-17 21:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 14:27 [PATCH blktests v2] block/020: dynamically change iodepth if test aio-nr lager than aio-max-nr Xiao Liang
2019-04-17 21:41 ` Omar Sandoval

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).