* [PATCH] block: Fix a comment in blk_cleanup_queue()
@ 2019-08-01 22:39 Bart Van Assche
2019-08-02 13:35 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2019-08-01 22:39 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche,
Chaitanya Kulkarni, Christoph Hellwig, Hannes Reinecke,
James Smart, Ming Lei, Jianchao Wang, Dongli Zhang
Change a reference to the legacy block layer into a reference to blk-mq.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Hannes Reinecke <hare@suse.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index d0cc6e14d2f0..5878504a29af 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -344,7 +344,8 @@ void blk_cleanup_queue(struct request_queue *q)
/*
* Drain all requests queued before DYING marking. Set DEAD flag to
- * prevent that q->request_fn() gets invoked after draining finished.
+ * prevent that blk_mq_run_hw_queues() accesses the hardware queues
+ * after draining finished.
*/
blk_freeze_queue(q);
--
2.22.0.770.g0f2c4a37fd-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Fix a comment in blk_cleanup_queue()
2019-08-01 22:39 [PATCH] block: Fix a comment in blk_cleanup_queue() Bart Van Assche
@ 2019-08-02 13:35 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-08-02 13:35 UTC (permalink / raw)
To: Bart Van Assche
Cc: linux-block, Christoph Hellwig, Chaitanya Kulkarni,
Christoph Hellwig, Hannes Reinecke, James Smart, Ming Lei,
Jianchao Wang, Dongli Zhang
On 8/1/19 4:39 PM, Bart Van Assche wrote:
> Change a reference to the legacy block layer into a reference to blk-mq.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: Fix a comment in blk_cleanup_queue()
2019-07-01 15:42 Bart Van Assche
@ 2019-07-01 15:47 ` Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2019-07-01 15:47 UTC (permalink / raw)
To: Bart Van Assche, Jens Axboe
Cc: linux-block, Christoph Hellwig, Christoph Hellwig,
Hannes Reinecke, James Smart, Ming Lei, Jianchao Wang,
Dongli Zhang
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 07/01/2019 08:42 AM, Bart Van Assche wrote:
> * prevent that blk_mq_run_hw_queues() accesses the hardware queues
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] block: Fix a comment in blk_cleanup_queue()
@ 2019-07-01 15:42 Bart Van Assche
2019-07-01 15:47 ` Chaitanya Kulkarni
0 siblings, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2019-07-01 15:42 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche,
Christoph Hellwig, Hannes Reinecke, James Smart, Ming Lei,
Jianchao Wang, Dongli Zhang
Change a reference to the legacy block layer into a reference to blk-mq.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Hannes Reinecke <hare@suse.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 2e5e677d1cee..6361419f0b6e 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -346,7 +346,8 @@ void blk_cleanup_queue(struct request_queue *q)
/*
* Drain all requests queued before DYING marking. Set DEAD flag to
- * prevent that q->request_fn() gets invoked after draining finished.
+ * prevent that blk_mq_run_hw_queues() accesses the hardware queues
+ * after draining finished.
*/
blk_freeze_queue(q);
--
2.22.0.410.gd8fdbe21b5-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-02 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-01 22:39 [PATCH] block: Fix a comment in blk_cleanup_queue() Bart Van Assche
2019-08-02 13:35 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2019-07-01 15:42 Bart Van Assche
2019-07-01 15:47 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).