From: Paolo Valente <paolo.valente@linaro.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
bfq-iosched@googlegroups.com, oleksandr@natalenko.name,
patdung100@gmail.com, cevich@redhat.com,
Paolo Valente <paolo.valente@linaro.org>
Subject: [PATCH BUGFIX V2 7/7] block, bfq: clarify the goal of bfq_split_bfqq()
Date: Mon, 3 Feb 2020 11:41:00 +0100 [thread overview]
Message-ID: <20200203104100.16965-8-paolo.valente@linaro.org> (raw)
In-Reply-To: <20200203104100.16965-1-paolo.valente@linaro.org>
The exact, general goal of the function bfq_split_bfqq() is not that
apparent. Add a comment to make it clear.
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
---
block/bfq-iosched.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index fff76c920968..8c436abfaf14 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -5979,6 +5979,8 @@ static void bfq_finish_requeue_request(struct request *rq)
}
/*
+ * Removes the association between the current task and bfqq, assuming
+ * that bic points to the bfq iocontext of the task.
* Returns NULL if a new bfqq should be allocated, or the old bfqq if this
* was the last process referring to that bfqq.
*/
--
2.20.1
next prev parent reply other threads:[~2020-02-03 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 10:40 [PATCH BUGFIX V2 0/7] block, bfq: series of fixes, and not only, for some recently reported issues Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 1/7] block, bfq: do not plug I/O for bfq_queues with no proc refs Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 2/7] block, bfq: do not insert oom queue into position tree Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 3/7] block, bfq: get extra ref to prevent a queue from being freed during a group move Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 4/7] block, bfq: extend incomplete name of field on_st Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 5/7] block, bfq: remove ifdefs from around gets/puts of bfq groups Paolo Valente
2020-02-03 10:40 ` [PATCH BUGFIX V2 6/7] block, bfq: get a ref to a group when adding it to a service tree Paolo Valente
2020-02-03 10:41 ` Paolo Valente [this message]
2020-02-03 12:18 ` [PATCH BUGFIX V2 0/7] block, bfq: series of fixes, and not only, for some recently reported issues Oleksandr Natalenko
2020-02-03 14:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203104100.16965-8-paolo.valente@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=cevich@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=patdung100@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).