From: Christoph Hellwig <hch@infradead.org>
To: Tony Asleson <tasleson@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [v5 01/12] struct device: Add function callback durable_name
Date: Tue, 29 Sep 2020 18:51:02 +0100 [thread overview]
Message-ID: <20200929175102.GA1613@infradead.org> (raw)
In-Reply-To: <20200925161929.1136806-2-tasleson@redhat.com>
Independ of my opinion on the whole scheme that I shared last time,
we really should not bloat struct device with function pointers.
On Fri, Sep 25, 2020 at 11:19:18AM -0500, Tony Asleson wrote:
> Function callback and function to be used to write a persistent
> durable name to the supplied character buffer. This will be used to add
> structured key-value data to log messages for hardware related errors
> which allows end users to correlate message and specific hardware.
>
> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---
> drivers/base/core.c | 24 ++++++++++++++++++++++++
> include/linux/device.h | 4 ++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 05d414e9e8a4..88696ade8bfc 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2489,6 +2489,30 @@ int dev_set_name(struct device *dev, const char *fmt, ...)
> }
> EXPORT_SYMBOL_GPL(dev_set_name);
>
> +/**
> + * dev_durable_name - Write "DURABLE_NAME"=<durable name> in buffer
> + * @dev: device
> + * @buffer: character buffer to write results
> + * @len: length of buffer
> + * @return: Number of bytes written to buffer
> + */
> +int dev_durable_name(const struct device *dev, char *buffer, size_t len)
> +{
> + int tmp, dlen;
> +
> + if (dev && dev->durable_name) {
> + tmp = snprintf(buffer, len, "DURABLE_NAME=");
> + if (tmp < len) {
> + dlen = dev->durable_name(dev, buffer + tmp,
> + len - tmp);
> + if (dlen > 0 && ((dlen + tmp) < len))
> + return dlen + tmp;
> + }
> + }
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(dev_durable_name);
> +
> /**
> * device_to_dev_kobj - select a /sys/dev/ directory for the device
> * @dev: device
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 5efed864b387..074125999dd8 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -614,6 +614,8 @@ struct device {
> struct iommu_group *iommu_group;
> struct dev_iommu *iommu;
>
> + int (*durable_name)(const struct device *dev, char *buff, size_t len);
> +
> bool offline_disabled:1;
> bool offline:1;
> bool of_node_reused:1;
> @@ -655,6 +657,8 @@ static inline const char *dev_name(const struct device *dev)
> extern __printf(2, 3)
> int dev_set_name(struct device *dev, const char *name, ...);
>
> +int dev_durable_name(const struct device *d, char *buffer, size_t len);
> +
> #ifdef CONFIG_NUMA
> static inline int dev_to_node(struct device *dev)
> {
> --
> 2.26.2
>
---end quoted text---
next prev parent reply other threads:[~2020-09-29 17:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:19 [v5 00/12] Add persistent durable identifier to storage log messages Tony Asleson
2020-09-25 16:19 ` [v5 01/12] struct device: Add function callback durable_name Tony Asleson
2020-09-26 9:08 ` Sergei Shtylyov
2020-09-27 14:22 ` Tony Asleson
2020-09-27 16:15 ` Sergei Shtylyov
2020-09-29 17:51 ` Christoph Hellwig [this message]
2020-09-29 18:04 ` Greg Kroah-Hartman
2020-09-29 22:04 ` Tony Asleson
2020-09-30 7:38 ` Greg Kroah-Hartman
2020-09-30 7:40 ` Greg Kroah-Hartman
2020-09-30 14:35 ` Tony Asleson
2020-10-01 11:48 ` Greg Kroah-Hartman
2020-10-07 20:10 ` Tony Asleson
2020-10-08 4:48 ` Greg Kroah-Hartman
2020-10-08 20:49 ` Martin K. Petersen
2020-10-08 5:54 ` Hannes Reinecke
2020-10-08 6:22 ` Finn Thain
2020-09-25 16:19 ` [v5 02/12] create_syslog_header: Add durable name Tony Asleson
2020-09-25 16:19 ` [v5 03/12] dev_vprintk_emit: Increase hdr size Tony Asleson
2020-09-25 16:19 ` [v5 04/12] scsi: Add durable_name for dev_printk Tony Asleson
2020-09-25 16:19 ` [v5 05/12] nvme: Add durable name " Tony Asleson
2020-09-25 16:19 ` [v5 06/12] libata: Add ata_scsi_durable_name Tony Asleson
2020-09-25 16:19 ` [v5 07/12] libata: Make ata_scsi_durable_name static Tony Asleson
2020-09-26 8:40 ` Sergei Shtylyov
2020-09-26 14:17 ` Tony Asleson
2020-09-26 15:57 ` James Bottomley
2020-09-28 20:35 ` Tony Asleson
2020-09-25 16:19 ` [v5 08/12] Add durable_name_printk Tony Asleson
2020-09-26 23:53 ` Randy Dunlap
2020-09-28 15:52 ` Tony Asleson
2020-09-28 17:32 ` Randy Dunlap
2020-09-25 16:19 ` [v5 09/12] libata: use durable_name_printk Tony Asleson
2020-09-25 16:19 ` [v5 10/12] Add durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 11/12] print_req_error: Use durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 12/12] buffer_io_error: " Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929175102.GA1613@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tasleson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).