linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: tasleson@redhat.com, Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	linux-ide@vger.kernel.org
Subject: Re: [v5 07/12] libata: Make ata_scsi_durable_name static
Date: Sat, 26 Sep 2020 08:57:42 -0700	[thread overview]
Message-ID: <eb1216d26b3baaf1bea2562ae772f968c36f52ba.camel@HansenPartnership.com> (raw)
In-Reply-To: <b95e0b6f-dcc1-8032-ebcd-29ae594fcbaf@redhat.com>

On Sat, 2020-09-26 at 09:17 -0500, Tony Asleson wrote:
> On 9/26/20 3:40 AM, Sergei Shtylyov wrote:
> > Hello!
> > 
> > On 25.09.2020 19:19, Tony Asleson wrote:
> > 
> > > Signed-off-by: Tony Asleson <tasleson@redhat.com>
> > > Signed-off-by: kernel test robot <lkp@intel.com>
> > > ---
> > >   drivers/ata/libata-scsi.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-
> > > scsi.c
> > > index 194dac7dbdca..13a58ed7184c 100644
> > > --- a/drivers/ata/libata-scsi.c
> > > +++ b/drivers/ata/libata-scsi.c
> > > @@ -1086,7 +1086,7 @@ int ata_scsi_dev_config(struct scsi_device
> > > *sdev, struct ata_device *dev)
> > >       return 0;
> > >   }
> > >   -int ata_scsi_durable_name(const struct device *dev, char *buf,
> > > size_t len)
> > > +static int ata_scsi_durable_name(const struct device *dev, char
> > > *buf,
> > > size_t len)
> > 
> >    Why not do it in patch #6 -- when introducing the function?
> 
> This issue was found by the intel kernel test robot in v4 patch
> series. I thought it was better to have a separate commit with the
> correction that matched it's signed off.  Maybe that's not the
> correct approach?

No ... while a patch is being reviewed the purpose of review is to make
it better by folding in all the comments.  It then gets a changelog put
below the 

---

v5: made X function static

So people can follow how it has evolved.  This is all actually
described in Documentation/submitting-patches.

James



  reply	other threads:[~2020-09-26 16:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 16:19 [v5 00/12] Add persistent durable identifier to storage log messages Tony Asleson
2020-09-25 16:19 ` [v5 01/12] struct device: Add function callback durable_name Tony Asleson
2020-09-26  9:08   ` Sergei Shtylyov
2020-09-27 14:22     ` Tony Asleson
2020-09-27 16:15       ` Sergei Shtylyov
2020-09-29 17:51   ` Christoph Hellwig
2020-09-29 18:04     ` Greg Kroah-Hartman
2020-09-29 22:04       ` Tony Asleson
2020-09-30  7:38         ` Greg Kroah-Hartman
2020-09-30  7:40           ` Greg Kroah-Hartman
2020-09-30 14:35           ` Tony Asleson
2020-10-01 11:48             ` Greg Kroah-Hartman
2020-10-07 20:10               ` Tony Asleson
2020-10-08  4:48                 ` Greg Kroah-Hartman
2020-10-08 20:49                   ` Martin K. Petersen
2020-10-08  5:54                 ` Hannes Reinecke
2020-10-08  6:22                 ` Finn Thain
2020-09-25 16:19 ` [v5 02/12] create_syslog_header: Add durable name Tony Asleson
2020-09-25 16:19 ` [v5 03/12] dev_vprintk_emit: Increase hdr size Tony Asleson
2020-09-25 16:19 ` [v5 04/12] scsi: Add durable_name for dev_printk Tony Asleson
2020-09-25 16:19 ` [v5 05/12] nvme: Add durable name " Tony Asleson
2020-09-25 16:19 ` [v5 06/12] libata: Add ata_scsi_durable_name Tony Asleson
2020-09-25 16:19 ` [v5 07/12] libata: Make ata_scsi_durable_name static Tony Asleson
2020-09-26  8:40   ` Sergei Shtylyov
2020-09-26 14:17     ` Tony Asleson
2020-09-26 15:57       ` James Bottomley [this message]
2020-09-28 20:35     ` Tony Asleson
2020-09-25 16:19 ` [v5 08/12] Add durable_name_printk Tony Asleson
2020-09-26 23:53   ` Randy Dunlap
2020-09-28 15:52     ` Tony Asleson
2020-09-28 17:32       ` Randy Dunlap
2020-09-25 16:19 ` [v5 09/12] libata: use durable_name_printk Tony Asleson
2020-09-25 16:19 ` [v5 10/12] Add durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 11/12] print_req_error: Use durable_name_printk_ratelimited Tony Asleson
2020-09-25 16:19 ` [v5 12/12] buffer_io_error: " Tony Asleson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb1216d26b3baaf1bea2562ae772f968c36f52ba.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sergei.shtylyov@gmail.com \
    --cc=tasleson@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).