* [PATCH V3 0/9] nvmet: add ZBD backend support
@ 2020-12-01 4:14 Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 1/9] block: export __bio_iov_append_get_pages() Chaitanya Kulkarni
` (9 more replies)
0 siblings, 10 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Hi,
NVMeOF Host is capable of handling the NVMe Protocol based Zoned Block
Devices (ZBD) in the ZNS mode with the passthru backend. There is no
support for a generic block device backend to handle the ZBD devices
which are not NVMe devices.
This adds support to export the ZBD drives (which are not NVMe drives)
to host from the target with NVMeOF using the host side ZNS interface.
The patch series is generated in bottom-top manner where, it first adds
prep patch and ZNS command-specific handlers on the top of genblk and
updates the data structures, then one by one it wires up the admin cmds
in the order host calls them in namespace initializing sequence. Once
everything is ready, it wires-up the I/O command handlers. See below for
patch-series overview.
I've tested the ZoneFS testcases with the null_blk memory backed NVMeOF
namespace with nvme-loop transport. The only testcase is failing in #12
on both null blk and NVMeOF ZBD backe by null_blk.
It uses invalid block device to format zonefs and doesn't do anyting
with the input device, still looking into it.
Regards,
Chaitanya
Changes from V2:-
1. Move conventional zone bitmap check into
nvmet_bdev_validate_zns_zones().
2. Don't use report zones call to check the runt zone.
3. Trim nvmet_zasl() helper.
4. Fix typo in the nvmet_zns_update_zasl().
5. Remove the comment and fix the mdts calculation in
nvmet_execute_identify_cns_cs_ctrl().
6. Use u64 for bufsize in nvmet_bdev_execute_zone_mgmt_recv().
7. Remove nvmet_zones_to_desc_size() and fix the nr_zones
calculation.
8. Remove the op variable in nvmet_bdev_execute_zone_append().
9. Fix the nr_zones calculation nvmet_bdev_execute_zone_mgmt_recv().
10. Update cover letter subject.
Changes from V1:-
1. Remove the nvmet-$(CONFIG_BLK_DEV_ZONED) += zns.o.
2. Mark helpers inline.
3. Fix typos in the comments and update the comments.
4. Get rid of the curly brackets.
5. Don't allow drives with last smaller zones.
6. Calculate the zasl as a function of ax_zone_append_sectors,
bio_max_pages so we don't have to split the bio.
7. Add global subsys->zasl and update the zasl when new namespace
is enabled.
8. Rmove the loop in the nvmet_bdev_execute_zone_mgmt_recv() and
move functionality in to the report zone callback.
9. Add goto for default case in nvmet_bdev_execute_zone_mgmt_send().
10. Allocate the zones buffer with zones size instead of bdev nr_zones.
Chaitanya Kulkarni (9):
block: export __bio_iov_append_get_pages()
Prep patch needed for implementing Zone Append.
nvmet: add ZNS support for bdev-ns
Core Command handlers and various helpers for ZBD backend which
will be called by target-core/target-admin etc.
nvmet: trim down id-desclist to use req->ns
Cleanup needed to avoid the code repetation for passing extra
function parameters for ZBD backend handlers.
nvmet: add NVME_CSI_ZNS in ns-desc for zbdev
Allows host to identify zoned namesapce.
nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev
Allows host to identify controller with the ZBD-ZNS.
nvmet: add cns-cs-ns in id-ctrl for ZNS bdev
Allows host to identify namespace with the ZBD-ZNS.
nvmet: add zns cmd effects to support zbdev
Allows host to support the ZNS commands when zoned-blkdev is
selected.
nvmet: add zns bdev config support
Allows user to override any target namespace attributes for
ZBD.
nvmet: add ZNS based I/O cmds handlers
Handlers for Zone-Mgmt-Send/Zone-Mgmt-Recv/Zone-Append
block/bio.c | 3 +-
drivers/nvme/target/Makefile | 2 +-
drivers/nvme/target/admin-cmd.c | 38 ++-
drivers/nvme/target/io-cmd-bdev.c | 12 +
drivers/nvme/target/io-cmd-file.c | 2 +-
drivers/nvme/target/nvmet.h | 19 ++
drivers/nvme/target/zns.c | 426 ++++++++++++++++++++++++++++++
include/linux/bio.h | 1 +
8 files changed, 487 insertions(+), 16 deletions(-)
create mode 100644 drivers/nvme/target/zns.c
# for i in nvme1n1 nullb1 ; do ./zonefs-tests.sh /dev/$i; done
Gathering information on /dev/nvme1n1...
zonefs-tests on /dev/nvme1n1:
4 zones (0 conventional zones, 4 sequential zones)
524288 512B sectors zone size (256 MiB)
1 max open zones
Running tests
Test 0010: mkzonefs (options) ... PASS
Test 0011: mkzonefs (force format) ... PASS
*Test 0012: mkzonefs (invalid device) ... FAIL*
Test 0013: mkzonefs (super block zone state) ... PASS
Test 0020: mount (default) ... PASS
Test 0021: mount (invalid device) ... PASS
Test 0022: mount (check mount directory sub-directories) ... PASS
Test 0023: mount (options) ... PASS
Test 0030: Number of files (default) ... PASS
Test 0031: Number of files (aggr_cnv) ... skip
Test 0032: Number of files using stat (default) ... PASS
Test 0033: Number of files using stat (aggr_cnv) ... PASS
Test 0034: Number of blocks using stat (default) ... PASS
Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
Test 0040: Files permissions (default) ... PASS
Test 0041: Files permissions (aggr_cnv) ... skip
Test 0042: Files permissions (set value) ... PASS
Test 0043: Files permissions (set value + aggr_cnv) ... skip
Test 0050: Files owner (default) ... PASS
Test 0051: Files owner (aggr_cnv) ... skip
Test 0052: Files owner (set value) ... PASS
Test 0053: Files owner (set value + aggr_cnv) ... skip
Test 0060: Files size (default) ... PASS
Test 0061: Files size (aggr_cnv) ... skip
Test 0070: Conventional file truncate ... skip
Test 0071: Conventional file truncate (aggr_cnv) ... skip
Test 0072: Conventional file unlink ... skip
Test 0073: Conventional file unlink (aggr_cnv) ... skip
Test 0074: Conventional file random write ... skip
Test 0075: Conventional file random write (direct) ... skip
Test 0076: Conventional file random write (aggr_cnv) ... skip
Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
Test 0078: Conventional file mmap read/write ... skip
Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
Test 0080: Sequential file truncate ... PASS
Test 0081: Sequential file unlink ... PASS
Test 0082: Sequential file buffered write IO ... PASS
Test 0083: Sequential file overwrite ... PASS
Test 0084: Sequential file unaligned write (sync IO) ... PASS
Test 0085: Sequential file unaligned write (async IO) ... PASS
Test 0086: Sequential file append (sync) ... PASS
Test 0087: Sequential file append (async) ... PASS
Test 0088: Sequential file random read ... PASS
Test 0089: Sequential file mmap read/write ... PASS
Test 0090: sequential file 4K synchronous write ... PASS
Test 0091: Sequential file large synchronous write ... PASS
45 / 46 tests passed
Gathering information on /dev/nullb1...
zonefs-tests on /dev/nullb1:
4 zones (0 conventional zones, 4 sequential zones)
524288 512B sectors zone size (256 MiB)
0 max open zones
Running tests
Test 0010: mkzonefs (options) ... PASS
Test 0011: mkzonefs (force format) ... PASS
*Test 0012: mkzonefs (invalid device) ... FAIL*
Test 0013: mkzonefs (super block zone state) ... PASS
Test 0020: mount (default) ... PASS
Test 0021: mount (invalid device) ... PASS
Test 0022: mount (check mount directory sub-directories) ... PASS
Test 0023: mount (options) ... PASS
Test 0030: Number of files (default) ... PASS
Test 0031: Number of files (aggr_cnv) ... skip
Test 0032: Number of files using stat (default) ... PASS
Test 0033: Number of files using stat (aggr_cnv) ... PASS
Test 0034: Number of blocks using stat (default) ... PASS
Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
Test 0040: Files permissions (default) ... PASS
Test 0041: Files permissions (aggr_cnv) ... skip
Test 0042: Files permissions (set value) ... PASS
Test 0043: Files permissions (set value + aggr_cnv) ... skip
Test 0050: Files owner (default) ... PASS
Test 0051: Files owner (aggr_cnv) ... skip
Test 0052: Files owner (set value) ... PASS
Test 0053: Files owner (set value + aggr_cnv) ... skip
Test 0060: Files size (default) ... PASS
Test 0061: Files size (aggr_cnv) ... skip
Test 0070: Conventional file truncate ... skip
Test 0071: Conventional file truncate (aggr_cnv) ... skip
Test 0072: Conventional file unlink ... skip
Test 0073: Conventional file unlink (aggr_cnv) ... skip
Test 0074: Conventional file random write ... skip
Test 0075: Conventional file random write (direct) ... skip
Test 0076: Conventional file random write (aggr_cnv) ... skip
Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
Test 0078: Conventional file mmap read/write ... skip
Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
Test 0080: Sequential file truncate ... PASS
Test 0081: Sequential file unlink ... PASS
Test 0082: Sequential file buffered write IO ... PASS
Test 0083: Sequential file overwrite ... PASS
Test 0084: Sequential file unaligned write (sync IO) ... PASS
Test 0085: Sequential file unaligned write (async IO) ... PASS
Test 0086: Sequential file append (sync) ... PASS
Test 0087: Sequential file append (async) ... PASS
Test 0088: Sequential file random read ... PASS
Test 0089: Sequential file mmap read/write ... PASS
Test 0090: sequential file 4K synchronous write ... PASS
Test 0091: Sequential file large synchronous write ... PASS
45 / 46 tests passed
#
# for i in nvme1n1 nullb1 ; do ./zonefs-tests.sh -t 0012 /dev/$i; done
Gathering information on /dev/nvme1n1...
zonefs-tests on /dev/nvme1n1:
4 zones (0 conventional zones, 4 sequential zones)
524288 512B sectors zone size (256 MiB)
1 max open zones
Running tests
Test 0012: mkzonefs (invalid device) ... FAIL
0 / 1 tests passed
Gathering information on /dev/nullb1...
zonefs-tests on /dev/nullb1:
4 zones (0 conventional zones, 4 sequential zones)
524288 512B sectors zone size (256 MiB)
0 max open zones
Running tests
Test 0012: mkzonefs (invalid device) ... FAIL
0 / 1 tests passed
# cat nvme1n1-zonefs-tests.log
## Test scripts/0012.sh (mkzonefs (invalid device))
/dev/console is not a block device
/dev/nullb4
/dev/nullb4: 524288000 512-byte sectors (250 GiB)
Host-managed device
1000 zones of 524288 512-byte sectors (256 MiB)
0 conventional zones, 1000 sequential zones
0 read-only zones, 0 offline zones
Format:
999 usable zones
Aggregate conventional zones: disabled
File UID: 0
File GID: 0
File access permissions: 640
FS UUID: 339b07fe-ebbb-4876-be16-5a887384f349
Resetting sequential zones
Writing super block
--> SUCCESS (should FAIL)
FAILED
# cat nullb1-zonefs-tests.log
## Test scripts/0012.sh (mkzonefs (invalid device))
/dev/console is not a block device
/dev/nullb5
/dev/nullb5: 524288000 512-byte sectors (250 GiB)
Host-managed device
1000 zones of 524288 512-byte sectors (256 MiB)
0 conventional zones, 1000 sequential zones
0 read-only zones, 0 offline zones
Format:
999 usable zones
Aggregate conventional zones: disabled
File UID: 0
File GID: 0
File access permissions: 640
FS UUID: 591f1476-47c6-4d81-b0e8-7c82d4c5b657
Resetting sequential zones
Writing super block
--> SUCCESS (should FAIL)
FAILED
--
2.22.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V3 1/9] block: export __bio_iov_append_get_pages()
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 2/9] nvmet: add ZNS support for bdev-ns Chaitanya Kulkarni
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
In this prep patch we exoprt the __bio_iov_append_get_pages() so that
NVMeOF target can use the core logic of building Zone Append bios for
REQ_OP_ZONE_APPEND without repeating the code.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
block/bio.c | 3 ++-
include/linux/bio.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index fa01bef35bb1..de356fa28315 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1033,7 +1033,7 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
return 0;
}
-static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
+int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
{
unsigned short nr_pages = bio->bi_max_vecs - bio->bi_vcnt;
unsigned short entries_left = bio->bi_max_vecs - bio->bi_vcnt;
@@ -1079,6 +1079,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
iov_iter_advance(iter, size - left);
return ret;
}
+EXPORT_SYMBOL_GPL(__bio_iov_append_get_pages);
/**
* bio_iov_iter_get_pages - add user or kernel pages to a bio
diff --git a/include/linux/bio.h b/include/linux/bio.h
index c6d765382926..47247c1b0b85 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -446,6 +446,7 @@ bool __bio_try_merge_page(struct bio *bio, struct page *page,
unsigned int len, unsigned int off, bool *same_page);
void __bio_add_page(struct bio *bio, struct page *page,
unsigned int len, unsigned int off);
+int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter);
int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter);
void bio_release_pages(struct bio *bio, bool mark_dirty);
extern void bio_set_pages_dirty(struct bio *bio);
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 2/9] nvmet: add ZNS support for bdev-ns
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 1/9] block: export __bio_iov_append_get_pages() Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 3/9] nvmet: trim down id-desclist to use req->ns Chaitanya Kulkarni
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Add zns-bdev-config, id-ctrl, id-ns, zns-cmd-effects, zone-mgmt-send,
zone-mgmt-recv and zone-append handlers for NVMeOF target to enable ZNS
support for bdev.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/Makefile | 2 +-
drivers/nvme/target/admin-cmd.c | 4 +-
drivers/nvme/target/io-cmd-file.c | 2 +-
drivers/nvme/target/nvmet.h | 19 ++
drivers/nvme/target/zns.c | 426 ++++++++++++++++++++++++++++++
5 files changed, 449 insertions(+), 4 deletions(-)
create mode 100644 drivers/nvme/target/zns.c
diff --git a/drivers/nvme/target/Makefile b/drivers/nvme/target/Makefile
index ebf91fc4c72e..d050f829b43a 100644
--- a/drivers/nvme/target/Makefile
+++ b/drivers/nvme/target/Makefile
@@ -10,7 +10,7 @@ obj-$(CONFIG_NVME_TARGET_FCLOOP) += nvme-fcloop.o
obj-$(CONFIG_NVME_TARGET_TCP) += nvmet-tcp.o
nvmet-y += core.o configfs.o admin-cmd.o fabrics-cmd.o \
- discovery.o io-cmd-file.o io-cmd-bdev.o
+ zns.o discovery.o io-cmd-file.o io-cmd-bdev.o
nvmet-$(CONFIG_NVME_TARGET_PASSTHRU) += passthru.o
nvme-loop-y += loop.o
nvmet-rdma-y += rdma.o
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index dca34489a1dc..509fd8dcca0c 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -579,8 +579,8 @@ static void nvmet_execute_identify_nslist(struct nvmet_req *req)
nvmet_req_complete(req, status);
}
-static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
- void *id, off_t *off)
+u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
+ void *id, off_t *off)
{
struct nvme_ns_id_desc desc = {
.nidt = type,
diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c
index 0abbefd9925e..2bd10960fa50 100644
--- a/drivers/nvme/target/io-cmd-file.c
+++ b/drivers/nvme/target/io-cmd-file.c
@@ -89,7 +89,7 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
return ret;
}
-static void nvmet_file_init_bvec(struct bio_vec *bv, struct scatterlist *sg)
+void nvmet_file_init_bvec(struct bio_vec *bv, struct scatterlist *sg)
{
bv->bv_page = sg_page(sg);
bv->bv_offset = sg->offset;
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index 592763732065..eee7866ae512 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -81,6 +81,10 @@ struct nvmet_ns {
struct pci_dev *p2p_dev;
int pi_type;
int metadata_size;
+#ifdef CONFIG_BLK_DEV_ZONED
+ struct nvme_id_ns_zns id_zns;
+ unsigned int zasl;
+#endif
};
static inline struct nvmet_ns *to_nvmet_ns(struct config_item *item)
@@ -251,6 +255,10 @@ struct nvmet_subsys {
unsigned int admin_timeout;
unsigned int io_timeout;
#endif /* CONFIG_NVME_TARGET_PASSTHRU */
+
+#ifdef CONFIG_BLK_DEV_ZONED
+ struct nvme_id_ctrl_zns id_ctrl_zns;
+#endif
};
static inline struct nvmet_subsys *to_subsys(struct config_item *item)
@@ -603,4 +611,15 @@ static inline bool nvmet_ns_has_pi(struct nvmet_ns *ns)
return ns->pi_type && ns->metadata_size == sizeof(struct t10_pi_tuple);
}
+void nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req);
+void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req);
+u16 nvmet_process_zns_cis(struct nvmet_req *req, off_t *off);
+bool nvmet_bdev_zns_enable(struct nvmet_ns *ns);
+void nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req);
+void nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req);
+void nvmet_bdev_execute_zone_append(struct nvmet_req *req);
+void nvmet_zns_add_cmd_effects(struct nvme_effects_log *log);
+u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
+ void *id, off_t *off);
+void nvmet_file_init_bvec(struct bio_vec *bv, struct scatterlist *sg);
#endif /* _NVMET_H */
diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
new file mode 100644
index 000000000000..f6927f7ef4d2
--- /dev/null
+++ b/drivers/nvme/target/zns.c
@@ -0,0 +1,426 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * NVMe ZNS-ZBD command implementation.
+ * Copyright (c) 2020-2021 HGST, a Western Digital Company.
+ */
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/uio.h>
+#include <linux/nvme.h>
+#include <linux/xarray.h>
+#include <linux/blkdev.h>
+#include <linux/module.h>
+#include "nvmet.h"
+
+#ifdef CONFIG_BLK_DEV_ZONED
+#define NVMET_MPSMIN_SHIFT 12
+
+static u16 nvmet_bdev_zns_checks(struct nvmet_req *req)
+{
+ u16 status = 0;
+
+ if (!bdev_is_zoned(req->ns->bdev)) {
+ status = NVME_SC_INVALID_NS | NVME_SC_DNR;
+ goto out;
+ }
+
+ if (req->cmd->zmr.zra != NVME_ZRA_ZONE_REPORT) {
+ status = NVME_SC_INVALID_FIELD;
+ goto out;
+ }
+
+ if (req->cmd->zmr.zrasf != NVME_ZRASF_ZONE_REPORT_ALL) {
+ status = NVME_SC_INVALID_FIELD;
+ goto out;
+ }
+
+ if (req->cmd->zmr.pr != NVME_REPORT_ZONE_PARTIAL)
+ status = NVME_SC_INVALID_FIELD;
+out:
+ return status;
+}
+
+static inline struct block_device *nvmet_bdev(struct nvmet_req *req)
+{
+ return req->ns->bdev;
+}
+
+static inline u64 nvmet_sect_to_lba(struct nvmet_ns *ns, sector_t sect)
+{
+ return sect >> (ns->blksize_shift - SECTOR_SHIFT);
+}
+
+static inline sector_t nvmet_lba_to_sect(struct nvmet_ns *ns, __le64 lba)
+{
+ return le64_to_cpu(lba) << (ns->blksize_shift - SECTOR_SHIFT);
+}
+
+/*
+ * ZNS related command implementation and helpers.
+ */
+
+u16 nvmet_process_zns_cis(struct nvmet_req *req, off_t *off)
+{
+ u16 nvme_cis_zns = NVME_CSI_ZNS;
+
+ if (!bdev_is_zoned(nvmet_bdev(req)))
+ return NVME_SC_SUCCESS;
+
+ return nvmet_copy_ns_identifier(req, NVME_NIDT_CSI, NVME_NIDT_CSI_LEN,
+ &nvme_cis_zns, off);
+}
+
+void nvmet_zns_add_cmd_effects(struct nvme_effects_log *log)
+{
+ log->iocs[nvme_cmd_zone_append] = cpu_to_le32(1 << 0);
+ log->iocs[nvme_cmd_zone_mgmt_send] = cpu_to_le32(1 << 0);
+ log->iocs[nvme_cmd_zone_mgmt_recv] = cpu_to_le32(1 << 0);
+}
+
+static inline bool nvmet_bdev_validate_zns_zones(struct nvmet_ns *ns)
+{
+ if (ns->bdev->bd_disk->queue->conv_zones_bitmap) {
+ pr_err("block devices with conventional zones are not supported.");
+ return false;
+ }
+
+ return !(get_capacity(ns->bdev->bd_disk) &
+ (bdev_zone_sectors(ns->bdev) - 1));
+}
+
+static inline u8 nvmet_zasl(unsigned int zone_append_sects)
+{
+ /*
+ * Zone Append Size Limit is the value experessed in the units
+ * of minimum memory page size (i.e. 12) and is reported power of 2.
+ */
+ return ilog2((zone_append_sects << 9) >> NVMET_MPSMIN_SHIFT);
+}
+
+static inline void nvmet_zns_update_zasl(struct nvmet_ns *ns)
+{
+ u8 bio_max_zasl = nvmet_zasl((BIO_MAX_PAGES * PAGE_SIZE) >> 9);
+ struct request_queue *q = ns->bdev->bd_disk->queue;
+ struct nvmet_ns *ins;
+ unsigned long idx;
+ u8 min_zasl;
+
+ /*
+ * Calculate new ctrl->zasl value when enabling the new ns. This value
+ * has to be the minimum of the max_zone_append values from available
+ * namespaces.
+ */
+ min_zasl = ns->zasl = nvmet_zasl(queue_max_zone_append_sectors(q));
+
+ xa_for_each(&(ns->subsys->namespaces), idx, ins) {
+ struct request_queue *iq = ins->bdev->bd_disk->queue;
+ unsigned int imax_za_sects = queue_max_zone_append_sectors(iq);
+ u8 izasl = nvmet_zasl(imax_za_sects);
+
+ if (!bdev_is_zoned(ins->bdev))
+ continue;
+
+ min_zasl = min_zasl > izasl ? izasl : min_zasl;
+ }
+
+ ns->subsys->id_ctrl_zns.zasl = min_t(u8, min_zasl, bio_max_zasl);
+}
+
+bool nvmet_bdev_zns_enable(struct nvmet_ns *ns)
+{
+ if (!nvmet_bdev_validate_zns_zones(ns))
+ return false;
+
+ /*
+ * For ZBC and ZAC devices, writes into sequential zones must be aligned
+ * to the device physical block size. So use this value as the logical
+ * block size to avoid errors.
+ */
+ ns->blksize_shift = blksize_bits(bdev_physical_block_size(ns->bdev));
+
+ nvmet_zns_update_zasl(ns);
+
+ return true;
+}
+
+/*
+ * ZNS related Admin and I/O command handlers.
+ */
+void nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req)
+{
+ u8 zasl = req->sq->ctrl->subsys->id_ctrl_zns.zasl;
+ struct nvmet_ctrl *ctrl = req->sq->ctrl;
+ struct nvme_id_ctrl_zns *id;
+ u16 status;
+
+ id = kzalloc(sizeof(*id), GFP_KERNEL);
+ if (!id) {
+ status = NVME_SC_INTERNAL;
+ goto out;
+ }
+
+ if (ctrl->ops->get_mdts)
+ id->zasl = min_t(u8, ctrl->ops->get_mdts(ctrl), zasl);
+ else
+ id->zasl = zasl;
+
+ status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));
+
+ kfree(id);
+out:
+ nvmet_req_complete(req, status);
+}
+
+void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req)
+{
+ struct nvme_id_ns_zns *id_zns;
+ u16 status = 0;
+ u64 zsze;
+
+ if (le32_to_cpu(req->cmd->identify.nsid) == NVME_NSID_ALL) {
+ req->error_loc = offsetof(struct nvme_identify, nsid);
+ status = NVME_SC_INVALID_NS | NVME_SC_DNR;
+ goto out;
+ }
+
+ id_zns = kzalloc(sizeof(*id_zns), GFP_KERNEL);
+ if (!id_zns) {
+ status = NVME_SC_INTERNAL;
+ goto out;
+ }
+
+ req->ns = nvmet_find_namespace(req->sq->ctrl, req->cmd->identify.nsid);
+ if (!req->ns) {
+ status = NVME_SC_INTERNAL;
+ goto done;
+ }
+
+ if (!bdev_is_zoned(nvmet_bdev(req))) {
+ req->error_loc = offsetof(struct nvme_identify, nsid);
+ status = NVME_SC_INVALID_NS | NVME_SC_DNR;
+ goto done;
+ }
+
+ nvmet_ns_revalidate(req->ns);
+ zsze = (bdev_zone_sectors(nvmet_bdev(req)) << 9) >>
+ req->ns->blksize_shift;
+ id_zns->lbafe[0].zsze = cpu_to_le64(zsze);
+ id_zns->mor = cpu_to_le32(bdev_max_open_zones(nvmet_bdev(req)));
+ id_zns->mar = cpu_to_le32(bdev_max_active_zones(nvmet_bdev(req)));
+
+done:
+ status = nvmet_copy_to_sgl(req, 0, id_zns, sizeof(*id_zns));
+ kfree(id_zns);
+out:
+ nvmet_req_complete(req, status);
+}
+
+struct nvmet_report_zone_data {
+ struct nvmet_ns *ns;
+ struct nvme_zone_report *rz;
+};
+
+static int nvmet_bdev_report_zone_cb(struct blk_zone *z, unsigned int idx,
+ void *data)
+{
+ struct nvmet_report_zone_data *report_zone_data = data;
+ struct nvme_zone_descriptor *entries = report_zone_data->rz->entries;
+ struct nvmet_ns *ns = report_zone_data->ns;
+
+ entries[idx].zcap = cpu_to_le64(nvmet_sect_to_lba(ns, z->capacity));
+ entries[idx].zslba = cpu_to_le64(nvmet_sect_to_lba(ns, z->start));
+ entries[idx].wp = cpu_to_le64(nvmet_sect_to_lba(ns, z->wp));
+ entries[idx].za = z->reset ? 1 << 2 : 0;
+ entries[idx].zt = z->type;
+ entries[idx].zs = z->cond << 4;
+
+ return 0;
+}
+
+void nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req)
+{
+ u64 bufsize = (le32_to_cpu(req->cmd->zmr.numd) + 1) << 2;
+ struct nvmet_report_zone_data data = { .ns = req->ns };
+ struct nvme_zone_mgmt_recv_cmd *zmr = &req->cmd->zmr;
+ sector_t sect = nvmet_lba_to_sect(req->ns, le64_to_cpu(zmr->slba));
+ unsigned int nr_zones;
+ int reported_zones;
+ u16 status;
+
+ nr_zones = (bufsize - sizeof(struct nvme_zone_report)) /
+ sizeof(struct nvme_zone_descriptor);
+
+ status = nvmet_bdev_zns_checks(req);
+ if (status)
+ goto out;
+
+ data.rz = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY);
+ if (!data.rz) {
+ status = NVME_SC_INTERNAL;
+ goto out;
+ }
+
+ reported_zones = blkdev_report_zones(nvmet_bdev(req), sect, nr_zones,
+ nvmet_bdev_report_zone_cb,
+ &data);
+ if (reported_zones < 0) {
+ status = NVME_SC_INTERNAL;
+ goto out_free_report_zones;
+ }
+
+ data.rz->nr_zones = cpu_to_le64(reported_zones);
+
+ status = nvmet_copy_to_sgl(req, 0, data.rz, bufsize);
+
+out_free_report_zones:
+ kvfree(data.rz);
+out:
+ nvmet_req_complete(req, status);
+}
+
+void nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req)
+{
+ sector_t nr_sect = bdev_zone_sectors(nvmet_bdev(req));
+ struct nvme_zone_mgmt_send_cmd *c = &req->cmd->zms;
+ enum req_opf op = REQ_OP_LAST;
+ u16 status = NVME_SC_SUCCESS;
+ sector_t sect;
+ int ret;
+
+ sect = nvmet_lba_to_sect(req->ns, le64_to_cpu(req->cmd->zms.slba));
+
+ if (c->select_all)
+ nr_sect = get_capacity(nvmet_bdev(req)->bd_disk);
+
+ switch (c->zsa) {
+ case NVME_ZONE_OPEN:
+ op = REQ_OP_ZONE_OPEN;
+ break;
+ case NVME_ZONE_CLOSE:
+ op = REQ_OP_ZONE_CLOSE;
+ break;
+ case NVME_ZONE_FINISH:
+ op = REQ_OP_ZONE_FINISH;
+ break;
+ case NVME_ZONE_RESET:
+ op = REQ_OP_ZONE_RESET;
+ break;
+ default:
+ status = NVME_SC_INVALID_FIELD;
+ goto out;
+ }
+
+ ret = blkdev_zone_mgmt(nvmet_bdev(req), op, sect, nr_sect, GFP_KERNEL);
+ if (ret)
+ status = NVME_SC_INTERNAL;
+
+out:
+ nvmet_req_complete(req, status);
+}
+
+void nvmet_bdev_execute_zone_append(struct nvmet_req *req)
+{
+ unsigned long bv_cnt = req->sg_cnt;
+ u64 slba = le64_to_cpu(req->cmd->rw.slba);
+ sector_t sect = nvmet_lba_to_sect(req->ns, slba);
+ u16 status = NVME_SC_SUCCESS;
+ size_t mapped_data_len = 0;
+ int sg_cnt = req->sg_cnt;
+ struct scatterlist *sg;
+ struct iov_iter from;
+ struct bio_vec *bvec;
+ size_t mapped_cnt;
+ struct bio *bio;
+ int ret;
+
+ if (!nvmet_check_transfer_len(req, nvmet_rw_data_len(req)))
+ return;
+
+ /*
+ * When setting the ctrl->zasl we consider the BIO_MAX_PAGES so that we
+ * don't have to split the bio, i.e. we shouldn't get
+ * sg_cnt > BIO_MAX_PAGES since zasl on the host will limit the I/Os
+ * with the size that considers the BIO_MAX_PAGES.
+ */
+ if (!req->sg_cnt)
+ goto out;
+
+ if (WARN_ON(req->sg_cnt > BIO_MAX_PAGES)) {
+ status = NVME_SC_INTERNAL | NVME_SC_DNR;
+ goto out;
+ }
+
+ bvec = kmalloc_array(bv_cnt, sizeof(*bvec), GFP_KERNEL);
+ if (!bvec) {
+ status = NVME_SC_INTERNAL | NVME_SC_DNR;
+ goto out;
+ }
+
+ for_each_sg(req->sg, sg, req->sg_cnt, mapped_cnt) {
+ nvmet_file_init_bvec(bvec, sg);
+ mapped_data_len += bvec[mapped_cnt].bv_len;
+ sg_cnt--;
+ if (mapped_cnt == bv_cnt)
+ break;
+ }
+
+ if (WARN_ON(sg_cnt)) {
+ status = NVME_SC_INTERNAL | NVME_SC_DNR;
+ goto out;
+ }
+
+ iov_iter_bvec(&from, WRITE, bvec, mapped_cnt, mapped_data_len);
+
+ bio = bio_alloc(GFP_KERNEL, bv_cnt);
+ bio_set_dev(bio, nvmet_bdev(req));
+ bio->bi_iter.bi_sector = sect;
+ bio->bi_opf = REQ_OP_ZONE_APPEND | REQ_SYNC | REQ_IDLE;
+
+ ret = __bio_iov_append_get_pages(bio, &from);
+ if (unlikely(ret)) {
+ status = NVME_SC_INTERNAL | NVME_SC_DNR;
+ bio_io_error(bio);
+ goto bvec_free;
+ }
+
+ ret = submit_bio_wait(bio);
+ status = ret < 0 ? NVME_SC_INTERNAL : status;
+ bio_put(bio);
+
+ sect += (mapped_data_len >> 9);
+ req->cqe->result.u64 = le64_to_cpu(nvmet_sect_to_lba(req->ns, sect));
+
+bvec_free:
+ kfree(bvec);
+
+out:
+ nvmet_req_complete(req, status);
+}
+
+#else /* CONFIG_BLK_DEV_ZONED */
+void nvmet_execute_identify_cns_cs_ctrl(struct nvmet_req *req)
+{
+}
+void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req)
+{
+}
+u16 nvmet_process_zns_cis(struct nvmet_req *req, off_t *off)
+{
+ return 0;
+}
+bool nvmet_bdev_zns_config(struct nvmet_ns *ns)
+{
+ return false;
+}
+void nvmet_bdev_execute_zone_mgmt_recv(struct nvmet_req *req)
+{
+}
+void nvmet_bdev_execute_zone_mgmt_send(struct nvmet_req *req)
+{
+}
+void nvmet_bdev_execute_zone_append(struct nvmet_req *req)
+{
+}
+void nvmet_zns_add_cmd_effects(struct nvme_effects_log *log)
+{
+}
+#endif /* CONFIG_BLK_DEV_ZONED */
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 3/9] nvmet: trim down id-desclist to use req->ns
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 1/9] block: export __bio_iov_append_get_pages() Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 2/9] nvmet: add ZNS support for bdev-ns Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 4/9] nvmet: add NVME_CSI_ZNS in ns-desc for zbdev Chaitanya Kulkarni
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
In this prep patch we remove the extra local variable struct nvmet_ns
in nvmet_execute_identify_desclist() since req already has the member
that can be reused, this also eliminates the explicit call to
nvmet_put_namespace() which is already present in the request
completion path.
This reduces the arguments to the function in the following patch to
implement the ZNS for bdev-ns so we can get away with passing the req
argument instead of req and ns.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/admin-cmd.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 509fd8dcca0c..c64b40c631e0 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -603,37 +603,35 @@ u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
static void nvmet_execute_identify_desclist(struct nvmet_req *req)
{
- struct nvmet_ns *ns;
u16 status = 0;
off_t off = 0;
- ns = nvmet_find_namespace(req->sq->ctrl, req->cmd->identify.nsid);
- if (!ns) {
+ req->ns = nvmet_find_namespace(req->sq->ctrl, req->cmd->identify.nsid);
+ if (!req->ns) {
req->error_loc = offsetof(struct nvme_identify, nsid);
status = NVME_SC_INVALID_NS | NVME_SC_DNR;
goto out;
}
- if (memchr_inv(&ns->uuid, 0, sizeof(ns->uuid))) {
+ if (memchr_inv(&req->ns->uuid, 0, sizeof(req->ns->uuid))) {
status = nvmet_copy_ns_identifier(req, NVME_NIDT_UUID,
NVME_NIDT_UUID_LEN,
- &ns->uuid, &off);
+ &req->ns->uuid, &off);
if (status)
- goto out_put_ns;
+ goto out;
}
- if (memchr_inv(ns->nguid, 0, sizeof(ns->nguid))) {
+ if (memchr_inv(req->ns->nguid, 0, sizeof(req->ns->nguid))) {
status = nvmet_copy_ns_identifier(req, NVME_NIDT_NGUID,
NVME_NIDT_NGUID_LEN,
- &ns->nguid, &off);
+ &req->ns->nguid, &off);
if (status)
- goto out_put_ns;
+ goto out;
}
if (sg_zero_buffer(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE - off,
off) != NVME_IDENTIFY_DATA_SIZE - off)
status = NVME_SC_INTERNAL | NVME_SC_DNR;
-out_put_ns:
- nvmet_put_namespace(ns);
+
out:
nvmet_req_complete(req, status);
}
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 4/9] nvmet: add NVME_CSI_ZNS in ns-desc for zbdev
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (2 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 3/9] nvmet: trim down id-desclist to use req->ns Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 5/9] nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev Chaitanya Kulkarni
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
When discovering the ZNS, the host-side looks for the NVME_CSI_ZNS
value in the ns-desc. Update the nvmet_execute_identify_desclist()
such that it can now update the ns-desc with NVME_CSI_ZNS if bdev is
zoned.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/admin-cmd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index c64b40c631e0..d4fc1bb1a318 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -628,6 +628,10 @@ static void nvmet_execute_identify_desclist(struct nvmet_req *req)
goto out;
}
+ status = nvmet_process_zns_cis(req, &off);
+ if (status)
+ goto out;
+
if (sg_zero_buffer(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE - off,
off) != NVME_IDENTIFY_DATA_SIZE - off)
status = NVME_SC_INTERNAL | NVME_SC_DNR;
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 5/9] nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (3 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 4/9] nvmet: add NVME_CSI_ZNS in ns-desc for zbdev Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 6/9] nvmet: add cns-cs-ns " Chaitanya Kulkarni
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Update the nvmet_execute_identify() such that it can now handle
NVME_ID_CNS_CS_CTRL when identify.cis is set to ZNS. This allows
host to identify the support for ZNS.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/admin-cmd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index d4fc1bb1a318..e7d2b96cda6b 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -650,6 +650,10 @@ static void nvmet_execute_identify(struct nvmet_req *req)
return nvmet_execute_identify_ns(req);
case NVME_ID_CNS_CTRL:
return nvmet_execute_identify_ctrl(req);
+ case NVME_ID_CNS_CS_CTRL:
+ if (req->cmd->identify.csi == NVME_CSI_ZNS)
+ return nvmet_execute_identify_cns_cs_ctrl(req);
+ break;
case NVME_ID_CNS_NS_ACTIVE_LIST:
return nvmet_execute_identify_nslist(req);
case NVME_ID_CNS_NS_DESC_LIST:
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 6/9] nvmet: add cns-cs-ns in id-ctrl for ZNS bdev
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (4 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 5/9] nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 7/9] nvmet: add zns cmd effects to support zbdev Chaitanya Kulkarni
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Update the nvmet_execute_identify() such that it can now handle
NVME_ID_CNS_CS_NS when identify.cis is set to ZNS. This allows
host to identify the ns with ZNS capabilities.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/admin-cmd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index e7d2b96cda6b..cd368cbe3855 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -648,6 +648,10 @@ static void nvmet_execute_identify(struct nvmet_req *req)
switch (req->cmd->identify.cns) {
case NVME_ID_CNS_NS:
return nvmet_execute_identify_ns(req);
+ case NVME_ID_CNS_CS_NS:
+ if (req->cmd->identify.csi == NVME_CSI_ZNS)
+ return nvmet_execute_identify_cns_cs_ns(req);
+ break;
case NVME_ID_CNS_CTRL:
return nvmet_execute_identify_ctrl(req);
case NVME_ID_CNS_CS_CTRL:
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 7/9] nvmet: add zns cmd effects to support zbdev
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (5 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 6/9] nvmet: add cns-cs-ns " Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 8/9] nvmet: add zns bdev config support Chaitanya Kulkarni
` (2 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Update the target side command effects logs with support for
ZNS commands for zbdev.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/admin-cmd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index cd368cbe3855..0099275951da 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -191,6 +191,8 @@ static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)
log->iocs[nvme_cmd_dsm] = cpu_to_le32(1 << 0);
log->iocs[nvme_cmd_write_zeroes] = cpu_to_le32(1 << 0);
+ nvmet_zns_add_cmd_effects(log);
+
status = nvmet_copy_to_sgl(req, 0, log, sizeof(*log));
kfree(log);
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 8/9] nvmet: add zns bdev config support
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (6 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 7/9] nvmet: add zns cmd effects to support zbdev Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 9/9] nvmet: add ZNS based I/O cmds handlers Chaitanya Kulkarni
2020-12-01 6:46 ` [PATCH V3 0/9] nvmet: add ZBD backend support Damien Le Moal
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
For zbd based bdev backend we need to override the ns->blksize_shift
with the physical block size instead of using the logical block size
so that SMR drives will not result in an error.
Update the nvmet_bdev_ns_enable() to reflect that.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/io-cmd-bdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index 125dde3f410e..e1f6d59dd341 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -86,6 +86,9 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY_T10))
nvmet_bdev_ns_enable_integrity(ns);
+ if (bdev_is_zoned(ns->bdev) && !nvmet_bdev_zns_enable(ns))
+ return -EINVAL;
+
return 0;
}
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH V3 9/9] nvmet: add ZNS based I/O cmds handlers
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (7 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 8/9] nvmet: add zns bdev config support Chaitanya Kulkarni
@ 2020-12-01 4:14 ` Chaitanya Kulkarni
2020-12-01 6:46 ` [PATCH V3 0/9] nvmet: add ZBD backend support Damien Le Moal
9 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 4:14 UTC (permalink / raw)
To: linux-block, linux-nvme; +Cc: sagi, hch, damien.lemoal, Chaitanya Kulkarni
Add zone-mgmt-send, zone-mgmt-recv and zone-zppend handlers for the
bdev backend so that it can support zbd.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/io-cmd-bdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index e1f6d59dd341..25dcd0544d5d 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -453,6 +453,15 @@ u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req)
case nvme_cmd_write_zeroes:
req->execute = nvmet_bdev_execute_write_zeroes;
return 0;
+ case nvme_cmd_zone_append:
+ req->execute = nvmet_bdev_execute_zone_append;
+ return 0;
+ case nvme_cmd_zone_mgmt_recv:
+ req->execute = nvmet_bdev_execute_zone_mgmt_recv;
+ return 0;
+ case nvme_cmd_zone_mgmt_send:
+ req->execute = nvmet_bdev_execute_zone_mgmt_send;
+ return 0;
default:
pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode,
req->sq->qid);
--
2.22.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V3 0/9] nvmet: add ZBD backend support
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
` (8 preceding siblings ...)
2020-12-01 4:14 ` [PATCH V3 9/9] nvmet: add ZNS based I/O cmds handlers Chaitanya Kulkarni
@ 2020-12-01 6:46 ` Damien Le Moal
2020-12-01 22:34 ` Chaitanya Kulkarni
9 siblings, 1 reply; 14+ messages in thread
From: Damien Le Moal @ 2020-12-01 6:46 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block, linux-nvme; +Cc: sagi, hch
On 2020/12/01 13:14, Chaitanya Kulkarni wrote:
> Hi,
>
> NVMeOF Host is capable of handling the NVMe Protocol based Zoned Block
> Devices (ZBD) in the ZNS mode with the passthru backend. There is no
> support for a generic block device backend to handle the ZBD devices
> which are not NVMe devices.
>
> This adds support to export the ZBD drives (which are not NVMe drives)
> to host from the target with NVMeOF using the host side ZNS interface.
>
> The patch series is generated in bottom-top manner where, it first adds
> prep patch and ZNS command-specific handlers on the top of genblk and
> updates the data structures, then one by one it wires up the admin cmds
> in the order host calls them in namespace initializing sequence. Once
> everything is ready, it wires-up the I/O command handlers. See below for
> patch-series overview.
>
> I've tested the ZoneFS testcases with the null_blk memory backed NVMeOF
> namespace with nvme-loop transport. The only testcase is failing in #12
> on both null blk and NVMeOF ZBD backe by null_blk.
>
> It uses invalid block device to format zonefs and doesn't do anyting
> with the input device, still looking into it.
>
> Regards,
> Chaitanya
>
> Changes from V2:-
>
> 1. Move conventional zone bitmap check into
> nvmet_bdev_validate_zns_zones().
> 2. Don't use report zones call to check the runt zone.
> 3. Trim nvmet_zasl() helper.
> 4. Fix typo in the nvmet_zns_update_zasl().
> 5. Remove the comment and fix the mdts calculation in
> nvmet_execute_identify_cns_cs_ctrl().
> 6. Use u64 for bufsize in nvmet_bdev_execute_zone_mgmt_recv().
> 7. Remove nvmet_zones_to_desc_size() and fix the nr_zones
> calculation.
> 8. Remove the op variable in nvmet_bdev_execute_zone_append().
> 9. Fix the nr_zones calculation nvmet_bdev_execute_zone_mgmt_recv().
> 10. Update cover letter subject.
>
> Changes from V1:-
>
> 1. Remove the nvmet-$(CONFIG_BLK_DEV_ZONED) += zns.o.
> 2. Mark helpers inline.
> 3. Fix typos in the comments and update the comments.
> 4. Get rid of the curly brackets.
> 5. Don't allow drives with last smaller zones.
> 6. Calculate the zasl as a function of ax_zone_append_sectors,
> bio_max_pages so we don't have to split the bio.
> 7. Add global subsys->zasl and update the zasl when new namespace
> is enabled.
> 8. Rmove the loop in the nvmet_bdev_execute_zone_mgmt_recv() and
> move functionality in to the report zone callback.
> 9. Add goto for default case in nvmet_bdev_execute_zone_mgmt_send().
> 10. Allocate the zones buffer with zones size instead of bdev nr_zones.
>
> Chaitanya Kulkarni (9):
> block: export __bio_iov_append_get_pages()
> Prep patch needed for implementing Zone Append.
> nvmet: add ZNS support for bdev-ns
> Core Command handlers and various helpers for ZBD backend which
> will be called by target-core/target-admin etc.
> nvmet: trim down id-desclist to use req->ns
> Cleanup needed to avoid the code repetation for passing extra
> function parameters for ZBD backend handlers.
> nvmet: add NVME_CSI_ZNS in ns-desc for zbdev
> Allows host to identify zoned namesapce.
> nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev
> Allows host to identify controller with the ZBD-ZNS.
> nvmet: add cns-cs-ns in id-ctrl for ZNS bdev
> Allows host to identify namespace with the ZBD-ZNS.
> nvmet: add zns cmd effects to support zbdev
> Allows host to support the ZNS commands when zoned-blkdev is
> selected.
> nvmet: add zns bdev config support
> Allows user to override any target namespace attributes for
> ZBD.
> nvmet: add ZNS based I/O cmds handlers
> Handlers for Zone-Mgmt-Send/Zone-Mgmt-Recv/Zone-Append
>
> block/bio.c | 3 +-
> drivers/nvme/target/Makefile | 2 +-
> drivers/nvme/target/admin-cmd.c | 38 ++-
> drivers/nvme/target/io-cmd-bdev.c | 12 +
> drivers/nvme/target/io-cmd-file.c | 2 +-
> drivers/nvme/target/nvmet.h | 19 ++
> drivers/nvme/target/zns.c | 426 ++++++++++++++++++++++++++++++
> include/linux/bio.h | 1 +
> 8 files changed, 487 insertions(+), 16 deletions(-)
> create mode 100644 drivers/nvme/target/zns.c
>
> # for i in nvme1n1 nullb1 ; do ./zonefs-tests.sh /dev/$i; done
> Gathering information on /dev/nvme1n1...
> zonefs-tests on /dev/nvme1n1:
> 4 zones (0 conventional zones, 4 sequential zones)
> 524288 512B sectors zone size (256 MiB)
> 1 max open zones
> Running tests
> Test 0010: mkzonefs (options) ... PASS
> Test 0011: mkzonefs (force format) ... PASS
> *Test 0012: mkzonefs (invalid device) ... FAIL*
> Test 0013: mkzonefs (super block zone state) ... PASS
> Test 0020: mount (default) ... PASS
> Test 0021: mount (invalid device) ... PASS
> Test 0022: mount (check mount directory sub-directories) ... PASS
> Test 0023: mount (options) ... PASS
> Test 0030: Number of files (default) ... PASS
> Test 0031: Number of files (aggr_cnv) ... skip
> Test 0032: Number of files using stat (default) ... PASS
> Test 0033: Number of files using stat (aggr_cnv) ... PASS
> Test 0034: Number of blocks using stat (default) ... PASS
> Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
> Test 0040: Files permissions (default) ... PASS
> Test 0041: Files permissions (aggr_cnv) ... skip
> Test 0042: Files permissions (set value) ... PASS
> Test 0043: Files permissions (set value + aggr_cnv) ... skip
> Test 0050: Files owner (default) ... PASS
> Test 0051: Files owner (aggr_cnv) ... skip
> Test 0052: Files owner (set value) ... PASS
> Test 0053: Files owner (set value + aggr_cnv) ... skip
> Test 0060: Files size (default) ... PASS
> Test 0061: Files size (aggr_cnv) ... skip
> Test 0070: Conventional file truncate ... skip
> Test 0071: Conventional file truncate (aggr_cnv) ... skip
> Test 0072: Conventional file unlink ... skip
> Test 0073: Conventional file unlink (aggr_cnv) ... skip
> Test 0074: Conventional file random write ... skip
> Test 0075: Conventional file random write (direct) ... skip
> Test 0076: Conventional file random write (aggr_cnv) ... skip
> Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
> Test 0078: Conventional file mmap read/write ... skip
> Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
> Test 0080: Sequential file truncate ... PASS
> Test 0081: Sequential file unlink ... PASS
> Test 0082: Sequential file buffered write IO ... PASS
> Test 0083: Sequential file overwrite ... PASS
> Test 0084: Sequential file unaligned write (sync IO) ... PASS
> Test 0085: Sequential file unaligned write (async IO) ... PASS
> Test 0086: Sequential file append (sync) ... PASS
> Test 0087: Sequential file append (async) ... PASS
> Test 0088: Sequential file random read ... PASS
> Test 0089: Sequential file mmap read/write ... PASS
> Test 0090: sequential file 4K synchronous write ... PASS
> Test 0091: Sequential file large synchronous write ... PASS
>
> 45 / 46 tests passed
> Gathering information on /dev/nullb1...
> zonefs-tests on /dev/nullb1:
> 4 zones (0 conventional zones, 4 sequential zones)
> 524288 512B sectors zone size (256 MiB)
> 0 max open zones
> Running tests
> Test 0010: mkzonefs (options) ... PASS
> Test 0011: mkzonefs (force format) ... PASS
> *Test 0012: mkzonefs (invalid device) ... FAIL*
> Test 0013: mkzonefs (super block zone state) ... PASS
> Test 0020: mount (default) ... PASS
> Test 0021: mount (invalid device) ... PASS
> Test 0022: mount (check mount directory sub-directories) ... PASS
> Test 0023: mount (options) ... PASS
> Test 0030: Number of files (default) ... PASS
> Test 0031: Number of files (aggr_cnv) ... skip
> Test 0032: Number of files using stat (default) ... PASS
> Test 0033: Number of files using stat (aggr_cnv) ... PASS
> Test 0034: Number of blocks using stat (default) ... PASS
> Test 0035: Number of blocks using stat (aggr_cnv) ... PASS
> Test 0040: Files permissions (default) ... PASS
> Test 0041: Files permissions (aggr_cnv) ... skip
> Test 0042: Files permissions (set value) ... PASS
> Test 0043: Files permissions (set value + aggr_cnv) ... skip
> Test 0050: Files owner (default) ... PASS
> Test 0051: Files owner (aggr_cnv) ... skip
> Test 0052: Files owner (set value) ... PASS
> Test 0053: Files owner (set value + aggr_cnv) ... skip
> Test 0060: Files size (default) ... PASS
> Test 0061: Files size (aggr_cnv) ... skip
> Test 0070: Conventional file truncate ... skip
> Test 0071: Conventional file truncate (aggr_cnv) ... skip
> Test 0072: Conventional file unlink ... skip
> Test 0073: Conventional file unlink (aggr_cnv) ... skip
> Test 0074: Conventional file random write ... skip
> Test 0075: Conventional file random write (direct) ... skip
> Test 0076: Conventional file random write (aggr_cnv) ... skip
> Test 0077: Conventional file random write (aggr_cnv, direct) ... skip
> Test 0078: Conventional file mmap read/write ... skip
> Test 0079: Conventional file mmap read/write (aggr_cnv) ... skip
> Test 0080: Sequential file truncate ... PASS
> Test 0081: Sequential file unlink ... PASS
> Test 0082: Sequential file buffered write IO ... PASS
> Test 0083: Sequential file overwrite ... PASS
> Test 0084: Sequential file unaligned write (sync IO) ... PASS
> Test 0085: Sequential file unaligned write (async IO) ... PASS
> Test 0086: Sequential file append (sync) ... PASS
> Test 0087: Sequential file append (async) ... PASS
> Test 0088: Sequential file random read ... PASS
> Test 0089: Sequential file mmap read/write ... PASS
> Test 0090: sequential file 4K synchronous write ... PASS
> Test 0091: Sequential file large synchronous write ... PASS
>
> 45 / 46 tests passed
> #
> # for i in nvme1n1 nullb1 ; do ./zonefs-tests.sh -t 0012 /dev/$i; done
> Gathering information on /dev/nvme1n1...
> zonefs-tests on /dev/nvme1n1:
> 4 zones (0 conventional zones, 4 sequential zones)
> 524288 512B sectors zone size (256 MiB)
> 1 max open zones
> Running tests
> Test 0012: mkzonefs (invalid device) ... FAIL
This passes for me:
./zonefs-tests.sh -t 0012 /dev/nullb0
Gathering information on /dev/nullb0...
zonefs-tests on /dev/nullb0:
4 zones (0 conventional zones, 4 sequential zones)
524288 512B sectors zone size (256 MiB)
1 max open zones
Running tests
Test 0012: mkzonefs (invalid device) ... PASS
1 / 1 tests passed
This test create a a regular nullb device and tries mkzonefs on it, which should
fail since the block device is not zoned. In your case, it looks like the test
endup using an existing zoned nullb device, which should not happen (nullb4 and
nullb5). How many nullb devices do you have on that system ?
>
> 0 / 1 tests passed
> Gathering information on /dev/nullb1...
> zonefs-tests on /dev/nullb1:
> 4 zones (0 conventional zones, 4 sequential zones)
> 524288 512B sectors zone size (256 MiB)
> 0 max open zones
> Running tests
> Test 0012: mkzonefs (invalid device) ... FAIL
>
> 0 / 1 tests passed
> # cat nvme1n1-zonefs-tests.log
> ## Test scripts/0012.sh (mkzonefs (invalid device))
>
> /dev/console is not a block device
> /dev/nullb4
> /dev/nullb4: 524288000 512-byte sectors (250 GiB)
> Host-managed device
> 1000 zones of 524288 512-byte sectors (256 MiB)
> 0 conventional zones, 1000 sequential zones
> 0 read-only zones, 0 offline zones
> Format:
> 999 usable zones
> Aggregate conventional zones: disabled
> File UID: 0
> File GID: 0
> File access permissions: 640
> FS UUID: 339b07fe-ebbb-4876-be16-5a887384f349
> Resetting sequential zones
> Writing super block
> --> SUCCESS (should FAIL)
> FAILED
>
> # cat nullb1-zonefs-tests.log
> ## Test scripts/0012.sh (mkzonefs (invalid device))
>
> /dev/console is not a block device
> /dev/nullb5
> /dev/nullb5: 524288000 512-byte sectors (250 GiB)
> Host-managed device
> 1000 zones of 524288 512-byte sectors (256 MiB)
> 0 conventional zones, 1000 sequential zones
> 0 read-only zones, 0 offline zones
> Format:
> 999 usable zones
> Aggregate conventional zones: disabled
> File UID: 0
> File GID: 0
> File access permissions: 640
> FS UUID: 591f1476-47c6-4d81-b0e8-7c82d4c5b657
> Resetting sequential zones
> Writing super block
> --> SUCCESS (should FAIL)
> FAILED
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V3 0/9] nvmet: add ZBD backend support
2020-12-01 6:46 ` [PATCH V3 0/9] nvmet: add ZBD backend support Damien Le Moal
@ 2020-12-01 22:34 ` Chaitanya Kulkarni
2020-12-02 4:17 ` Damien Le Moal
0 siblings, 1 reply; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-01 22:34 UTC (permalink / raw)
To: Damien Le Moal, linux-block, linux-nvme; +Cc: sagi, hch
On 11/30/20 22:47, Damien Le Moal wrote:
> This passes for me:
>
> ./zonefs-tests.sh -t 0012 /dev/nullb0
> Gathering information on /dev/nullb0...
> zonefs-tests on /dev/nullb0:
> 4 zones (0 conventional zones, 4 sequential zones)
> 524288 512B sectors zone size (256 MiB)
> 1 max open zones
> Running tests
> Test 0012: mkzonefs (invalid device) ... PASS
>
> 1 / 1 tests passed
>
> This test create a a regular nullb device and tries mkzonefs on it, which should
> fail since the block device is not zoned. In your case, it looks like the test
> endup using an existing zoned nullb device, which should not happen (nullb4 and
> nullb5). How many nullb devices do you have on that system ?
True, my test script creates random number nvmet namespaces and nullblk
devices.
I think testcase is reading the wrong device, let me finish the V4 with
removing
bio checks as per your comments and I'll look into this.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V3 0/9] nvmet: add ZBD backend support
2020-12-01 22:34 ` Chaitanya Kulkarni
@ 2020-12-02 4:17 ` Damien Le Moal
2020-12-02 6:26 ` Chaitanya Kulkarni
0 siblings, 1 reply; 14+ messages in thread
From: Damien Le Moal @ 2020-12-02 4:17 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block, linux-nvme; +Cc: sagi, hch
On 2020/12/02 7:34, Chaitanya Kulkarni wrote:
> On 11/30/20 22:47, Damien Le Moal wrote:
>> This passes for me:
>>
>> ./zonefs-tests.sh -t 0012 /dev/nullb0
>> Gathering information on /dev/nullb0...
>> zonefs-tests on /dev/nullb0:
>> 4 zones (0 conventional zones, 4 sequential zones)
>> 524288 512B sectors zone size (256 MiB)
>> 1 max open zones
>> Running tests
>> Test 0012: mkzonefs (invalid device) ... PASS
>>
>> 1 / 1 tests passed
>>
>> This test create a a regular nullb device and tries mkzonefs on it, which should
>> fail since the block device is not zoned. In your case, it looks like the test
>> endup using an existing zoned nullb device, which should not happen (nullb4 and
>> nullb5). How many nullb devices do you have on that system ?
>
> True, my test script creates random number nvmet namespaces and nullblk
> devices.
>
> I think testcase is reading the wrong device, let me finish the V4 with
> removing
>
> bio checks as per your comments and I'll look into this.
I pushed in zonefs test fix for this. Please try again, it should pass now.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V3 0/9] nvmet: add ZBD backend support
2020-12-02 4:17 ` Damien Le Moal
@ 2020-12-02 6:26 ` Chaitanya Kulkarni
0 siblings, 0 replies; 14+ messages in thread
From: Chaitanya Kulkarni @ 2020-12-02 6:26 UTC (permalink / raw)
To: Damien Le Moal, linux-block, linux-nvme; +Cc: sagi, hch
On 12/1/20 20:17, Damien Le Moal wrote:
>> bio checks as per your comments and I'll look into this.
> I pushed in zonefs test fix for this. Please try again, it should pass now.
All the testcases are passing, thanks see v4 log.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-12-02 6:27 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 4:14 [PATCH V3 0/9] nvmet: add ZBD backend support Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 1/9] block: export __bio_iov_append_get_pages() Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 2/9] nvmet: add ZNS support for bdev-ns Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 3/9] nvmet: trim down id-desclist to use req->ns Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 4/9] nvmet: add NVME_CSI_ZNS in ns-desc for zbdev Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 5/9] nvmet: add cns-cs-ctrl in id-ctrl for ZNS bdev Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 6/9] nvmet: add cns-cs-ns " Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 7/9] nvmet: add zns cmd effects to support zbdev Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 8/9] nvmet: add zns bdev config support Chaitanya Kulkarni
2020-12-01 4:14 ` [PATCH V3 9/9] nvmet: add ZNS based I/O cmds handlers Chaitanya Kulkarni
2020-12-01 6:46 ` [PATCH V3 0/9] nvmet: add ZBD backend support Damien Le Moal
2020-12-01 22:34 ` Chaitanya Kulkarni
2020-12-02 4:17 ` Damien Le Moal
2020-12-02 6:26 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).