* [PATCH] lightnvm: remove duplicate include in lightnvm.h
@ 2021-03-13 11:22 menglong8.dong
2021-04-13 10:55 ` Matias Bjørling
0 siblings, 1 reply; 3+ messages in thread
From: menglong8.dong @ 2021-03-13 11:22 UTC (permalink / raw)
To: mb; +Cc: linux-block, linux-api, linux-kernel, Zhang Yunkai
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
include/uapi/linux/lightnvm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
#ifdef __KERNEL__
#include <linux/const.h>
-#include <linux/ioctl.h>
#else /* __KERNEL__ */
#include <stdio.h>
#include <sys/ioctl.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h
2021-03-13 11:22 [PATCH] lightnvm: remove duplicate include in lightnvm.h menglong8.dong
@ 2021-04-13 10:55 ` Matias Bjørling
0 siblings, 0 replies; 3+ messages in thread
From: Matias Bjørling @ 2021-04-13 10:55 UTC (permalink / raw)
To: menglong8.dong; +Cc: linux-block, linux-api, linux-kernel, Zhang Yunkai
On 13/03/2021 12.22, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
> It is also included in the 33th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
> include/uapi/linux/lightnvm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
> index ead2e72e5c88..2745afd9b8fa 100644
> --- a/include/uapi/linux/lightnvm.h
> +++ b/include/uapi/linux/lightnvm.h
> @@ -22,7 +22,6 @@
>
> #ifdef __KERNEL__
> #include <linux/const.h>
> -#include <linux/ioctl.h>
> #else /* __KERNEL__ */
> #include <stdio.h>
> #include <sys/ioctl.h>
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches
into one.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] lightnvm: remove duplicate include in lightnvm.h
@ 2021-03-13 10:48 menglong8.dong
0 siblings, 0 replies; 3+ messages in thread
From: menglong8.dong @ 2021-03-13 10:48 UTC (permalink / raw)
To: mb; +Cc: linux-block, linux-kernel, Zhang Yunkai
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
'linux/blkdev.h' and 'uapi/linux/lightnvm.h' included in 'lightnvm.h'
is duplicated.It is also included in the 5th and 7th line.
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
include/linux/lightnvm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index 1db223710b28..0908abda9c1b 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -112,10 +112,8 @@ struct nvm_dev_ops {
#ifdef CONFIG_NVM
-#include <linux/blkdev.h>
#include <linux/file.h>
#include <linux/dmapool.h>
-#include <uapi/linux/lightnvm.h>
enum {
/* HW Responsibilities */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-13 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 11:22 [PATCH] lightnvm: remove duplicate include in lightnvm.h menglong8.dong
2021-04-13 10:55 ` Matias Bjørling
-- strict thread matches above, loose matches on Subject: below --
2021-03-13 10:48 menglong8.dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).