From: Steven Rostedt <rostedt@goodmis.org>
To: Yang Shi <shy828301@gmail.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
linux-block@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [Patch v3] block: introduce block_rq_error tracepoint
Date: Tue, 25 Jan 2022 09:38:46 -0500 [thread overview]
Message-ID: <20220125093846.59826cad@gandalf.local.home> (raw)
In-Reply-To: <20220125093702.3ffdb721@gandalf.local.home>
On Tue, 25 Jan 2022 09:37:02 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> > > +TRACE_EVENT(block_rq_error,
> > > +
> > > + TP_PROTO(struct request *rq, int error, unsigned int nr_bytes),
> > > +
> > > + TP_ARGS(rq, error, nr_bytes),
> > > +
> > > + TP_STRUCT__entry(
> > > + __field( dev_t, dev )
> > > + __string( name, rq->rq_disk ? rq->rq_disk->disk_name : "?")
> > > + __field( sector_t, sector )
> > > + __field( unsigned int, nr_sector )
> > > + __field( int, error )
> > > + __array( char, rwbs, RWBS_LEN )
>
> Why is the above not "__string" ?
>
> > > + ),
> > > +
> > > + TP_fast_assign(
> > > + __entry->dev = rq->rq_disk ? disk_devt(rq->rq_disk) : 0;
> > > + __assign_str(name, rq->rq_disk ? rq->rq_disk->disk_name : "?");
>
> __assign_str() will not work on an __array() type. It only works here
> because you added it at the end, but it's just shear luck that it didn't
> crash.
Never mind :-p I see the above is for name which is __string, and the
array is for rwbs which is filled below. I need to finish my first cup of
coffee before reviewing patches.
-- Steve
>
>
> > > + __entry->sector = blk_rq_pos(rq);
> > > + __entry->nr_sector = nr_bytes >> 9;
> > > + __entry->error = error;
> > > +
> > > + blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, nr_bytes);
> > > + ),
> > > +
> > > + TP_printk("%d,%d %s %s %llu + %u [%d]",
> > > + MAJOR(__entry->dev), MINOR(__entry->dev),
> > > + __get_str(name), __entry->rwbs,
> > > + (unsigned long long)__entry->sector,
> > > + __entry->nr_sector, __entry->error)
> > > +);
> > > +
next prev parent reply other threads:[~2022-01-25 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 5:36 [Patch v3] block: introduce block_rq_error tracepoint Cong Wang
2020-02-03 18:26 ` Steven Rostedt
2020-02-03 20:24 ` Cong Wang
2020-02-18 18:40 ` Cong Wang
2020-02-25 20:37 ` Cong Wang
2022-01-24 20:54 ` Yang Shi
2022-01-25 14:37 ` Steven Rostedt
2022-01-25 14:38 ` Steven Rostedt [this message]
2022-01-25 19:58 ` Yang Shi
2022-01-25 20:03 ` Steven Rostedt
2022-01-25 20:19 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125093846.59826cad@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shy828301@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).