From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-block@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [Patch v3] block: introduce block_rq_error tracepoint
Date: Tue, 25 Feb 2020 12:37:24 -0800 [thread overview]
Message-ID: <CAM_iQpUn9EpwrWAYKwoJDzS8eQm=XCrvGeC_HV2EiZ4cnvk7Ag@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpVegeSSWDWZTt4+ZT6qE3-AwsyHj7DAkFiFu8+8Hy-5jA@mail.gmail.com>
On Tue, Feb 18, 2020 at 10:40 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> Hi, Jens
>
>
> On Sun, Feb 2, 2020 at 9:37 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > Currently, rasdaemon uses the existing tracepoint block_rq_complete
> > and filters out non-error cases in order to capture block disk errors.
> >
> > But there are a few problems with this approach:
> >
> > 1. Even kernel trace filter could do the filtering work, there is
> > still some overhead after we enable this tracepoint.
> >
> > 2. The filter is merely based on errno, which does not align with kernel
> > logic to check the errors for print_req_error().
> >
> > 3. block_rq_complete only provides dev major and minor to identify
> > the block device, it is not convenient to use in user-space.
> >
> > So introduce a new tracepoint block_rq_error just for the error case
> > and provides the device name for convenience too. With this patch,
> > rasdaemon could switch to block_rq_error.
> >
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> Can you take this patch?
Any response?
Thanks.
next prev parent reply other threads:[~2020-02-25 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 5:36 [Patch v3] block: introduce block_rq_error tracepoint Cong Wang
2020-02-03 18:26 ` Steven Rostedt
2020-02-03 20:24 ` Cong Wang
2020-02-18 18:40 ` Cong Wang
2020-02-25 20:37 ` Cong Wang [this message]
2022-01-24 20:54 ` Yang Shi
2022-01-25 14:37 ` Steven Rostedt
2022-01-25 14:38 ` Steven Rostedt
2022-01-25 19:58 ` Yang Shi
2022-01-25 20:03 ` Steven Rostedt
2022-01-25 20:19 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpUn9EpwrWAYKwoJDzS8eQm=XCrvGeC_HV2EiZ4cnvk7Ag@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).