[PATCH] block: fix two kerneldoc comment

[PATCH] block: fix two kerneldoc comment

[Christoph Hellwig]

Fix up two comments for the recent merge of hd_struct into
structc block_device.

Fixes: 37c3fc9abb25 ("block: simplify the block device claiming interface")
Fixes: 4e7b5671c6a8 ("block: remove i_bdev")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/block_dev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 9e56ee1f265230..9ab18364d96172 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1056,7 +1056,6 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
 /**
  * bd_abort_claiming - abort claiming of a block device
  * @bdev: block device of interest
- * @whole: whole block device
  * @holder: holder that has claimed @bdev
  *
  * Abort claiming of a block device when the exclusive open failed. This can be
@@ -1829,9 +1828,10 @@ const struct file_operations def_blk_fops = {
 /**
  * lookup_bdev  - lookup a struct block_device by name
  * @pathname:	special file representing the block device
+ * @dev:	returned device
  *
- * Get a reference to the blockdevice at @pathname in the current
- * namespace if possible and return it.  Return ERR_PTR(error)
+ * Look up the inode at @pathname, and if it is a block device node return the
+ * dev_t for it in @dev.  Returns 0 if successful, or a negative error code
  * otherwise.
  */
 int lookup_bdev(const char *pathname, dev_t *dev)
-- 
2.29.2

Re: [PATCH] block: fix two kerneldoc comment

[Damien Le Moal]

On 2020/12/03 17:40, Christoph Hellwig wrote:
> Fix up two comments for the recent merge of hd_struct into
> structc block_device.
> 
> Fixes: 37c3fc9abb25 ("block: simplify the block device claiming interface")
> Fixes: 4e7b5671c6a8 ("block: remove i_bdev")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/block_dev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 9e56ee1f265230..9ab18364d96172 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1056,7 +1056,6 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
>  /**
>   * bd_abort_claiming - abort claiming of a block device
>   * @bdev: block device of interest
> - * @whole: whole block device
>   * @holder: holder that has claimed @bdev
>   *
>   * Abort claiming of a block device when the exclusive open failed. This can be
> @@ -1829,9 +1828,10 @@ const struct file_operations def_blk_fops = {
>  /**
>   * lookup_bdev  - lookup a struct block_device by name
>   * @pathname:	special file representing the block device
> + * @dev:	returned device
>   *
> - * Get a reference to the blockdevice at @pathname in the current
> - * namespace if possible and return it.  Return ERR_PTR(error)
> + * Look up the inode at @pathname, and if it is a block device node return the
> + * dev_t for it in @dev.  Returns 0 if successful, or a negative error code
>   * otherwise.
>   */
>  int lookup_bdev(const char *pathname, dev_t *dev)
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research