* [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller
@ 2019-04-24 9:10 Amit K Bag
2019-04-24 10:26 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Amit K Bag @ 2019-04-24 9:10 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ravishankar.srivatsa, chethan.tumkur.narayan, Amit K Bag
This patch mask unnecessary event notifications from controller to host
Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
---
drivers/bluetooth/btintel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 5270d5513201..7e5cdd37cc1f 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -313,7 +313,7 @@ EXPORT_SYMBOL_GPL(btintel_load_ddc_config);
int btintel_set_event_mask(struct hci_dev *hdev, bool debug)
{
- u8 mask[8] = { 0x87, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
+ u8 mask[8] = { 0x01, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
struct sk_buff *skb;
int err;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller
2019-04-24 9:10 [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller Amit K Bag
@ 2019-04-24 10:26 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2019-04-24 10:26 UTC (permalink / raw)
To: Amit K Bag; +Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan
Hi Amit,
> This patch mask unnecessary event notifications from controller to host
>
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 5270d5513201..7e5cdd37cc1f 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -313,7 +313,7 @@ EXPORT_SYMBOL_GPL(btintel_load_ddc_config);
>
> int btintel_set_event_mask(struct hci_dev *hdev, bool debug)
> {
> - u8 mask[8] = { 0x87, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> + u8 mask[8] = { 0x01, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> struct sk_buff *skb;
> int err;
so I enabled actually many more events to ensure we get proper output in btmon in case something happens. So you need to be more specific why we want to not enable these events for our hardware.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-24 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 9:10 [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller Amit K Bag
2019-04-24 10:26 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).