* [PATCH 09/12] btmon: fix segfault caused by buffer over-read
@ 2018-10-16 20:23 Matias Karhumaa
0 siblings, 0 replies; only message in thread
From: Matias Karhumaa @ 2018-10-16 20:23 UTC (permalink / raw)
To: linux-bluetooth
Fix segfault caused by buffer over-read in btmon. Fix is to check in
packet_monitor() that index is not bigger than MAX_INDEX before accessing
index_list.
Crash was found by fuzzing btmon with AFL.
---
monitor/packet.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/monitor/packet.c b/monitor/packet.c
index 1e9f9d9e4..2d8e15597 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -3864,6 +3864,11 @@ void packet_monitor(struct timeval *tv, struct ucred *cred,
index_current = index;
}
+ if (index != HCI_DEV_NONE && index > MAX_INDEX) {
+ print_field("Invalid index (%d)", index);
+ return;
+ }
+
if (tv && time_offset == ((time_t) -1))
time_offset = tv->tv_sec;
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-16 20:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 20:23 [PATCH 09/12] btmon: fix segfault caused by buffer over-read Matias Karhumaa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).