From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, ayush.garg@samsung.com
Subject: RE: Support for Adapter's Default PHY Configuration
Date: Wed, 21 Jul 2021 23:45:22 -0700 (PDT) [thread overview]
Message-ID: <60f91402.1c69fb81.db8d2.c061@mx.google.com> (raw)
In-Reply-To: <20210722052640.5863-2-ayush.garg@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 7427 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=519479
---Test result---
Test Summary:
CheckPatch FAIL 1.86 seconds
GitLint FAIL 0.84 seconds
Prep - Setup ELL PASS 47.00 seconds
Build - Prep PASS 0.10 seconds
Build - Configure PASS 8.33 seconds
Build - Make PASS 203.42 seconds
Make Check PASS 9.65 seconds
Make Distcheck PASS 241.66 seconds
Build w/ext ELL - Configure PASS 8.32 seconds
Build w/ext ELL - Make PASS 191.62 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
adapter: Add support for get/set phy configuration property
WARNING:LONG_LINE_STRING: line length of 82 exceeds 80 columns
#103: FILE: src/adapter.c:3323:
+ g_dbus_pending_property_error(data->id, ERROR_INTERFACE ".Failed",
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#145: FILE: src/adapter.c:3365:
+ unconfigure_phys = adapter->supported_phys & ~(adapter->configurable_phys);
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#171: FILE: src/adapter.c:3391:
+ DBG("sending set phy configuration command for index %u", adapter->dev_id);
WARNING:LONG_LINE_STRING: line length of 82 exceeds 80 columns
#181: FILE: src/adapter.c:3401:
+ btd_error(adapter->dev_id, "Failed to set PHY configuration for index %u",
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#189: FILE: src/adapter.c:3409:
+ const GDBusPropertyTable *property,
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#205: FILE: src/adapter.c:3425:
+ const GDBusPropertyTable *property,
^
- total: 2 errors, 4 warnings, 312 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] adapter: Add support for get/set phy configuration property" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
adapter: Add support for the get supported phy property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#20: FILE: src/adapter.c:3409:
+ const GDBusPropertyTable *property,
^
- total: 1 errors, 0 warnings, 30 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] adapter: Add support for the get supported phy property" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
adapter: Add support for PHY Configuration Changed event
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#52: FILE: src/adapter.c:9944:
+ phy_configuration_changed_callback,
- total: 0 errors, 1 warnings, 39 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] adapter: Add support for PHY Configuration Changed event" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
client: Add support for get/set PHY configuration in bluetoothctl
WARNING:LONG_LINE_STRING: line length of 87 exceeds 80 columns
#65: FILE: client/main.c:2046:
+ "SupportedPhyConfiguration", "Supported phys");
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#86: FILE: client/main.c:2067:
+ "PhyConfiguration", DBUS_TYPE_STRING, phys,
WARNING:LONG_LINE_STRING: line length of 88 exceeds 80 columns
#87: FILE: client/main.c:2068:
+ phys_len, generic_callback, "PHY Configuration",
- total: 0 errors, 3 warnings, 57 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] client: Add support for get/set PHY configuration in" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
client: Add support for get/set PHY configuration in bluetoothctl
18: B3 Line contains hard tab characters (\t): " Supported phys: BR1M1SLOT"
19: B3 Line contains hard tab characters (\t): " Supported phys: BR1M3SLOT"
20: B3 Line contains hard tab characters (\t): " Supported phys: BR1M5SLOT"
21: B3 Line contains hard tab characters (\t): " Supported phys: EDR2M1SLOT"
22: B3 Line contains hard tab characters (\t): " Supported phys: EDR2M3SLOT"
23: B3 Line contains hard tab characters (\t): " Supported phys: EDR2M5SLOT"
24: B3 Line contains hard tab characters (\t): " Supported phys: EDR3M1SLOT"
25: B3 Line contains hard tab characters (\t): " Supported phys: EDR3M3SLOT"
26: B3 Line contains hard tab characters (\t): " Supported phys: EDR3M5SLOT"
27: B3 Line contains hard tab characters (\t): " Supported phys: LE1MTX"
28: B3 Line contains hard tab characters (\t): " Supported phys: LE1MRX"
29: B3 Line contains hard tab characters (\t): " Selected phys: BR1M1SLOT"
30: B3 Line contains hard tab characters (\t): " Selected phys: LE1MTX"
31: B3 Line contains hard tab characters (\t): " Selected phys: LE1MRX"
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2021-07-22 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210722052737epcas5p1682a7f66d42470c3cdb8dd04160912ab@epcas5p1.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 0/7] Support for Adapter's Default PHY Configuration Ayush Garg
[not found] ` <CGME20210722052738epcas5p3b6074e49f088159e8282bba3457d56ba@epcas5p3.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 1/7] doc/adapter-api: Add SupportedPhyConfiguration property Ayush Garg
2021-07-22 6:45 ` bluez.test.bot [this message]
2021-07-22 14:46 ` Marcel Holtmann
[not found] ` <CGME20210722052739epcas5p4412d38b394f51ab195c77c887f0a0aaf@epcas5p4.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 2/7] doc/adapter-api: Add PhyConfiguration property Ayush Garg
2021-07-22 17:20 ` Luiz Augusto von Dentz
[not found] ` <CGME20210722052740epcas5p1fce869a24434f376d111e9e5d4b208eb@epcas5p1.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 3/7] adapter: Add support for get/set phy configuration property Ayush Garg
[not found] ` <CGME20210722052741epcas5p2cb3cbad65a301b0ec0cf1780c0920103@epcas5p2.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 4/7] adapter: Add support for the get supported phy property Ayush Garg
[not found] ` <CGME20210722052742epcas5p1b53db2cd68028170a86f291bd052bf14@epcas5p1.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 5/7] adapter: Add support for PHY Configuration Changed event Ayush Garg
[not found] ` <CGME20210722052743epcas5p34af6f55c11db2e8909c2730fae7e1cac@epcas5p3.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 6/7] client: Add support for get/set PHY configuration in bluetoothctl Ayush Garg
[not found] ` <CGME20210722052744epcas5p46996d48d12500c39b4b63dfcecd30d37@epcas5p4.samsung.com>
2021-07-22 5:26 ` [PATCH BlueZ 7/7] adapter: Save PHY Configuration in storage and read it at init Ayush Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f91402.1c69fb81.db8d2.c061@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=ayush.garg@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).