From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead
Date: Thu, 24 Jan 2019 20:22:37 +0100 [thread overview]
Message-ID: <20190124192236.GA2900@twin.jikos.cz> (raw)
In-Reply-To: <20190123071518.2528-1-wqu@suse.com>
On Wed, Jan 23, 2019 at 03:15:11PM +0800, Qu Wenruo wrote:
> - A lot of coding style fixes:
> * naming change from "file"/"subv" to "subvol"
> * {} for any else if branch
> * avoid err/ret confusion by introducing "tmp_ret"
> * proper errno for non-uptodate extent buffer
> * struct member re-ordering to avoid unnecessary padding
> * avoid single letter variable name
> * less redundant emphasizing
> * move certain devel-only warning under CONFIG_BTRFS_DEBUG
> * replace cool-sounding 'hack' with 'optimization'
> * remove unnecessary inline prefix for btrfs_qgroup_init_swapped_blocks
> * keep an empty line before #endif
Thank you, reading through the patches was now much smoother experience
for me. I'll let it pass fstests and merge it to misc-next, as there are
more patches and patchsets depending on it so we can give it wider
testing.
The slow metadata balance patch has been posted, the qgroup deadlock
still needs to be resolved. If you have ideas or pending cleanups in the
qgroup code then it's fine to send them until rc5. I hope the main
functional changes are about to be merged, small fixups or additions
should be within the scope of testing.
next prev parent reply other threads:[~2019-01-24 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 7:15 [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2019-01-23 7:15 ` [Patch v5 1/7] btrfs: qgroup: Move reserved data account from btrfs_delayed_ref_head to btrfs_qgroup_extent_record Qu Wenruo
2019-02-08 14:02 ` David Sterba
2019-01-23 7:15 ` [Patch v5 2/7] btrfs: honor path->skip_locking in backref code Qu Wenruo
2019-01-23 7:15 ` [Patch v5 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots() Qu Wenruo
2019-01-23 7:15 ` [Patch v5 4/7] btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() Qu Wenruo
2019-01-23 7:15 ` [Patch v5 5/7] btrfs: qgroup: Introduce per-root swapped blocks infrastructure Qu Wenruo
2019-01-23 7:15 ` [Patch v5 6/7] btrfs: qgroup: Use delayed subtree rescan for balance Qu Wenruo
2019-01-23 7:15 ` [Patch v5 7/7] btrfs: qgroup: Cleanup old subtree swap code Qu Wenruo
2019-01-23 7:22 ` [Patch v5 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2019-01-23 17:47 ` David Sterba
2019-01-24 0:02 ` Qu Wenruo
2019-01-24 13:36 ` Qu Wenruo
2019-01-24 19:22 ` David Sterba [this message]
2019-01-28 18:15 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124192236.GA2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).