* [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir
@ 2019-12-17 6:36 Long An
2019-12-18 16:19 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Long An @ 2019-12-17 6:36 UTC (permalink / raw)
To: linux-btrfs
Documentation folder path is wrong on exported testsutie. Fix this by
replace TOP with INTERNAL_BIN.
Signed-off-by: An Long <lan@suse.com>
---
tests/mkfs-tests/011-rootdir-create-file/test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/mkfs-tests/011-rootdir-create-file/test.sh b/tests/mkfs-tests/011-rootdir-create-file/test.sh
index 20f7c4ce..a21c6245 100755
--- a/tests/mkfs-tests/011-rootdir-create-file/test.sh
+++ b/tests/mkfs-tests/011-rootdir-create-file/test.sh
@@ -10,6 +10,6 @@ check_prereq mkfs.btrfs
tmp=$(mktemp -d --tmpdir btrfs-progs-mkfs.rootdirXXXXXXX)
# we can't use TEST_DEV, a file is needed
img=$(mktemp btrfs-progs-mkfs.rootdirXXXXXXX)
-run_check "$TOP/mkfs.btrfs" -f --rootdir "$TOP/Documentation/" "$img"
+run_check "$TOP/mkfs.btrfs" -f --rootdir "$INTERNAL_BIN/Documentation/" "$img"
rm -rf -- "$img"
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir
2019-12-17 6:36 [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir Long An
@ 2019-12-18 16:19 ` David Sterba
2019-12-20 6:09 ` Qu Wenruo
0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2019-12-18 16:19 UTC (permalink / raw)
To: Long An; +Cc: linux-btrfs
On Tue, Dec 17, 2019 at 06:36:51AM +0000, Long An wrote:
> Documentation folder path is wrong on exported testsutie. Fix this by
> replace TOP with INTERNAL_BIN.
It feels wrong that the tests use INTERNAL_BIN but it obviously exists
and works so I'll apply the patch but maybe this could use some cleanup.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir
2019-12-18 16:19 ` David Sterba
@ 2019-12-20 6:09 ` Qu Wenruo
0 siblings, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2019-12-20 6:09 UTC (permalink / raw)
To: dsterba, Long An, linux-btrfs
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
On 2019/12/19 上午12:19, David Sterba wrote:
> On Tue, Dec 17, 2019 at 06:36:51AM +0000, Long An wrote:
>> Documentation folder path is wrong on exported testsutie. Fix this by
>> replace TOP with INTERNAL_BIN.
>
> It feels wrong that the tests use INTERNAL_BIN but it obviously exists
> and works so I'll apply the patch but maybe this could use some cleanup.
> Thanks.
>
The patch itself is kinda OK, but I guess we'd better to have some file
generation function to test mkfs.btrfs --rootdir.
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-20 6:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 6:36 [PATCH] btrfs-progs: tests: mkfs/011: Fix path for rootdir Long An
2019-12-18 16:19 ` David Sterba
2019-12-20 6:09 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).