From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>,
kernel-team@fb.com, linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH 4/5] btrfs: do not account global reserve in can_overcommit
Date: Thu, 23 Jan 2020 19:48:20 -0500 [thread overview]
Message-ID: <70811c93-2933-8055-ad3c-ce874e1a703a@toxicpanda.com> (raw)
In-Reply-To: <8b7d11d3-3f54-d090-a1c6-cb1e67b2b4f1@oracle.com>
On 1/23/20 11:14 AM, Anand Jain wrote:
>
>
> This patch is causing regression in the test case generic/027
> and generic/275 with MKFS_OPTIONS="-n64K" on x86_64.
>
> Both of these tests, test FS behavior at ENOSPC.
>
> In generic/027, it fails to delete a file with ENOSPC
>
> +rm: cannot remove '/mnt/scratch/testdir/6/file_1598': No space left on
> device
>
> In generic/275, it failed to create at least 128k size file after
> deleting 256k sized file. Failure may be fair taking into the cow part,
> but any idea why it could be successful before this patch?
>
> +du: cannot access '/mnt/scratch/tmp1': No such file or directory
> +stat: cannot stat '/mnt/scratch/tmp1': No such file or directory
>
> These fail on misc-next as well.
I spot checked this and it appears because before we just weren't getting as
full before, and now we are.
These failures are the next thing on my list, I'll likely have them fixed early
next week. Thanks,
Josef
next prev parent reply other threads:[~2020-01-24 0:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 19:18 [PATCH 0/5][v2] Fix global reserve size and can overcommit Josef Bacik
2019-08-22 19:19 ` [PATCH 1/5] btrfs: change the minimum global reserve size Josef Bacik
2019-08-22 19:19 ` [PATCH 2/5] btrfs: always reserve our entire size for the global reserve Josef Bacik
2019-08-22 19:19 ` [PATCH 3/5] btrfs: use btrfs_try_granting_tickets in update_global_rsv Josef Bacik
2019-08-22 19:19 ` [PATCH 4/5] btrfs: do not account global reserve in can_overcommit Josef Bacik
2020-01-23 16:14 ` Anand Jain
2020-01-24 0:48 ` Josef Bacik [this message]
2019-08-22 19:19 ` [PATCH 5/5] btrfs: add enospc debug messages for ticket failure Josef Bacik
2019-08-23 13:17 ` [PATCH 0/5][v2] Fix global reserve size and can overcommit David Sterba
2019-08-28 18:03 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 15:20 [PATCH 0/5] " Josef Bacik
2019-08-16 15:20 ` [PATCH 4/5] btrfs: do not account global reserve in can_overcommit Josef Bacik
2019-08-21 6:51 ` Nikolay Borisov
2019-08-21 15:30 ` Vladimir Panteleev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70811c93-2933-8055-ad3c-ce874e1a703a@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).