From: David Ahern <dsahern@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH RESEND iproute2 5.11] iplink_can: add Classical CAN frame LEN8_DLC support
Date: Wed, 3 Feb 2021 08:47:31 -0700 [thread overview]
Message-ID: <1bf605b4-70e5-e5f2-f076-45c9b52a5758@gmail.com> (raw)
In-Reply-To: <fe697032-88f2-c1f1-8afc-f4469a5f3bd5@hartkopp.net>
On 2/2/21 10:30 AM, Oliver Hartkopp wrote:
>
>
> On 02.02.21 16:35, David Ahern wrote:
>> On 2/2/21 3:48 AM, Oliver Hartkopp wrote:
>>>
>>> Are you sure this patch is correctly assigned to iproute2-next?
>>>
>>> IMO it has to be applied to iproute2 as the functionality is already in
>>> v5.11 which is in rc6 right now.
>>>
>>
>> new features land in iproute2-next just as they do for the kernel with
>> net-next.
>>
>> Patches adding support for kernel features should be sent in the same
>> development window if you want the iproute2 support to match kernel
>> version.
>>
>
> Oh, I followed the commits from iproute2 until the new include files
> from (in this case) 5.11 pre rc1 had been updated (on 2020-12-24):
>
> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=2953235e61eb672bbdd2de84eb5b91c388f9a9b5
>
>
> I thought the uapi updates in iproute2 are *always* pulled from the
> kernel and not from iprout2-next which was new to me.
I sync kernel headers for iproute2-next with net-next, not linux-next.
>
> Do you expect patches for iproute2-next when the relevant changes become
> available in linux-next then?
>
> Even though I did not know about iproute2-next the patch is needed for
> the 5.11 kernel (as written in the subject).
>
From a cursory look it appears CAN commits do not go through the netdev
tree yet the code is under net/can and the admin tool is through
iproute2 and netdevs. Why is that? If features patches flowed through
net-next, we would not have this problem.
next prev parent reply other threads:[~2021-02-03 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 10:40 [PATCH RESEND iproute2 5.11] iplink_can: add Classical CAN frame LEN8_DLC support Oliver Hartkopp
2021-02-01 15:21 ` Vincent MAILHOL
[not found] ` <b835a46c-f950-6c58-f50f-9b2f4fd66b46@gmail.com>
2021-02-02 10:48 ` Oliver Hartkopp
2021-02-02 15:35 ` David Ahern
2021-02-02 17:30 ` Oliver Hartkopp
2021-02-03 15:47 ` David Ahern [this message]
2021-02-03 19:04 ` Oliver Hartkopp
2021-02-04 3:15 ` David Ahern
2021-02-04 20:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf605b4-70e5-e5f2-f076-45c9b52a5758@gmail.com \
--to=dsahern@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).