From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev <netdev@vger.kernel.org>,
linux-can <linux-can@vger.kernel.org>
Subject: Re: [PATCH RESEND iproute2 5.11] iplink_can: add Classical CAN frame LEN8_DLC support
Date: Tue, 2 Feb 2021 00:21:23 +0900 [thread overview]
Message-ID: <CAMZ6Rq+WvuGMrR2sQykt727ZZPvb2v-6hb0nvVpsUwWCco7bFg@mail.gmail.com> (raw)
In-Reply-To: <20210125104055.79882-1-socketcan@hartkopp.net>
On Mon. 25 Jan 2021 at 19:40, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> The len8_dlc element is filled by the CAN interface driver and used for CAN
> frame creation by the CAN driver when the CAN_CTRLMODE_CC_LEN8_DLC flag is
> supported by the driver and enabled via netlink configuration interface.
>
> Add the command line support for cc-len8-dlc for Linux 5.11+
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> ---
> ip/iplink_can.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/ip/iplink_can.c b/ip/iplink_can.c
> index 735ab941..6a26f3ff 100644
> --- a/ip/iplink_can.c
> +++ b/ip/iplink_can.c
> @@ -35,10 +35,11 @@ static void print_usage(FILE *f)
> "\t[ one-shot { on | off } ]\n"
> "\t[ berr-reporting { on | off } ]\n"
> "\t[ fd { on | off } ]\n"
> "\t[ fd-non-iso { on | off } ]\n"
> "\t[ presume-ack { on | off } ]\n"
> + "\t[ cc-len8-dlc { on | off } ]\n"
> "\n"
> "\t[ restart-ms TIME-MS ]\n"
> "\t[ restart ]\n"
> "\n"
> "\t[ termination { 0..65535 } ]\n"
> @@ -101,10 +102,11 @@ static void print_ctrlmode(FILE *f, __u32 cm)
> _PF(CAN_CTRLMODE_ONE_SHOT, "ONE-SHOT");
> _PF(CAN_CTRLMODE_BERR_REPORTING, "BERR-REPORTING");
> _PF(CAN_CTRLMODE_FD, "FD");
> _PF(CAN_CTRLMODE_FD_NON_ISO, "FD-NON-ISO");
> _PF(CAN_CTRLMODE_PRESUME_ACK, "PRESUME-ACK");
> + _PF(CAN_CTRLMODE_CC_LEN8_DLC, "CC-LEN8-DLC");
> #undef _PF
> if (cm)
> print_hex(PRINT_ANY, NULL, "%x", cm);
> close_json_array(PRINT_ANY, "> ");
> }
> @@ -209,10 +211,14 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv,
> CAN_CTRLMODE_FD_NON_ISO);
> } else if (matches(*argv, "presume-ack") == 0) {
> NEXT_ARG();
> set_ctrlmode("presume-ack", *argv, &cm,
> CAN_CTRLMODE_PRESUME_ACK);
> + } else if (matches(*argv, "cc-len8-dlc") == 0) {
> + NEXT_ARG();
> + set_ctrlmode("cc-len8-dlc", *argv, &cm,
> + CAN_CTRLMODE_CC_LEN8_DLC);
> } else if (matches(*argv, "restart") == 0) {
> __u32 val = 1;
>
> addattr32(n, 1024, IFLA_CAN_RESTART, val);
> } else if (matches(*argv, "restart-ms") == 0) {
> --
> 2.29.2
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed and tested the patch, everything is OK for me.
Thanks Oliver!
next prev parent reply other threads:[~2021-02-01 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 10:40 [PATCH RESEND iproute2 5.11] iplink_can: add Classical CAN frame LEN8_DLC support Oliver Hartkopp
2021-02-01 15:21 ` Vincent MAILHOL [this message]
[not found] ` <b835a46c-f950-6c58-f50f-9b2f4fd66b46@gmail.com>
2021-02-02 10:48 ` Oliver Hartkopp
2021-02-02 15:35 ` David Ahern
2021-02-02 17:30 ` Oliver Hartkopp
2021-02-03 15:47 ` David Ahern
2021-02-03 19:04 ` Oliver Hartkopp
2021-02-04 3:15 ` David Ahern
2021-02-04 20:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZ6Rq+WvuGMrR2sQykt727ZZPvb2v-6hb0nvVpsUwWCco7bFg@mail.gmail.com \
--to=mailhol.vincent@wanadoo.fr \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).