From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: kernel test robot <lkp@intel.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
Max Staudt <max@enpas.org>
Subject: Re: [PATCH v2 1/2] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c
Date: Sat, 14 May 2022 14:16:09 +0900 [thread overview]
Message-ID: <CAMZ6RqLU-Wg0Cau3cM=QsU-t-7Lyzmo1nJ_VAA4Mbw3u0jnNtw@mail.gmail.com> (raw)
In-Reply-To: <202205141221.H0aZXRak-lkp@intel.com>
On Sat. 14 May 2022 à 13:20, kernel test robot <lkp@intel.com> wrote:
> Hi Vincent,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on mkl-can-next/testing]
> [also build test ERROR on v5.18-rc6 next-20220513]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Mailhol/can-skb-move-can_dropped_invalid_skb-and-can_skb_headroom_valid-to-skb-c/20220514-003707
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
> config: arm-randconfig-r021-20220512 (https://download.01.org/0day-ci/archive/20220514/202205141221.H0aZXRak-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 38189438b69ca27b4c6ce707c52dbd217583d046)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://github.com/intel-lab-lkp/linux/commit/8f56e6b1b9945ea47c9f410d1254451df9d6fe22
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Vincent-Mailhol/can-skb-move-can_dropped_invalid_skb-and-can_skb_headroom_valid-to-skb-c/20220514-003707
> git checkout 8f56e6b1b9945ea47c9f410d1254451df9d6fe22
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> ld.lld: warning: lld uses blx instruction, no object with architecture supporting feature detected
> ld.lld: warning: lld uses blx instruction, no object with architecture supporting feature detected
> >> ld.lld: error: undefined symbol: can_dropped_invalid_skb
> >>> referenced by vxcan.c:45 (drivers/net/can/vxcan.c:45)
> >>> net/can/vxcan.o:(vxcan_xmit) in archive drivers/built-in.a
OK, so the issue is that VCAN and VXCAN are users of
can_dropped_invalid_skb() but do not depend on CAN_DEV. Above error
will appear if CONFIG_CAN_DEV is not set (or if CONFIG_V{,X}CAN is set
to "yes" and CAN_DEV is set to "module").
I see three choices here:
1. move can_dropped_invalid_skb() outside of drivers/net/can (i.e.
move it somewhere in net/can).
2. split CAN_DEV into one additional sub module: CAN_SKB and add a
dependency to it in VCAN and VXCAN.
3. Add a dependency to CAN_DEV in VCAN and VXCAN
1. is I think the worse, 2. the best, 3. is the laziest option and is
kind of acceptable.
@Marc (and anyone else), what are your thoughts?
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2022-05-14 5:16 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 14:23 [PATCH 0/2] can: drop tx skb if the device is in listen only mode Vincent Mailhol
2022-05-13 14:23 ` [PATCH 1/2] can: move can_dropped_invalid_skb from skb.h to dev.h Vincent Mailhol
2022-05-13 14:23 ` [PATCH 2/2] can: dev: drop tx skb if in listen only mode Vincent Mailhol
2022-05-13 14:42 ` [PATCH 0/2] can: drop tx skb if the device is " Marc Kleine-Budde
2022-05-13 15:20 ` Vincent MAILHOL
2022-05-13 15:36 ` [PATCH v2 " Vincent Mailhol
2022-05-13 15:36 ` [PATCH v2 1/2] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c Vincent Mailhol
2022-05-14 4:20 ` kernel test robot
2022-05-14 5:16 ` Vincent MAILHOL [this message]
2022-05-14 11:17 ` Max Staudt
2022-05-13 15:36 ` [PATCH v2 2/2] can: dev: drop tx skb if in listen only mode Vincent Mailhol
2022-05-13 17:40 ` [PATCH v2 0/2] can: drop tx skb if the device is " Max Staudt
2022-05-14 3:00 ` Vincent MAILHOL
2022-05-14 14:16 ` [PATCH v3 0/4] can: can_dropped_invalid_skb() and Kbuild changes Vincent Mailhol
2022-05-14 14:16 ` [PATCH v3 1/4] can: slcan: use can_dropped_invalid_skb() instead of manual check Vincent Mailhol
2022-05-16 20:40 ` Marc Kleine-Budde
2022-05-14 14:16 ` [PATCH v3 2/4] can: Kconfig: change CAN_DEV into a menuconfig Vincent Mailhol
2022-05-14 14:16 ` [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c Vincent Mailhol
2022-05-15 19:17 ` Oliver Hartkopp
2022-05-17 1:50 ` Vincent MAILHOL
2022-05-17 4:12 ` Max Staudt
2022-05-17 6:08 ` Marc Kleine-Budde
2022-05-17 7:04 ` Vincent MAILHOL
2022-05-17 10:45 ` Marc Kleine-Budde
2022-05-17 11:51 ` Oliver Hartkopp
2022-05-17 12:14 ` Max Staudt
2022-05-17 12:21 ` Marc Kleine-Budde
2022-05-17 12:39 ` Max Staudt
2022-05-17 13:35 ` Oliver Hartkopp
2022-05-17 13:43 ` Max Staudt
2022-05-17 14:23 ` Marc Kleine-Budde
2022-05-17 14:35 ` Oliver Hartkopp
2022-05-17 15:38 ` Max Staudt
2022-05-17 15:50 ` Oliver Hartkopp
2022-05-17 17:52 ` Max Staudt
2022-05-18 12:03 ` Vincent MAILHOL
2022-05-18 12:12 ` Device Drivers: (was: Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c) Marc Kleine-Budde
2022-05-18 12:45 ` Oliver Hartkopp
2022-05-18 13:10 ` [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c Oliver Hartkopp
2022-05-18 13:28 ` Marc Kleine-Budde
2022-05-18 14:07 ` Vincent MAILHOL
2022-05-18 14:33 ` Oliver Hartkopp
2022-05-18 14:36 ` Marc Kleine-Budde
2022-05-18 14:38 ` Oliver Hartkopp
2022-05-18 14:55 ` Oliver Hartkopp
2022-05-18 15:38 ` Vincent MAILHOL
2022-05-18 15:48 ` Max Staudt
2022-05-18 16:01 ` Vincent MAILHOL
2022-05-14 14:16 ` [PATCH v3 4/4] can: dev: drop tx skb if in listen only mode Vincent Mailhol
2022-06-03 10:28 ` [PATCH v4 0/7] can: refactoring of can-dev module and of Kbuild Vincent Mailhol
2022-06-03 10:28 ` [PATCH v4 1/7] can: Kbuild: rename config symbol CAN_DEV into CAN_NETLINK Vincent Mailhol
2022-06-03 10:28 ` [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into a menuconfig using CAN_DEV Vincent Mailhol
2022-06-04 11:27 ` Marc Kleine-Budde
2022-06-04 12:30 ` Vincent MAILHOL
2022-06-04 12:43 ` Marc Kleine-Budde
2022-06-04 13:46 ` Marc Kleine-Budde
2022-06-03 10:28 ` [PATCH v4 3/7] can: bittiming: move bittiming calculation functions to calc_bittiming.c Vincent Mailhol
2022-06-04 11:25 ` Marc Kleine-Budde
2022-06-04 12:21 ` Vincent MAILHOL
2022-06-04 12:41 ` Marc Kleine-Budde
2022-06-04 12:56 ` Vincent MAILHOL
2022-06-04 13:51 ` Marc Kleine-Budde
2022-06-03 10:28 ` [PATCH v4 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD Vincent Mailhol
2022-06-04 11:22 ` Marc Kleine-Budde
2022-06-04 12:14 ` Vincent MAILHOL
2022-06-03 10:28 ` [PATCH v4 5/7] net: Kconfig: move the CAN device menu to the "Device Drivers" section Vincent Mailhol
2022-06-03 10:28 ` [PATCH v4 6/7] can: skb: move can_dropped_invalid_skb() and can_skb_headroom_valid() to skb.c Vincent Mailhol
2022-06-03 10:28 ` [PATCH v4 7/7] can: skb: drop tx skb if in listen only mode Vincent Mailhol
2022-06-04 11:46 ` [PATCH v4 0/7] can: refactoring of can-dev module and of Kbuild Marc Kleine-Budde
2022-06-04 13:05 ` Vincent MAILHOL
2022-06-04 13:55 ` Marc Kleine-Budde
2022-06-04 14:59 ` Vincent MAILHOL
2022-06-04 15:18 ` Marc Kleine-Budde
2022-06-04 16:32 ` Vincent MAILHOL
2022-06-05 10:39 ` Marc Kleine-Budde
2022-06-05 13:57 ` Vincent MAILHOL
2022-06-05 18:08 ` Marc Kleine-Budde
2022-06-04 16:29 ` [PATCH v5 " Vincent Mailhol
2022-06-04 16:29 ` [PATCH v5 1/7] can: Kbuild: rename config symbol CAN_DEV into CAN_NETLINK Vincent Mailhol
2022-06-04 16:29 ` [PATCH v5 2/7] can: Kconfig: turn menu "CAN Device Drivers" into a menuconfig using CAN_DEV Vincent Mailhol
2022-06-04 16:29 ` [PATCH v5 3/7] can: bittiming: move bittiming calculation functions to calc_bittiming.c Vincent Mailhol
2022-06-04 16:29 ` [PATCH v5 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD Vincent Mailhol
2022-06-07 8:43 ` Geert Uytterhoeven
2022-06-07 9:27 ` Vincent MAILHOL
2022-06-07 16:22 ` Max Staudt
2022-06-07 22:06 ` Jakub Kicinski
2022-06-07 23:40 ` Vincent MAILHOL
2022-06-08 0:07 ` Jakub Kicinski
2022-06-07 23:43 ` Max Staudt
2022-06-08 0:14 ` Jakub Kicinski
2022-06-08 0:22 ` Max Staudt
2022-06-08 1:38 ` Vincent MAILHOL
2022-06-04 16:29 ` [PATCH v5 5/7] net: Kconfig: move the CAN device menu to the "Device Drivers" section Vincent Mailhol
2022-06-04 16:29 ` [PATCH v5 6/7] can: skb: move can_dropped_invalid_skb() and can_skb_headroom_valid() to skb.c Vincent Mailhol
2022-06-04 16:30 ` [PATCH v5 7/7] can: skb: drop tx skb if in listen only mode Vincent Mailhol
2022-06-05 17:23 ` [PATCH v5 0/7] can: refactoring of can-dev module and of Kbuild Max Staudt
2022-06-05 18:06 ` Marc Kleine-Budde
2022-06-05 20:46 ` Max Staudt
2022-06-06 0:24 ` Vincent MAILHOL
2022-06-06 19:24 ` Oliver Hartkopp
2022-06-07 2:49 ` Vincent MAILHOL
2022-06-07 7:13 ` Marc Kleine-Budde
2022-06-07 8:49 ` Vincent MAILHOL
2022-06-07 20:12 ` Oliver Hartkopp
2022-06-07 20:27 ` Marc Kleine-Budde
2022-06-07 20:51 ` Oliver Hartkopp
2022-06-07 23:59 ` Vincent MAILHOL
2022-06-08 20:10 ` Oliver Hartkopp
2022-06-10 14:30 ` [PATCH v6 " Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 1/7] can: Kconfig: rename config symbol CAN_DEV into CAN_NETLINK Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 2/7] can: Kconfig: turn menu "CAN Device Drivers" into a menuconfig using CAN_DEV Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 3/7] can: bittiming: move bittiming calculation functions to calc_bittiming.c Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 5/7] net: Kconfig: move the CAN device menu to the "Device Drivers" section Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 6/7] can: skb: move can_dropped_invalid_skb() and can_skb_headroom_valid() to skb.c Vincent Mailhol
2022-06-10 14:30 ` [PATCH v6 7/7] can: skb: drop tx skb if in listen only mode Vincent Mailhol
2022-06-10 21:38 ` [PATCH v6 0/7] can: refactoring of can-dev module and of Kbuild Oliver Hartkopp
2022-06-10 22:43 ` Max Staudt
2022-06-11 15:17 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6RqLU-Wg0Cau3cM=QsU-t-7Lyzmo1nJ_VAA4Mbw3u0jnNtw@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=max@enpas.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).