linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shirish Pargaonkar <shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
	Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: linux-next: build warning after merge of the cifs tree
Date: Tue, 19 Oct 2010 10:48:10 -0500	[thread overview]
Message-ID: <AANLkTi=kc_8gqDnMVc4Sjm4=XvuUB+-Y5Tz_8sgfkw7P@mail.gmail.com> (raw)
In-Reply-To: <20101019091339.38e45faa-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>

On Tue, Oct 19, 2010 at 8:13 AM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> On Tue, 19 Oct 2010 16:21:20 +1100
> Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
>
>> Hi Steve,
>>
>> On Fri, 24 Sep 2010 13:55:31 +1000 Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> wrote:
>> >
>> > After merging the irqflags tree, today's linux-next build (powerpc
>> > ppc64_defconfig) produced this warning:
>> >
>> > fs/cifs/sess.c: In function 'CIFS_SessSetup':
>> > fs/cifs/sess.c:595: warning: unused variable 'blob_len'
>> >
>> > Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
>> > NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
>> > CONFIG_CIFS_UPCALL is not set in this build.
>>
>> I am still getting this ...
>>
>
> Yep. Looks clearly broken. blob_len is also declared twice in that
> function which is just plain wrong. What probably makes the most sense
> is to make it a u16 and get rid of the second declaration lower in the
> function. But, there's another semi-related problem here too...
>
> blob_len gets assigned the return value of build_ntlmssp_auth_blob.
> That function however doesn't have any mechanism to pass back an
> error, even though it calls setup_ntlmv2_rsp and that function can
> return one.
>
> The whole house of cards needs a bit of rework I think...
>
> Shirish, since you're already doing work in this area, can you fix that
> too?
>
> Thanks,
> --
> Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>

Looking into it.

  parent reply	other threads:[~2010-10-19 15:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24  3:55 linux-next: build warning after merge of the cifs tree Stephen Rothwell
     [not found] ` <20100924135531.96e5ac72.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-10-19  5:21   ` Stephen Rothwell
2010-10-19 13:13     ` Jeff Layton
     [not found]       ` <20101019091339.38e45faa-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-10-19 15:48         ` Shirish Pargaonkar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-01-19  1:47 Stephen Rothwell
2024-01-19  3:02 ` Steve French
2022-05-23  0:57 Stephen Rothwell
2022-05-23  2:29 ` Steve French
2021-02-04 22:51 Stephen Rothwell
2019-07-18 23:16 Stephen Rothwell
2019-07-18 23:38 ` Steve French
2018-01-03 22:33 Stephen Rothwell
2018-01-03 22:44 ` Steve French
     [not found]   ` <CAH2r5mvgtC3Y_aLxk7-_R8E=ohR1LoFSkiqZZ6rhn9azXY05xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-04  5:52     ` Stephen Rothwell
2017-11-20 23:19 Stephen Rothwell
     [not found] ` <20171121101916.4970d5f9-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2017-11-20 23:37   ` Steve French
2017-06-26  0:07 Stephen Rothwell
     [not found] ` <20170626100728.0494601c-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2017-06-26 16:57   ` Steve French
2011-01-31  2:30 Stephen Rothwell
2011-01-31 10:49 ` Suresh Jayaraman
     [not found]   ` <4D4693CF.9090903-l3A5Bk7waGM@public.gmane.org>
2011-01-31 11:38     ` Pavel Shilovsky
2011-01-31 12:29   ` Jeff Layton
2011-01-31  2:27 Stephen Rothwell
     [not found] ` <20110131132743.4ae5d4ae.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-01-31  3:25   ` Steve French
2011-01-31  2:25 Stephen Rothwell
2011-01-21  1:05 Stephen Rothwell
2011-01-21  1:20 ` Jeff Layton
2010-09-24  3:48 Stephen Rothwell
2010-09-24 11:13 ` Jeff Layton
2010-08-26  1:02 Stephen Rothwell
     [not found] ` <20100826110229.931ab5bf.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-08-26  2:07   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=kc_8gqDnMVc4Sjm4=XvuUB+-Y5Tz_8sgfkw7P@mail.gmail.com' \
    --to=shirishpargaonkar-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).